Rename "...-feature" to "..._feature" in subdirs and features

This change affects both top-level subdirectory names as well as
Eclipse plug-in feature names.  Perhaps it would have been possible to
change only the latter, but I don't like the idea of the two being
different.

These name changes fix three Eclipse plug-in warnings of the form:

	Illegal value '...-feature' for attribute 'id'.
	Legal token characters are "a-z", "A-Z", "0-9", "_".  Tokens
	must be separated by "."

I'll be the first to admit that I know nearly nothing about Eclipse
plug-in development.  If changing these plug-in feature IDs has
broader implications that the automated regression tests won't detect,
then I probably overlooked them too.  I would greatly appreciate
skeptical review of this change by someone who knows Eclipse plug-in
development well.

Note that personal Eclipse workspaces may need some manual adjustment
after this change.  The three "...-feature" Eclipse projects should be
removed from the workspace, and the three corresponding "..._feature"
Eclipse projects should be added.  If you do your git pull using
Eclipse's team features, perhaps it is smart enough to do this for
you?  I don't know, but it wouldn't surprise me if fixing things
manually were still needed even in that case.

com.ibm.wala-repository/category.xml

@@ -1,15 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <site>
-    <feature id="com.ibm.wala-feature">
+    <feature id="com.ibm.wala_feature">
         <category name="main"/>
     </feature>
-    <feature id="com.ibm.wala-feature.source">
+    <feature id="com.ibm.wala_feature.source">
         <category name="main"/>
     </feature>
-    <feature id="com.ibm.wala.ide-feature">
+    <feature id="com.ibm.wala.ide_feature">
         <category name="main"/>
     </feature>
-    <feature id="com.ibm.wala.ide-feature.source">
+    <feature id="com.ibm.wala.ide_feature.source">
         <category name="main"/>
     </feature>
    <category-def name="main" label="Wala"/>

com.ibm.wala.ide.jdt.test/launchers/#com.ibm.wala.ide.jdt.test.launch#

@@ -40,9 +40,9 @@
 <stringAttribute key="product" value="org.eclipse.platform.ide"/>
 <booleanAttribute key="run_in_ui_thread" value="true"/>
 <setAttribute key="selected_features">
-<setEntry value="com.ibm.wala-feature:default"/>
-<setEntry value="com.ibm.wala.ide-feature:default"/>
-<setEntry value="com.ibm.wala.tests-feature:default"/>
+<setEntry value="com.ibm.wala_feature:default"/>
+<setEntry value="com.ibm.wala.ide_feature:default"/>
+<setEntry value="com.ibm.wala.tests_feature:default"/>
 <setEntry value="com.ibm.wala.tests.ide:default"/>
 <setEntry value="org.eclipse.e4.rcp:default"/>
 <setEntry value="org.eclipse.ecf.core.feature:default"/>

com.ibm.wala.ide.jsdt.tests/launchers/com.ibm.wala.ide.jsdt.tests.launch

@@ -41,9 +41,9 @@
 <stringAttribute key="product" value="org.eclipse.platform.ide"/>
 <booleanAttribute key="run_in_ui_thread" value="true"/>
 <setAttribute key="selected_features">
-<setEntry value="com.ibm.wala-feature:default"/>
-<setEntry value="com.ibm.wala.ide-feature:default"/>
-<setEntry value="com.ibm.wala.tests-feature:default"/>
+<setEntry value="com.ibm.wala_feature:default"/>
+<setEntry value="com.ibm.wala.ide_feature:default"/>
+<setEntry value="com.ibm.wala.tests_feature:default"/>
 <setEntry value="com.ibm.wala.tests.ide:default"/>
 <setEntry value="org.eclipse.e4.rcp:default"/>
 <setEntry value="org.eclipse.ecf.core.feature:default"/>

com.ibm.wala.ide_feature/.project

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <projectDescription>
-	<name>com.ibm.wala.ide-feature</name>
+	<name>com.ibm.wala.ide_feature</name>
 	<comment></comment>
 	<projects>
 	</projects>

com.ibm.wala.ide_feature/feature.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <feature
-      id="com.ibm.wala.ide-feature"
+      id="com.ibm.wala.ide_feature"
       label="%featureName"
       version="1.4.4.qualifier"
       provider-name="%providerName">

com.ibm.wala.ide_feature/pom.xml

@@ -7,6 +7,6 @@
         <groupId>com.ibm.wala</groupId>
         <version>1.4.4-SNAPSHOT</version>
     </parent>
-  <artifactId>com.ibm.wala.ide-feature</artifactId>
+  <artifactId>com.ibm.wala.ide_feature</artifactId>
   <packaging>eclipse-feature</packaging>
 </project>

com.ibm.wala.tests.ide_feature/.project

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <projectDescription>
-	<name>com.ibm.wala.tests.ide-feature</name>
+	<name>com.ibm.wala.tests.ide_feature</name>
 	<comment></comment>
 	<projects>
 	</projects>

com.ibm.wala.tests_feature/.project

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <projectDescription>
-	<name>com.ibm.wala.tests-feature</name>
+	<name>com.ibm.wala.tests_feature</name>
 	<comment></comment>
 	<projects>
 	</projects>

com.ibm.wala.tests_feature/feature.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <feature
-      id="com.ibm.wala.tests-feature"
+      id="com.ibm.wala.tests_feature"
       label="%featureName"
       version="1.4.4.qualifier"
       provider-name="%providerName">

com.ibm.wala.tests_feature/pom.xml

@@ -7,6 +7,6 @@
     <groupId>com.ibm.wala</groupId>
     <version>1.4.4-SNAPSHOT</version>
   </parent>
-  <artifactId>com.ibm.wala.tests-feature</artifactId>
+  <artifactId>com.ibm.wala.tests_feature</artifactId>
   <packaging>eclipse-feature</packaging>
 </project>

com.ibm.wala_feature/.project

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <projectDescription>
-	<name>com.ibm.wala-feature</name>
+	<name>com.ibm.wala_feature</name>
 	<comment></comment>
 	<projects>
 	</projects>

com.ibm.wala_feature/feature.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <feature
-      id="com.ibm.wala-feature"
+      id="com.ibm.wala_feature"
       label="%featureName"
       version="1.4.4.qualifier"
       provider-name="%providerName">

com.ibm.wala_feature/pom.xml

@@ -7,6 +7,6 @@
     <groupId>com.ibm.wala</groupId>
     <version>1.4.4-SNAPSHOT</version>
   </parent>
-  <artifactId>com.ibm.wala-feature</artifactId>
+  <artifactId>com.ibm.wala_feature</artifactId>
   <packaging>eclipse-feature</packaging>
 </project>

pom.xml

@@ -18,7 +18,7 @@
   <modules>
     <module>targets</module>
 
-    <module>com.ibm.wala-feature</module>
+    <module>com.ibm.wala_feature</module>
     <module>com.ibm.wala.core</module>
     <module>com.ibm.wala.shrike</module>
     <module>com.ibm.wala.util</module>
@@ -34,7 +34,7 @@
 
     <module>com.ibm.wala.cast.java.ecj</module>
     
-    <module>com.ibm.wala.ide-feature</module>
+    <module>com.ibm.wala.ide_feature</module>
     <module>com.ibm.wala.ide</module>
     <module>com.ibm.wala.ide.tests</module>