"@todo" is not a valid Javadoc tag
This commit is contained in:
Ben Liblit
parent
73e6291a8a
commit
0a770ce7ab
|
|
@ -3275,7 +3275,7 @@ public class DexIMethod implements IBytecodeMethod<Instruction> {
|
|||
*
|
||||
* @throws UnsupportedOperationException
|
||||
*
|
||||
* @todo Review this implementation - it may be horribly wrong!
|
||||
* TODO: Review this implementation - it may be horribly wrong!
|
||||
*/
|
||||
@Override
|
||||
public Collection<CallSiteReference> getCallSites() {
|
||||
|
|
|
|||
|
|
@ -87,7 +87,7 @@ import com.ibm.wala.util.strings.Atom;
|
|||
* @see com.ibm.wala.ipa.callgraph.impl.FakeRootClass
|
||||
*
|
||||
* @author Tobias Blaschke <code@tobiasblaschke.de>
|
||||
* @todo Move this class into an other loader? Currently: Primordial
|
||||
* TODO: Move this class into an other loader? Currently: Primordial
|
||||
*/
|
||||
public final /* singleton */ class AndroidModelClass extends SyntheticClass {
|
||||
private static Logger logger = LoggerFactory.getLogger(AndroidModelClass.class);
|
||||
|
|
|
|||
|
|
@ -66,9 +66,10 @@ import com.ibm.wala.util.ssa.SSAValue;
|
|||
* @since 2013-09-19
|
||||
*
|
||||
* TODO:
|
||||
* @todo Track if a variable has been refered to to be able to prune unused Phi-Instructions later
|
||||
* @todo Trim Memory consumption? The whole class should not be in memory for long time so this
|
||||
* might be not neccessary.
|
||||
* <ul>
|
||||
* <li>Track if a variable has been refered to to be able to prune unused Phi-Instructions later</li>
|
||||
* <li>Trim Memory consumption? The whole class should not be in * memory for long time so this might be not neccessary.</li>
|
||||
* </ul>
|
||||
*/
|
||||
public class AndroidModelParameterManager {
|
||||
|
||||
|
|
|
|||
|
|
@ -137,7 +137,7 @@ public class FlatInstantiator implements IInstantiator {
|
|||
*
|
||||
* If T is an array-type a new array of length 1 is generated.
|
||||
*
|
||||
* @todo Do we want to mix in REUSE-Parameters?
|
||||
* TODO: Do we want to mix in REUSE-Parameters?
|
||||
*/
|
||||
public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) {
|
||||
return createInstance(T, asManaged, key, seen, 0);
|
||||
|
|
|
|||
|
|
@ -126,7 +126,7 @@ public class Instantiator implements IInstantiator {
|
|||
*
|
||||
* If T is an array-type a new array of length 1 is generated.
|
||||
*
|
||||
* @todo Do we want to mix in REUSE-Parameters?
|
||||
* TODO: Do we want to mix in REUSE-Parameters?
|
||||
*/
|
||||
public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) {
|
||||
if (T == null) {
|
||||
|
|
|
|||
|
|
@ -96,7 +96,7 @@ public class SpecializedInstantiator extends FlatInstantiator {
|
|||
*
|
||||
* If T is an array-type a new array of length 1 is generated.
|
||||
*
|
||||
* @todo Do we want to mix in REUSE-Parameters?
|
||||
* TODO: Do we want to mix in REUSE-Parameters?
|
||||
*/
|
||||
@Override
|
||||
public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) {
|
||||
|
|
|
|||
|
|
@ -194,7 +194,7 @@ public class Overrides {
|
|||
* the MethodTargetSelector returned.
|
||||
*
|
||||
* @return a MethodTargetSelector that overrides all startComponent-calls.
|
||||
* @todo Use delayed computation?
|
||||
* TODO: Use delayed computation?
|
||||
*/
|
||||
public MethodTargetSelector overrideAll() throws CancelException {
|
||||
final HashMap<MethodReference, SummarizedMethod> overrides = HashMapFactory.make();
|
||||
|
|
|
|||
|
|
@ -182,7 +182,7 @@ public class SystemServiceModel extends AndroidModel {
|
|||
/**
|
||||
* Fill the model with instructions.
|
||||
*
|
||||
* @todo use "global" instances
|
||||
* TODO: use "global" instances
|
||||
*/
|
||||
//@Override
|
||||
private void populate(Iterable<? extends AndroidEntryPoint> entrypoints) {
|
||||
|
|
|
|||
|
|
@ -253,7 +253,7 @@ public class Intent implements ContextItem, Comparable<Intent> {
|
|||
* IntentStarters.StartInfo to determine the Target. However it is nicer to set the Component
|
||||
* here.
|
||||
*
|
||||
* @todo Set the Component somewhere
|
||||
* TODO: Set the Component somewhere
|
||||
*/
|
||||
public AndroidComponent getComponent() {
|
||||
return this.targetCompontent;
|
||||
|
|
@ -272,9 +272,9 @@ public class Intent implements ContextItem, Comparable<Intent> {
|
|||
* Recomputes if the Intent is internal.
|
||||
* TODO:
|
||||
* @param intent
|
||||
* @todo Implement it ;)
|
||||
* @todo What to return if it does not, but Summary-Information is available?
|
||||
* @todo We should read in the Manifest.xml rather than relying on the packet name!
|
||||
* TODO: Implement it ;)
|
||||
* TODO: What to return if it does not, but Summary-Information is available?
|
||||
* TODO: We should read in the Manifest.xml rather than relying on the packet name!
|
||||
*/
|
||||
private static boolean isInternal(Intent intent) { // XXX: This may loop forever!
|
||||
/*final Intent override = AndroidEntryPointManager.MANAGER.getIntent(intent);
|
||||
|
|
|
|||
|
|
@ -61,8 +61,8 @@ import com.ibm.wala.util.collections.HashMapFactory;
|
|||
* This is used by the IntentContextSelector to add an IntentContext to this Methods.
|
||||
*
|
||||
* TODO:
|
||||
* @todo Fill in better values for targetAccuracy and componentType
|
||||
* @todo Add declaring class
|
||||
* TODO: Fill in better values for targetAccuracy and componentType
|
||||
* TODO: Add declaring class
|
||||
* @author Tobias Blaschke <code@tobiasblaschke.de>
|
||||
* @since 1013-10-16
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -201,7 +201,7 @@ nextMethod:
|
|||
// Restrict the set
|
||||
bases.add(AndroidTypes.Application);
|
||||
bases.add(AndroidTypes.Activity);
|
||||
/** @todo TODO: add Fragments in getEntryPoints */
|
||||
/** TODO: TODO: add Fragments in getEntryPoints */
|
||||
//bases.add(AndroidTypes.Fragment);
|
||||
bases.add(AndroidTypes.Service);
|
||||
bases.add(AndroidTypes.ContentProvider);
|
||||
|
|
|
|||
|
|
@ -583,7 +583,7 @@ public final /* singleton */ class AndroidEntryPointManager implements Serializa
|
|||
* @param intent The intent to resolve
|
||||
* @return where to resolve it to or the given intent if no information is available
|
||||
*
|
||||
* @todo TODO: Malicious Intent-Table could cause endless loops
|
||||
* TODO: TODO: Malicious Intent-Table could cause endless loops
|
||||
*/
|
||||
public Intent getIntent(Intent intent) {
|
||||
if (overrideIntents.containsKey(intent)) {
|
||||
|
|
|
|||
|
|
@ -83,7 +83,7 @@ import com.ibm.wala.dalvik.ipa.callgraph.propagation.cfa.Intent;
|
|||
* You will be able to access it using attributesHistory.get(Attr).peek()
|
||||
*
|
||||
* TODO:
|
||||
* @todo Handle Info in the DATA-Tag correctly!
|
||||
* TODO: Handle Info in the DATA-Tag correctly!
|
||||
* @since 2013-10-13
|
||||
* @author Tobias Blaschke <code@tobiasblaschke.de>
|
||||
*/
|
||||
|
|
@ -520,7 +520,7 @@ public class AndroidManifestXMLReader {
|
|||
/**
|
||||
* Read the specification of an Intent from AndroidManifest.
|
||||
*
|
||||
* @todo Handle the URI
|
||||
* TODO: Handle the URI
|
||||
*/
|
||||
private static class IntentItem extends ParserItem {
|
||||
@Override
|
||||
|
|
|
|||
|
|
@ -128,7 +128,7 @@ public class AndroidPreFlightChecks {
|
|||
* @see com.ibm.wala.dalvik.ipa.callgraph.androidModel.stubs.Overrides.StartComponentMethodTargetSelector
|
||||
*
|
||||
* @return if check passed
|
||||
* @todo this doesn't check anything yet
|
||||
* TODO: this doesn't check anything yet
|
||||
*/
|
||||
public boolean checkOverridesInPlace() {
|
||||
boolean pass = true;
|
||||
|
|
|
|||
|
|
@ -137,7 +137,7 @@ public class AndroidSettingFactory {
|
|||
* @param name The Action this intent represents
|
||||
* @param uri The URI to match may be null
|
||||
* @throws IllegalArgumentException If name was null or starts with a dot and pack is null
|
||||
* @todo Check Target-Types
|
||||
* TODO: Check Target-Types
|
||||
*/
|
||||
public static Intent intent(String pack, String name, String uri) {
|
||||
if ((name == null) || (name.isEmpty())) {
|
||||
|
|
|
|||
Loading…
Reference in New Issue