"@todo" is not a valid Javadoc tag

This commit is contained in:
Ben Liblit 2017-12-19 16:17:11 -06:00
parent 73e6291a8a
commit 0a770ce7ab
15 changed files with 23 additions and 22 deletions

View File

@ -3275,7 +3275,7 @@ public class DexIMethod implements IBytecodeMethod<Instruction> {
* *
* @throws UnsupportedOperationException * @throws UnsupportedOperationException
* *
* @todo Review this implementation - it may be horribly wrong! * TODO: Review this implementation - it may be horribly wrong!
*/ */
@Override @Override
public Collection<CallSiteReference> getCallSites() { public Collection<CallSiteReference> getCallSites() {

View File

@ -87,7 +87,7 @@ import com.ibm.wala.util.strings.Atom;
* @see com.ibm.wala.ipa.callgraph.impl.FakeRootClass * @see com.ibm.wala.ipa.callgraph.impl.FakeRootClass
* *
* @author Tobias Blaschke &lt;code@tobiasblaschke.de&gt; * @author Tobias Blaschke &lt;code@tobiasblaschke.de&gt;
* @todo Move this class into an other loader? Currently: Primordial * TODO: Move this class into an other loader? Currently: Primordial
*/ */
public final /* singleton */ class AndroidModelClass extends SyntheticClass { public final /* singleton */ class AndroidModelClass extends SyntheticClass {
private static Logger logger = LoggerFactory.getLogger(AndroidModelClass.class); private static Logger logger = LoggerFactory.getLogger(AndroidModelClass.class);

View File

@ -66,9 +66,10 @@ import com.ibm.wala.util.ssa.SSAValue;
* @since 2013-09-19 * @since 2013-09-19
* *
* TODO: * TODO:
* @todo Track if a variable has been refered to to be able to prune unused Phi-Instructions later * <ul>
* @todo Trim Memory consumption? The whole class should not be in memory for long time so this * <li>Track if a variable has been refered to to be able to prune unused Phi-Instructions later</li>
* might be not neccessary. * <li>Trim Memory consumption? The whole class should not be in * memory for long time so this might be not neccessary.</li>
* </ul>
*/ */
public class AndroidModelParameterManager { public class AndroidModelParameterManager {

View File

@ -137,7 +137,7 @@ public class FlatInstantiator implements IInstantiator {
* *
* If T is an array-type a new array of length 1 is generated. * If T is an array-type a new array of length 1 is generated.
* *
* @todo Do we want to mix in REUSE-Parameters? * TODO: Do we want to mix in REUSE-Parameters?
*/ */
public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) { public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) {
return createInstance(T, asManaged, key, seen, 0); return createInstance(T, asManaged, key, seen, 0);

View File

@ -126,7 +126,7 @@ public class Instantiator implements IInstantiator {
* *
* If T is an array-type a new array of length 1 is generated. * If T is an array-type a new array of length 1 is generated.
* *
* @todo Do we want to mix in REUSE-Parameters? * TODO: Do we want to mix in REUSE-Parameters?
*/ */
public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) { public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) {
if (T == null) { if (T == null) {

View File

@ -96,7 +96,7 @@ public class SpecializedInstantiator extends FlatInstantiator {
* *
* If T is an array-type a new array of length 1 is generated. * If T is an array-type a new array of length 1 is generated.
* *
* @todo Do we want to mix in REUSE-Parameters? * TODO: Do we want to mix in REUSE-Parameters?
*/ */
@Override @Override
public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) { public SSAValue createInstance(final TypeReference T, final boolean asManaged, VariableKey key, Set<? extends SSAValue> seen) {

View File

@ -194,7 +194,7 @@ public class Overrides {
* the MethodTargetSelector returned. * the MethodTargetSelector returned.
* *
* @return a MethodTargetSelector that overrides all startComponent-calls. * @return a MethodTargetSelector that overrides all startComponent-calls.
* @todo Use delayed computation? * TODO: Use delayed computation?
*/ */
public MethodTargetSelector overrideAll() throws CancelException { public MethodTargetSelector overrideAll() throws CancelException {
final HashMap<MethodReference, SummarizedMethod> overrides = HashMapFactory.make(); final HashMap<MethodReference, SummarizedMethod> overrides = HashMapFactory.make();

View File

@ -182,7 +182,7 @@ public class SystemServiceModel extends AndroidModel {
/** /**
* Fill the model with instructions. * Fill the model with instructions.
* *
* @todo use "global" instances * TODO: use "global" instances
*/ */
//@Override //@Override
private void populate(Iterable<? extends AndroidEntryPoint> entrypoints) { private void populate(Iterable<? extends AndroidEntryPoint> entrypoints) {

View File

@ -253,7 +253,7 @@ public class Intent implements ContextItem, Comparable<Intent> {
* IntentStarters.StartInfo to determine the Target. However it is nicer to set the Component * IntentStarters.StartInfo to determine the Target. However it is nicer to set the Component
* here. * here.
* *
* @todo Set the Component somewhere * TODO: Set the Component somewhere
*/ */
public AndroidComponent getComponent() { public AndroidComponent getComponent() {
return this.targetCompontent; return this.targetCompontent;
@ -272,9 +272,9 @@ public class Intent implements ContextItem, Comparable<Intent> {
* Recomputes if the Intent is internal. * Recomputes if the Intent is internal.
* TODO: * TODO:
* @param intent * @param intent
* @todo Implement it ;) * TODO: Implement it ;)
* @todo What to return if it does not, but Summary-Information is available? * TODO: What to return if it does not, but Summary-Information is available?
* @todo We should read in the Manifest.xml rather than relying on the packet name! * TODO: We should read in the Manifest.xml rather than relying on the packet name!
*/ */
private static boolean isInternal(Intent intent) { // XXX: This may loop forever! private static boolean isInternal(Intent intent) { // XXX: This may loop forever!
/*final Intent override = AndroidEntryPointManager.MANAGER.getIntent(intent); /*final Intent override = AndroidEntryPointManager.MANAGER.getIntent(intent);

View File

@ -61,8 +61,8 @@ import com.ibm.wala.util.collections.HashMapFactory;
* This is used by the IntentContextSelector to add an IntentContext to this Methods. * This is used by the IntentContextSelector to add an IntentContext to this Methods.
* *
* TODO: * TODO:
* @todo Fill in better values for targetAccuracy and componentType * TODO: Fill in better values for targetAccuracy and componentType
* @todo Add declaring class * TODO: Add declaring class
* @author Tobias Blaschke &lt;code@tobiasblaschke.de&gt; * @author Tobias Blaschke &lt;code@tobiasblaschke.de&gt;
* @since 1013-10-16 * @since 1013-10-16
*/ */

View File

@ -201,7 +201,7 @@ nextMethod:
// Restrict the set // Restrict the set
bases.add(AndroidTypes.Application); bases.add(AndroidTypes.Application);
bases.add(AndroidTypes.Activity); bases.add(AndroidTypes.Activity);
/** @todo TODO: add Fragments in getEntryPoints */ /** TODO: TODO: add Fragments in getEntryPoints */
//bases.add(AndroidTypes.Fragment); //bases.add(AndroidTypes.Fragment);
bases.add(AndroidTypes.Service); bases.add(AndroidTypes.Service);
bases.add(AndroidTypes.ContentProvider); bases.add(AndroidTypes.ContentProvider);

View File

@ -583,7 +583,7 @@ public final /* singleton */ class AndroidEntryPointManager implements Serializa
* @param intent The intent to resolve * @param intent The intent to resolve
* @return where to resolve it to or the given intent if no information is available * @return where to resolve it to or the given intent if no information is available
* *
* @todo TODO: Malicious Intent-Table could cause endless loops * TODO: TODO: Malicious Intent-Table could cause endless loops
*/ */
public Intent getIntent(Intent intent) { public Intent getIntent(Intent intent) {
if (overrideIntents.containsKey(intent)) { if (overrideIntents.containsKey(intent)) {

View File

@ -83,7 +83,7 @@ import com.ibm.wala.dalvik.ipa.callgraph.propagation.cfa.Intent;
* You will be able to access it using attributesHistory.get(Attr).peek() * You will be able to access it using attributesHistory.get(Attr).peek()
* *
* TODO: * TODO:
* @todo Handle Info in the DATA-Tag correctly! * TODO: Handle Info in the DATA-Tag correctly!
* @since 2013-10-13 * @since 2013-10-13
* @author Tobias Blaschke &lt;code@tobiasblaschke.de&gt; * @author Tobias Blaschke &lt;code@tobiasblaschke.de&gt;
*/ */
@ -520,7 +520,7 @@ public class AndroidManifestXMLReader {
/** /**
* Read the specification of an Intent from AndroidManifest. * Read the specification of an Intent from AndroidManifest.
* *
* @todo Handle the URI * TODO: Handle the URI
*/ */
private static class IntentItem extends ParserItem { private static class IntentItem extends ParserItem {
@Override @Override

View File

@ -128,7 +128,7 @@ public class AndroidPreFlightChecks {
* @see com.ibm.wala.dalvik.ipa.callgraph.androidModel.stubs.Overrides.StartComponentMethodTargetSelector * @see com.ibm.wala.dalvik.ipa.callgraph.androidModel.stubs.Overrides.StartComponentMethodTargetSelector
* *
* @return if check passed * @return if check passed
* @todo this doesn't check anything yet * TODO: this doesn't check anything yet
*/ */
public boolean checkOverridesInPlace() { public boolean checkOverridesInPlace() {
boolean pass = true; boolean pass = true;

View File

@ -137,7 +137,7 @@ public class AndroidSettingFactory {
* @param name The Action this intent represents * @param name The Action this intent represents
* @param uri The URI to match may be null * @param uri The URI to match may be null
* @throws IllegalArgumentException If name was null or starts with a dot and pack is null * @throws IllegalArgumentException If name was null or starts with a dot and pack is null
* @todo Check Target-Types * TODO: Check Target-Types
*/ */
public static Intent intent(String pack, String name, String uri) { public static Intent intent(String pack, String name, String uri) {
if ((name == null) || (name.isEmpty())) { if ((name == null) || (name.isEmpty())) {