From 173209a7bbef0201cf2f00f15ad1f5b105bf0330 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 6 Nov 2016 12:10:24 -0600 Subject: [PATCH 01/12] Eclipse wants "META-INF/" to be included in "bin.includes" Other subdirectories' "build.properties" generally seem to include this already, so who am I to argue? This resolves one "An entry for META-INF/ is required in bin.includes" Eclipse warning. Also update the project configuration to treat this warning as an error. This should discourage commits that create new instances of this sort of problem in the future. --- com.ibm.wala.cast.js.test.data/.settings/org.eclipse.pde.prefs | 1 + com.ibm.wala.cast.js.test.data/build.properties | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 com.ibm.wala.cast.js.test.data/.settings/org.eclipse.pde.prefs diff --git a/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.pde.prefs b/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.pde.prefs new file mode 100644 index 000000000..82cdecfe4 --- /dev/null +++ b/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.pde.prefs @@ -0,0 +1 @@ +compilers.p.build.bin.includes=0 diff --git a/com.ibm.wala.cast.js.test.data/build.properties b/com.ibm.wala.cast.js.test.data/build.properties index 748041422..f95f1e560 100644 --- a/com.ibm.wala.cast.js.test.data/build.properties +++ b/com.ibm.wala.cast.js.test.data/build.properties @@ -1 +1,2 @@ -bin.includes = examples-src/ +bin.includes = examples-src/,\ + META-INF/ From 8b7a163110076725c5b47cd1bdf444ac659b01d1 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 6 Nov 2016 11:55:13 -0600 Subject: [PATCH 02/12] The "lib" subdirectory contains no Java sources This resolves one "'...' is not a source folder" Eclipse warning. Also update the project configuration to treat this warning as an error. This should discourage commits that create new instances of this sort of problem in the future. --- com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs | 1 + com.ibm.wala.dalvik/build.properties | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs diff --git a/com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs b/com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs new file mode 100644 index 000000000..526dc9827 --- /dev/null +++ b/com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs @@ -0,0 +1 @@ +compilers.p.build.source.library=0 diff --git a/com.ibm.wala.dalvik/build.properties b/com.ibm.wala.dalvik/build.properties index ccd712218..823229746 100644 --- a/com.ibm.wala.dalvik/build.properties +++ b/com.ibm.wala.dalvik/build.properties @@ -9,6 +9,5 @@ bin.includes = META-INF/,\ lib/slf4j-api-1.7.2.jar jars.compile.order = . output.. = bin/ -source.. = src/,\ - lib/ +source.. = src/ From d4a0a5ddd40893e6d9af05394e6a3e8651530bad Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 6 Nov 2016 11:54:25 -0600 Subject: [PATCH 03/12] Delist a JAR that is not actually present This resolves one Eclipse "'...' build entry is missing" warning. Also update the project configuration to treat this warning as an error. This should discourage commits that create new instances of this sort of problem in the future. --- com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs | 1 + com.ibm.wala.dalvik/META-INF/MANIFEST.MF | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs b/com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs index 526dc9827..db25a1cc6 100644 --- a/com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs +++ b/com.ibm.wala.dalvik/.settings/org.eclipse.pde.prefs @@ -1 +1,2 @@ +compilers.p.build=0 compilers.p.build.source.library=0 diff --git a/com.ibm.wala.dalvik/META-INF/MANIFEST.MF b/com.ibm.wala.dalvik/META-INF/MANIFEST.MF index 95dc0116a..f2eedaf62 100644 --- a/com.ibm.wala.dalvik/META-INF/MANIFEST.MF +++ b/com.ibm.wala.dalvik/META-INF/MANIFEST.MF @@ -51,7 +51,6 @@ Export-Package: com.google.common.annotations, Bundle-ClassPath: ., lib/commons-cli-1.2.jar, lib/commons-io-2.4.jar, - lib/commons-lang3-3.1.jar, lib/dexlib-1.3.4.jar, lib/guava-13.0.1.jar, lib/logback-classic-1.0.9.jar, From 20014e2cb2920f91b9b7831e905c0e12aca5030a Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sat, 26 Nov 2016 20:08:13 -0600 Subject: [PATCH 04/12] "plugin" does not exist here, and therefore needs no localization This fixes one Eclipse "no valid properties files exist in the localization directory specified" warning. Ordinarily I would also change this project's configuration to treat this warning as an error in the future. That's a good way to discourage regressions. Unfortunately in this particular case I cannot find a setting that has the desired effect, even after hunting around in Eclipse PDE sources. It seemed that setting "compilers.p.unknown-resource=0" in "com.ibm.wala.util/.settings/org.eclipse.pde.prefs" should do the trick, but it does not. I don't know why. --- com.ibm.wala.cast.js.test.data/META-INF/MANIFEST.MF | 1 - 1 file changed, 1 deletion(-) diff --git a/com.ibm.wala.cast.js.test.data/META-INF/MANIFEST.MF b/com.ibm.wala.cast.js.test.data/META-INF/MANIFEST.MF index 98d7ced22..f7dace881 100644 --- a/com.ibm.wala.cast.js.test.data/META-INF/MANIFEST.MF +++ b/com.ibm.wala.cast.js.test.data/META-INF/MANIFEST.MF @@ -5,7 +5,6 @@ Bundle-Name: %pluginName Bundle-SymbolicName: com.ibm.wala.cast.js.test.data;singleton:=true Bundle-Version: 1.3.10.qualifier Bundle-Vendor: %providerName -Bundle-Localization: plugin Bundle-ActivationPolicy: lazy Bundle-ClassPath: examples-src/ Bundle-RequiredExecutionEnvironment: JavaSE-1.7 From 5381bd173597db958a21d215ce6b0c73d1feaf66 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 27 Nov 2016 16:48:15 -0600 Subject: [PATCH 05/12] Exclude third-party HTML pages from validation The WALA team does not maintain these pages, and therefore is not in a good position to address HTML validation warnings arising within them. --- .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 com.ibm.wala.core.testdata/.settings/org.eclipse.wst.validation.prefs diff --git a/com.ibm.wala.core.testdata/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.core.testdata/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..b4efdafaf --- /dev/null +++ b/com.ibm.wala.core.testdata/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0204file141ocaml/ocamljava-2.0-alpha1/doc/concurrentT0204file137ocaml/ocamljava-2.0-alpha1/doc/manualT02 +vf.version=3 From 7d7a9c7e85ef65325772c8cf271d0d842f43488a Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 27 Nov 2016 16:49:17 -0600 Subject: [PATCH 06/12] Exclude intentionally-malformed HTML pages from validation Some test files are intentionally invalid HTML. There's no point in having Eclipse remind us of this fact. --- .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs diff --git a/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..d3f17ed4b --- /dev/null +++ b/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0204file131examples-src/pages/garbage.htmlT0304file132examples-src/pages/garbage2.htmlT03 +vf.version=3 From 2a5503b9aa4e29039744fbe5b1f79fb4efd9625b Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 27 Nov 2016 18:22:07 -0600 Subject: [PATCH 07/12] Exclude Maven-generated HTML pages from validation Eclipse validation warns about invalid HTML content in all Maven-generated "target/site/dependency-convergence.html" files. The warnings are legitimate: these HTML files are indeed invalid. However, we don't maintain the tool that generates these files, so we are not in a position to fix them. Better, therefore, to suppress these warnings so that we can notice and fix other problems over which we do have control. --- .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 2 +- .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 2 +- .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ .../.settings/org.eclipse.wst.validation.prefs | 9 +++++++++ 29 files changed, 245 insertions(+), 2 deletions(-) create mode 100644 com.ibm.wala-feature/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala-repository/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.java.ecj/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.java.test.data/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.java.test/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.java/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.js.html.nu_validator/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.js.rhino.test/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.js.rhino/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.js.test/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.js/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast.test/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.cast/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.core.tests/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.core/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.dalvik.test/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.dalvik/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.ide-feature/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.ide.jdt.test/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.ide.jdt/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.ide.jsdt/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.ide.tests/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.ide/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.scandroid/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.shrike/.settings/org.eclipse.wst.validation.prefs create mode 100644 com.ibm.wala.util/.settings/org.eclipse.wst.validation.prefs diff --git a/com.ibm.wala-feature/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala-feature/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala-feature/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala-repository/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala-repository/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala-repository/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.java.test.data/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.java.test.data/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.java.test.data/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.java.test/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.java.test/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.java.test/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.java/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.java/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.java/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.js.html.nu_validator/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.js.html.nu_validator/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.js.html.nu_validator/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.js.rhino.test/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.js.rhino.test/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.js.rhino.test/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.js.rhino/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.js.rhino/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.js.rhino/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs index d3f17ed4b..a774c9e15 100644 --- a/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs +++ b/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs @@ -5,5 +5,5 @@ USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2 eclipse.preferences.version=1 override=true suspend=false -vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0204file131examples-src/pages/garbage.htmlT0304file132examples-src/pages/garbage2.htmlT03 +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0304file131examples-src/pages/garbage.htmlT0304file132examples-src/pages/garbage2.htmlT0304file139target/site/dependency-convergence.htmlT03 vf.version=3 diff --git a/com.ibm.wala.cast.js.test/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.js.test/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.js.test/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.js/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.js/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.js/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast.test/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.test/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast.test/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.cast/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.cast/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.core.testdata/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.core.testdata/.settings/org.eclipse.wst.validation.prefs index b4efdafaf..0518569aa 100644 --- a/com.ibm.wala.core.testdata/.settings/org.eclipse.wst.validation.prefs +++ b/com.ibm.wala.core.testdata/.settings/org.eclipse.wst.validation.prefs @@ -5,5 +5,5 @@ USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2 eclipse.preferences.version=1 override=true suspend=false -vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0204file141ocaml/ocamljava-2.0-alpha1/doc/concurrentT0204file137ocaml/ocamljava-2.0-alpha1/doc/manualT02 +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0304file141ocaml/ocamljava-2.0-alpha1/doc/concurrentT0204file137ocaml/ocamljava-2.0-alpha1/doc/manualT0204file139target/site/dependency-convergence.htmlT03 vf.version=3 diff --git a/com.ibm.wala.core.tests/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.core.tests/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.core.tests/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.core/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.core/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.core/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.dalvik.test/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.dalvik.test/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.dalvik.test/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.dalvik/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.dalvik/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.dalvik/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.ide-feature/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide-feature/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.ide-feature/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.ide.jdt.test/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide.jdt.test/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.ide.jdt.test/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.ide.jdt/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide.jdt/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.ide.jdt/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.ide.jsdt/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide.jsdt/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.ide.jsdt/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.ide.tests/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide.tests/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.ide.tests/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.ide/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.ide/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.scandroid/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.scandroid/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.scandroid/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.shrike/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.shrike/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.shrike/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 diff --git a/com.ibm.wala.util/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.util/.settings/org.eclipse.wst.validation.prefs new file mode 100644 index 000000000..2a10e1a5b --- /dev/null +++ b/com.ibm.wala.util/.settings/org.eclipse.wst.validation.prefs @@ -0,0 +1,9 @@ +DELEGATES_PREFERENCE=delegateValidatorList +USER_BUILD_PREFERENCE=enabledBuildValidatorList +USER_MANUAL_PREFERENCE=enabledManualValidatorList +USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2.700.v201610061600 +eclipse.preferences.version=1 +override=true +suspend=false +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vf.version=3 From 5962e1c9ee1c7b9df9f0309d10e71e1043476466 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 27 Nov 2016 19:18:04 -0600 Subject: [PATCH 08/12] Exclude some hand-written HTML test pages from validation It's unclear whether the original authors of these pages intended them to be valid or invalid. Certainly there is merit in testing against invalid HTML, since the vast majority of real-world HTML is indeed invalid. I'm going to assume that any errors in this collection of test inputs are intentional, and therefore not worth reporting when running Eclipse HTML validation. --- .../.settings/org.eclipse.wst.validation.prefs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs index a774c9e15..30df08dd7 100644 --- a/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs +++ b/com.ibm.wala.cast.js.test.data/.settings/org.eclipse.wst.validation.prefs @@ -5,5 +5,5 @@ USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2 eclipse.preferences.version=1 override=true suspend=false -vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0304file131examples-src/pages/garbage.htmlT0304file132examples-src/pages/garbage2.htmlT0304file139target/site/dependency-convergence.htmlT03 +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude11804file131examples-src/pages/garbage.htmlT0304file132examples-src/pages/garbage2.htmlT0304file139target/site/dependency-convergence.htmlT0304file136examples-src/ajaxslt/test/xpath.htmlT0304file139examples-src/ajaxslt/xslt_unittest.htmlT0304file135examples-src/ajaxslt/test/xslt.htmlT0304file129examples-src/pages/page4.htmlT0304file128examples-src/pages/list.htmlT0304file129examples-src/pages/page1.htmlT0304file129examples-src/pages/page2.htmlT0304file133examples-src/pages/prototype.htmlT0304file133examples-src/pages/prototype.htmlT0304file132examples-src/pages/skeleton.htmlT0304file133examples-src/pages/skeleton2.htmlT0304file133examples-src/pages/skeleton3.htmlT0304file136examples-src/pages/windowonload.htmlT0304file131examples-src/pages/windowx.htmlT0304file145examples-src/tests/portal-example-simple.htmlT03 vf.version=3 From e5e51110c3e2297002578d02873bbca3ee3e7505 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 27 Nov 2016 19:22:53 -0600 Subject: [PATCH 09/12] Exclude plugin-provided HTML pages from validation Plugin documentation includes plenty of invalid HTML. However, we don't maintain these files, so we are not in a position to fix them. Better, therefore, to suppress these warnings so that we can notice and fix other problems over which we do have control. --- .../.settings/org.eclipse.wst.validation.prefs | 2 +- .../.settings/org.eclipse.wst.validation.prefs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/com.ibm.wala.ide.jdt.test/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide.jdt.test/.settings/org.eclipse.wst.validation.prefs index 2a10e1a5b..b20ea697a 100644 --- a/com.ibm.wala.ide.jdt.test/.settings/org.eclipse.wst.validation.prefs +++ b/com.ibm.wala.ide.jdt.test/.settings/org.eclipse.wst.validation.prefs @@ -5,5 +5,5 @@ USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2 eclipse.preferences.version=1 override=true suspend=false -vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0204file139target/site/dependency-convergence.htmlT0304file119target/work/pluginsT02 vf.version=3 diff --git a/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs index 2a10e1a5b..b20ea697a 100644 --- a/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs +++ b/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs @@ -5,5 +5,5 @@ USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2 eclipse.preferences.version=1 override=true suspend=false -vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0104file139target/site/dependency-convergence.htmlT03 +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0204file139target/site/dependency-convergence.htmlT0304file119target/work/pluginsT02 vf.version=3 From f33efbf9913ae66fbd30ed03f0a8054f1094ceb0 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 27 Nov 2016 19:34:55 -0600 Subject: [PATCH 10/12] Exclude some hand-written HTML test pages from validation It's unclear whether the original authors of these pages intended them to be valid or invalid. Certainly there is merit in testing against invalid HTML, since the vast majority of real-world HTML is indeed invalid. I'm going to assume that any errors in this collection of test inputs are intentional, and therefore not worth reporting when running Eclipse HTML validation. --- .../.settings/org.eclipse.wst.validation.prefs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs b/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs index b20ea697a..d44c65ccb 100644 --- a/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs +++ b/com.ibm.wala.ide.jsdt.tests/.settings/org.eclipse.wst.validation.prefs @@ -5,5 +5,5 @@ USER_PREFERENCE=overrideGlobalPreferencestruedisableAllValidationfalseversion1.2 eclipse.preferences.version=1 override=true suspend=false -vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude0204file139target/site/dependency-convergence.htmlT0304file119target/work/pluginsT02 +vals/org.eclipse.wst.html.core.HTMLValidator/groups=0107include06111contentType136org.eclipse.wst.html.core.htmlsourceT07fileext04htmlF07fileext05xhtmlF07fileext03htmF07fileext04htplF07fileext03wmlF0107exclude11004file139target/site/dependency-convergence.htmlT0304file119target/work/pluginsT0204file176target/work/data/com.ibm.wala.cast.js.test.data/examples-src/pages/list.htmlT0304file177target/work/data/com.ibm.wala.cast.js.test.data/examples-src/pages/page1.htmlT0304file177target/work/data/com.ibm.wala.cast.js.test.data/examples-src/pages/page2.htmlT0304file177target/work/data/com.ibm.wala.cast.js.test.data/examples-src/pages/page1.htmlT0304file177target/work/data/com.ibm.wala.cast.js.test.data/examples-src/pages/page2.htmlT0304file177target/work/data/com.ibm.wala.cast.js.test.data/examples-src/pages/page4.htmlT0304file179target/work/data/com.ibm.wala.cast.js.test.data/examples-src/pages/windowx.htmlT0304file193target/work/data/com.ibm.wala.cast.js.test.data/examples-src/tests/portal-example-simple.htmlT03 vf.version=3 From e35b205bc2d1afe9d8e477a579eb9c84f173a28c Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 27 Nov 2016 21:17:35 -0600 Subject: [PATCH 11/12] Fix numerous unescaped "<" and ">" in Javadoc @author tags The contents of @author go straight into HTML, just like most other Javadoc material. So if you want to have a "" e-mail address as part of the author information, the angle brackets must be escaped. Here I've opted to do that using "{@code }", which has some additional styling effects that seem appropriate for e-mail addresses. We could also have used "<foo@bar.com>" for escaping without code styling. --- com.ibm.wala.core.testdata/src/arraybounds/Detectable.java | 2 +- com.ibm.wala.core.testdata/src/arraybounds/NotDetectable.java | 2 +- com.ibm.wala.core.testdata/src/arraybounds/NotInBound.java | 2 +- .../wala/core/tests/arraybounds/ArrayboundsAnalysisTest.java | 2 +- .../tests/arraybounds/PruneArrayOutOfBoundExceptionEdge.java | 2 +- .../exceptionpruning/ExceptionAnalysis2EdgeFilterTest.java | 2 +- .../wala/core/tests/exceptionpruning/ExceptionAnalysisTest.java | 2 +- .../src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraph.java | 2 +- .../ibm/wala/analysis/arraybounds/ArrayBoundsGraphBuilder.java | 2 +- .../ibm/wala/analysis/arraybounds/ArrayOutOfBoundsAnalysis.java | 2 +- .../com/ibm/wala/analysis/arraybounds/BinaryOpWithConstant.java | 2 +- .../com/ibm/wala/analysis/arraybounds/ConditionNormalizer.java | 2 +- .../wala/analysis/arraybounds/hypergraph/DirectedHyperEdge.java | 2 +- .../analysis/arraybounds/hypergraph/DirectedHyperGraph.java | 2 +- .../com/ibm/wala/analysis/arraybounds/hypergraph/HyperNode.java | 2 +- .../arraybounds/hypergraph/algorithms/ShortestPath.java | 2 +- .../analysis/arraybounds/hypergraph/weight/NormalOrder.java | 2 +- .../analysis/arraybounds/hypergraph/weight/ReverseOrder.java | 2 +- .../ibm/wala/analysis/arraybounds/hypergraph/weight/Weight.java | 2 +- .../hypergraph/weight/edgeweights/AdditiveEdgeWeight.java | 2 +- .../arraybounds/hypergraph/weight/edgeweights/EdgeWeight.java | 2 +- .../exceptionanalysis/CGIntraproceduralExceptionAnalysis.java | 2 +- .../ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis.java | 2 +- .../exceptionanalysis/ExceptionAnalysis2EdgeFilter.java | 2 +- .../nullpointer/IntraproceduralNullPointerAnalysis.java | 2 +- .../ibm/wala/analysis/nullpointer/RelevantVariableFinder.java | 2 +- .../com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter.java | 2 +- .../ipa/cfg/exceptionpruning/ExceptionFilter2EdgeFilter.java | 2 +- .../com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionMatcher.java | 2 +- .../ibm/wala/ipa/cfg/exceptionpruning/FilteredException.java | 2 +- .../ipa/cfg/exceptionpruning/filter/ArrayOutOfBoundFilter.java | 2 +- .../cfg/exceptionpruning/filter/CombinedExceptionFilter.java | 2 +- .../ipa/cfg/exceptionpruning/filter/IgnoreExceptionsFilter.java | 2 +- .../cfg/exceptionpruning/filter/NullPointerExceptionFilter.java | 2 +- .../ibm/wala/ipa/cfg/exceptionpruning/filter/package-info.java | 2 +- .../src/com/ibm/wala/ipa/cfg/exceptionpruning/package-info.java | 2 +- .../src/com/ibm/wala/ssa/AllIntegerDueToBranchePiPolicy.java | 2 +- 37 files changed, 37 insertions(+), 37 deletions(-) diff --git a/com.ibm.wala.core.testdata/src/arraybounds/Detectable.java b/com.ibm.wala.core.testdata/src/arraybounds/Detectable.java index ca97816b5..db72f64b8 100644 --- a/com.ibm.wala.core.testdata/src/arraybounds/Detectable.java +++ b/com.ibm.wala.core.testdata/src/arraybounds/Detectable.java @@ -5,7 +5,7 @@ package arraybounds; * All array accesses in the following class are unnecessary and they will be * detected correctly by the array bounds analysis. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class Detectable { diff --git a/com.ibm.wala.core.testdata/src/arraybounds/NotDetectable.java b/com.ibm.wala.core.testdata/src/arraybounds/NotDetectable.java index 036a0f191..7eadd7fcd 100644 --- a/com.ibm.wala.core.testdata/src/arraybounds/NotDetectable.java +++ b/com.ibm.wala.core.testdata/src/arraybounds/NotDetectable.java @@ -5,7 +5,7 @@ package arraybounds; * All array accesses in the following class are unnecessary but they will not * be detected correctly by the array bounds analysis. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class NotDetectable { diff --git a/com.ibm.wala.core.testdata/src/arraybounds/NotInBound.java b/com.ibm.wala.core.testdata/src/arraybounds/NotInBound.java index 75398a1ce..35cf7b5e0 100644 --- a/com.ibm.wala.core.testdata/src/arraybounds/NotInBound.java +++ b/com.ibm.wala.core.testdata/src/arraybounds/NotInBound.java @@ -5,7 +5,7 @@ package arraybounds; * All array accesses in the following class are necessary and they will be * detected correctly by the array bounds analysis. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class NotInBound { diff --git a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/arraybounds/ArrayboundsAnalysisTest.java b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/arraybounds/ArrayboundsAnalysisTest.java index 4a53bfba6..0ed7fdc66 100644 --- a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/arraybounds/ArrayboundsAnalysisTest.java +++ b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/arraybounds/ArrayboundsAnalysisTest.java @@ -41,7 +41,7 @@ import com.ibm.wala.util.config.AnalysisScopeReader; * * So there is no explicit check for specific lines. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ArrayboundsAnalysisTest { diff --git a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/arraybounds/PruneArrayOutOfBoundExceptionEdge.java b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/arraybounds/PruneArrayOutOfBoundExceptionEdge.java index 270ffa99a..42af62767 100644 --- a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/arraybounds/PruneArrayOutOfBoundExceptionEdge.java +++ b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/arraybounds/PruneArrayOutOfBoundExceptionEdge.java @@ -54,7 +54,7 @@ import com.ibm.wala.util.config.AnalysisScopeReader; * For an example how to use the exception pruning see * {@link PruneArrayOutOfBoundExceptionEdge#computeCfgAndPrunedCFG(IMethod)} * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class PruneArrayOutOfBoundExceptionEdge { diff --git a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/exceptionpruning/ExceptionAnalysis2EdgeFilterTest.java b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/exceptionpruning/ExceptionAnalysis2EdgeFilterTest.java index 1d37b15a2..deb5ea414 100644 --- a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/exceptionpruning/ExceptionAnalysis2EdgeFilterTest.java +++ b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/exceptionpruning/ExceptionAnalysis2EdgeFilterTest.java @@ -50,7 +50,7 @@ import com.ibm.wala.util.ref.ReferenceCleanser; * exceptional instructions should be deleted) and that no new edges are * inserted. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ExceptionAnalysis2EdgeFilterTest { diff --git a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/exceptionpruning/ExceptionAnalysisTest.java b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/exceptionpruning/ExceptionAnalysisTest.java index b168f1d9e..4a6b54809 100644 --- a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/exceptionpruning/ExceptionAnalysisTest.java +++ b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/exceptionpruning/ExceptionAnalysisTest.java @@ -45,7 +45,7 @@ import com.ibm.wala.util.ref.ReferenceCleanser; * interprocedural is right. As well as the number of caught exceptions for each * call site. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ExceptionAnalysisTest { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraph.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraph.java index 7760d0235..44f2e2eb0 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraph.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraph.java @@ -53,7 +53,7 @@ import com.ibm.wala.util.collections.Pair; * "ABCD: eliminating array bounds checks on demand." ACM SIGPLAN Notices. Vol. * 35. No. 5. ACM, 2000. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } */ public class ArrayBoundsGraph extends DirectedHyperGraph { /** diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraphBuilder.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraphBuilder.java index 4bc10efa8..fded0c6ca 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraphBuilder.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayBoundsGraphBuilder.java @@ -27,7 +27,7 @@ import com.ibm.wala.ssa.SSAPiInstruction; /** * @see ArrayBoundsGraph - * @author Stephan Gocht + * @author Stephan Gocht {@code } */ public class ArrayBoundsGraphBuilder { private final IR ir; diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayOutOfBoundsAnalysis.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayOutOfBoundsAnalysis.java index c5cf4b4f3..2729e7b50 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayOutOfBoundsAnalysis.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ArrayOutOfBoundsAnalysis.java @@ -22,7 +22,7 @@ import com.ibm.wala.util.ssa.InstructionByIIndexMap; * "ABCD: eliminating array bounds checks on demand." ACM SIGPLAN Notices. Vol. * 35. No. 5. ACM, 2000. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ArrayOutOfBoundsAnalysis { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/BinaryOpWithConstant.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/BinaryOpWithConstant.java index 390c32c1e..b32664c40 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/BinaryOpWithConstant.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/BinaryOpWithConstant.java @@ -9,7 +9,7 @@ import com.ibm.wala.ssa.SSABinaryOpInstruction; * Normalizes a binary operation with a constant by providing direct access to * assigned = other op constant. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class BinaryOpWithConstant { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ConditionNormalizer.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ConditionNormalizer.java index aa11cc08e..3553531e3 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ConditionNormalizer.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/ConditionNormalizer.java @@ -7,7 +7,7 @@ import com.ibm.wala.ssa.SSAConditionalBranchInstruction; * ConditionNormalizer normalizes a branch condition. See Constructor for more * information. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ConditionNormalizer { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/DirectedHyperEdge.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/DirectedHyperEdge.java index 82add82f5..e0dd2a4f2 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/DirectedHyperEdge.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/DirectedHyperEdge.java @@ -10,7 +10,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.edgeweights.EdgeWeigh /** * A DirectedHyperEdge is an edge of a {@link DirectedHyperGraph}. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * * @param * Type used in HyperNodes (HyperNode) diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/DirectedHyperGraph.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/DirectedHyperGraph.java index a96c0f24e..3b4e9da3c 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/DirectedHyperGraph.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/DirectedHyperGraph.java @@ -13,7 +13,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.Weight; * Implementation of a directed hyper graph. In a hyper graph an edge can have * more than one head and more than one tail. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * * @param */ diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/HyperNode.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/HyperNode.java index 0acb53076..a0c4af9b0 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/HyperNode.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/HyperNode.java @@ -10,7 +10,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.Weight; /** * A HyperNode is a node of a {@link DirectedHyperGraph}. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * * @param */ diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/algorithms/ShortestPath.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/algorithms/ShortestPath.java index 748355ff2..34b3e4c6b 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/algorithms/ShortestPath.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/algorithms/ShortestPath.java @@ -13,7 +13,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.edgeweights.EdgeWeigh /** * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * * @param * NodeValueType diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/NormalOrder.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/NormalOrder.java index 5999860fa..c3655ff85 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/NormalOrder.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/NormalOrder.java @@ -9,7 +9,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.Weight.Type; * Defines a normal Order on Weight: unlimited < ... < -1 < 0 < 1 < ... not_set * is not comparable * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class NormalOrder implements Comparator { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/ReverseOrder.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/ReverseOrder.java index db6ed867e..e2e73297d 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/ReverseOrder.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/ReverseOrder.java @@ -10,7 +10,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.Weight.Type; * Defines a reverse Order on Weight: ... > 1 > 0 > -1 > ... > unlimited not_set * is not comparable * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ReverseOrder implements Comparator { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/Weight.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/Weight.java index d4dea189d..5345b9a5a 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/Weight.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/Weight.java @@ -9,7 +9,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.Weight; * unlimited is given by the chosen order (see {@link NormalOrder} and * {@link ReverseOrder}). * - * @author Stephan Gocht + * @author Stephan Gocht {@code } */ public class Weight { public enum Type { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/edgeweights/AdditiveEdgeWeight.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/edgeweights/AdditiveEdgeWeight.java index b1b7754a9..678f2d7e5 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/edgeweights/AdditiveEdgeWeight.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/edgeweights/AdditiveEdgeWeight.java @@ -7,7 +7,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.edgeweights.EdgeWeigh /** * EdgeWeight that adds a specific value. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class AdditiveEdgeWeight implements EdgeWeight { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/edgeweights/EdgeWeight.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/edgeweights/EdgeWeight.java index 554c5330e..948766b08 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/edgeweights/EdgeWeight.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/weight/edgeweights/EdgeWeight.java @@ -6,7 +6,7 @@ import com.ibm.wala.analysis.arraybounds.hypergraph.weight.Weight; * The weight of an edge can produce a new value for the tail nodes given the * head nodes. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } */ public interface EdgeWeight { public Weight newValue(Weight weight); diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/CGIntraproceduralExceptionAnalysis.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/CGIntraproceduralExceptionAnalysis.java index f6e73724e..a5a69c502 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/CGIntraproceduralExceptionAnalysis.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/CGIntraproceduralExceptionAnalysis.java @@ -27,7 +27,7 @@ import com.ibm.wala.types.TypeReference; /** * Wrapper to store multiple intraprocedural analysis for a call graph. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class CGIntraproceduralExceptionAnalysis { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis.java index 63b6ea6d7..c5d5809cd 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis.java @@ -52,7 +52,7 @@ import com.ibm.wala.util.graph.impl.InvertedGraph; * * Notice: Only exceptions, which are part of the analysis scope are considered. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ExceptionAnalysis { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis2EdgeFilter.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis2EdgeFilter.java index 7ff3204d5..395a662a5 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis2EdgeFilter.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/exceptionanalysis/ExceptionAnalysis2EdgeFilter.java @@ -18,7 +18,7 @@ import com.ibm.wala.ssa.SSAInstruction; /** * Converter to use the results of the exception analysis with an edge filter. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ExceptionAnalysis2EdgeFilter implements EdgeFilter { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/nullpointer/IntraproceduralNullPointerAnalysis.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/nullpointer/IntraproceduralNullPointerAnalysis.java index 282c6fa8b..d9fedb5e4 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/nullpointer/IntraproceduralNullPointerAnalysis.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/nullpointer/IntraproceduralNullPointerAnalysis.java @@ -18,7 +18,7 @@ import com.ibm.wala.util.MonitorUtil.IProgressMonitor; * This class is basically a copy of {@link IntraprocNullPointerAnalysis}, but * does only provide the result of the analysis instead of a pruned CFG. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class IntraproceduralNullPointerAnalysis { diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/nullpointer/RelevantVariableFinder.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/nullpointer/RelevantVariableFinder.java index 50fde1ba7..409de6060 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/nullpointer/RelevantVariableFinder.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/nullpointer/RelevantVariableFinder.java @@ -29,7 +29,7 @@ import com.ibm.wala.ssa.SSAUnaryOpInstruction; /** * Helper class to find the variable that may be null. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class RelevantVariableFinder implements IVisitor { diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter.java index 4a666f32a..6531f2e19 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter.java @@ -7,7 +7,7 @@ import java.util.Collection; * combination with {@link ExceptionFilter2EdgeFilter}. For more Details see * package-info. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * * @param */ diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter2EdgeFilter.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter2EdgeFilter.java index e0cf04845..1b980a614 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter2EdgeFilter.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionFilter2EdgeFilter.java @@ -14,7 +14,7 @@ import com.ibm.wala.types.TypeReference; /** * This class converts an exception filter to an edge filter. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * * @param */ diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionMatcher.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionMatcher.java index bd9e64cd7..daffc1a56 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionMatcher.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/ExceptionMatcher.java @@ -12,7 +12,7 @@ import com.ibm.wala.types.TypeReference; * Helper class to check if an exception is part of a set of filtered * exceptions. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ExceptionMatcher { diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/FilteredException.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/FilteredException.java index 8531f26b6..396017768 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/FilteredException.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/FilteredException.java @@ -6,7 +6,7 @@ import com.ibm.wala.types.TypeReference; * FilteredException represents either a single exception or an exception and * all its subclasses. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class FilteredException { diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/ArrayOutOfBoundFilter.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/ArrayOutOfBoundFilter.java index 88d28acc6..806fe63bc 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/ArrayOutOfBoundFilter.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/ArrayOutOfBoundFilter.java @@ -15,7 +15,7 @@ import com.ibm.wala.types.TypeReference; * Adapter for using {@link ArrayOutOfBoundsAnalysis}. This filter is filtering * ArrayOutOfBoundException, which can not occur. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class ArrayOutOfBoundFilter implements ExceptionFilter { diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/CombinedExceptionFilter.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/CombinedExceptionFilter.java index 7b9db7667..ea24a8ee4 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/CombinedExceptionFilter.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/CombinedExceptionFilter.java @@ -9,7 +9,7 @@ import com.ibm.wala.ipa.cfg.exceptionpruning.FilteredException; /** * Use this class to combine multiple {@link ExceptionFilter} * - * @author Stephan Gocht + * @author Stephan Gocht {@code } */ public class CombinedExceptionFilter implements ExceptionFilter { private final Collection> exceptionFilter; diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/IgnoreExceptionsFilter.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/IgnoreExceptionsFilter.java index 4e86d3101..b675eb519 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/IgnoreExceptionsFilter.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/IgnoreExceptionsFilter.java @@ -11,7 +11,7 @@ import com.ibm.wala.types.TypeReference; /** * For filtering specific exceptions. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class IgnoreExceptionsFilter implements ExceptionFilter { diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/NullPointerExceptionFilter.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/NullPointerExceptionFilter.java index 05435a9af..7585732ec 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/NullPointerExceptionFilter.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/NullPointerExceptionFilter.java @@ -16,7 +16,7 @@ import com.ibm.wala.types.TypeReference; * Adapter for {@link IntraproceduralNullPointerAnalysis}. This filter is filtering * NullPointerException, which can not occur. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ public class NullPointerExceptionFilter implements diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/package-info.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/package-info.java index 46482c44f..ca2456180 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/package-info.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/filter/package-info.java @@ -1,7 +1,7 @@ /** * All available filters should be contained in this package. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ package com.ibm.wala.ipa.cfg.exceptionpruning.filter; \ No newline at end of file diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/package-info.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/package-info.java index 0bac24f5c..5e778355c 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/package-info.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/cfg/exceptionpruning/package-info.java @@ -9,7 +9,7 @@ * This package contains classes for this job and also adapter for some * analysis. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } * */ package com.ibm.wala.ipa.cfg.exceptionpruning; \ No newline at end of file diff --git a/com.ibm.wala.core/src/com/ibm/wala/ssa/AllIntegerDueToBranchePiPolicy.java b/com.ibm.wala.core/src/com/ibm/wala/ssa/AllIntegerDueToBranchePiPolicy.java index 1aa636d23..e9006fd01 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ssa/AllIntegerDueToBranchePiPolicy.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ssa/AllIntegerDueToBranchePiPolicy.java @@ -20,7 +20,7 @@ import com.ibm.wala.util.collections.Pair; * A policy, that adds pi nodes for all variables, that are used in a branch * instruction. * - * @author Stephan Gocht + * @author Stephan Gocht {@code } */ public class AllIntegerDueToBranchePiPolicy implements SSAPiNodePolicy { From ed0ddd780f47959379f93b94b944a30cad8e4534 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sun, 27 Nov 2016 17:18:16 -0600 Subject: [PATCH 12/12] Correct HTML embedded in Javadoc comments Most of the invalid HTML arose from bare "<" and ">" characters. These should be escaped as "<" and ">" when not intended to introduce HTML tags. When you have many such characters close together, "{@literal ...}" is a nice, readable alternative that automatically escapes its contents. If the text in question is intended to be a code fragment, then "{@code ...}" is appropriate: this is essentially equivalent to "{@literal ...}". There were a few other HTML violations too, but none common enough to be worth detailing here. --- .../src/arraybounds/Detectable.java | 4 ++-- .../hypergraph/algorithms/ShortestPath.java | 4 ++-- .../wala/cfg/cdg/ControlDependenceGraph.java | 2 +- .../com/ibm/wala/classLoader/CodeScanner.java | 2 +- .../ibm/wala/classLoader/JavaLanguage.java | 2 +- .../ibm/wala/classLoader/ShrikeBTMethod.java | 4 ++-- .../ibm/wala/dataflow/IFDS/CallFlowEdges.java | 4 ++-- .../IFDS/IBinaryReturnFlowFunction.java | 2 +- .../wala/dataflow/IFDS/IFlowFunctionMap.java | 12 ++++++------ .../IFDS/IPartiallyBalancedFlowFunctions.java | 2 +- .../wala/dataflow/IFDS/LocalPathEdges.java | 12 ++++++------ .../wala/dataflow/IFDS/LocalSummaryEdges.java | 4 ++-- .../wala/dataflow/IFDS/TabulationResult.java | 2 +- .../wala/dataflow/IFDS/TabulationSolver.java | 19 ++++++++++--------- .../demandpa/flowgraph/AbstractFlowGraph.java | 7 ++++--- .../wala/demandpa/util/MemoryAccessMap.java | 4 ++-- .../propagation/AbstractPointerAnalysis.java | 2 +- .../propagation/PointerAnalysis.java | 2 +- .../callgraph/propagation/PointsToMap.java | 2 +- .../propagation/PropagationSystem.java | 2 +- .../propagation/cfa/ZeroXInstanceKeys.java | 2 +- .../ibm/wala/ipa/summaries/SyntheticIR.java | 2 +- .../ipa/summaries/XMLMethodSummaryReader.java | 2 +- .../src/com/ibm/wala/util/strings/Atom.java | 2 +- .../ibm/wala/shrikeCT/AnnotationsReader.java | 2 +- .../graph/ITransferFunctionProvider.java | 4 ++-- .../wala/fixpoint/IFixedPointStatement.java | 8 ++++---- .../ibm/wala/fixpoint/IFixedPointSystem.java | 8 ++++---- .../com/ibm/wala/util/collections/Heap.java | 2 +- .../wala/util/collections/ImmutableStack.java | 2 +- .../ibm/wala/util/collections/MapUtil.java | 10 +++++----- .../util/collections/ParanoidHashSet.java | 2 +- .../src/com/ibm/wala/util/graph/Path.java | 4 ++-- .../graph/impl/SlowNumberedNodeManager.java | 2 +- .../graph/impl/SparseNumberedEdgeManager.java | 2 +- .../traverse/SlowDFSDiscoverTimeIterator.java | 2 +- .../ibm/wala/util/heapTrace/HeapTracer.java | 4 ++-- .../util/intset/BasicNaturalRelation.java | 2 +- .../ibm/wala/util/intset/BitVectorBase.java | 2 +- .../ibm/wala/util/intset/BitVectorIntSet.java | 2 +- .../util/intset/IBinaryNaturalRelation.java | 2 +- .../ibm/wala/util/intset/OffsetBitVector.java | 2 +- .../ibm/wala/util/intset/SparseIntSet.java | 2 +- .../ibm/wala/util/intset/SparseLongSet.java | 2 +- .../src/com/ibm/wala/util/math/Factorial.java | 2 +- .../src/com/ibm/wala/util/math/Logs.java | 4 ++-- 46 files changed, 88 insertions(+), 86 deletions(-) diff --git a/com.ibm.wala.core.testdata/src/arraybounds/Detectable.java b/com.ibm.wala.core.testdata/src/arraybounds/Detectable.java index db72f64b8..c80aad4d9 100644 --- a/com.ibm.wala.core.testdata/src/arraybounds/Detectable.java +++ b/com.ibm.wala.core.testdata/src/arraybounds/Detectable.java @@ -77,7 +77,7 @@ public class Detectable { } /** - * swaps elements of a and b for all i: 0 <= i < min(a.length, b.length) + * swaps elements of a and b for all i: 0 <= i < min(a.length, b.length) * * @param a * @param b @@ -100,7 +100,7 @@ public class Detectable { } /** - * Invert the order of all elements of arr with index i: fromIndex <= i < + * Invert the order of all elements of arr with index i: fromIndex <= i < * toIndex. * * @param arr diff --git a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/algorithms/ShortestPath.java b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/algorithms/ShortestPath.java index 34b3e4c6b..5ed3b2247 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/algorithms/ShortestPath.java +++ b/com.ibm.wala.core/src/com/ibm/wala/analysis/arraybounds/hypergraph/algorithms/ShortestPath.java @@ -81,7 +81,7 @@ public class ShortestPath { /** * @param weight * @param otherWeight - * @return weight > otherWeight + * @return weight > otherWeight */ private boolean greaterThen(Weight weight, Weight otherWeight) { return otherWeight.getType() == Type.NOT_SET || this.comparator.compare(weight, otherWeight) > 0; @@ -90,7 +90,7 @@ public class ShortestPath { /** * @param weight * @param otherWeight - * @return weight < otherWeight + * @return weight < otherWeight */ private boolean lessThen(Weight weight, Weight otherWeight) { return otherWeight.getType() == Type.NOT_SET || this.comparator.compare(weight, otherWeight) < 0; diff --git a/com.ibm.wala.core/src/com/ibm/wala/cfg/cdg/ControlDependenceGraph.java b/com.ibm.wala.core/src/com/ibm/wala/cfg/cdg/ControlDependenceGraph.java index 93bbe2a9a..5284d83ee 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/cfg/cdg/ControlDependenceGraph.java +++ b/com.ibm.wala.core/src/com/ibm/wala/cfg/cdg/ControlDependenceGraph.java @@ -55,7 +55,7 @@ public class ControlDependenceGraph extends AbstractNumberedGraph { * This is the heart of the CDG computation. Based on Cytron et al., this is the reverse dominance frontier based algorithm for * computing control dependence edges. * - * @return Map: node n -> {x : n is control-dependent on x} + * @return Map: node n -> {x : n is control-dependent on x} */ private Map> buildControlDependence(boolean wantEdgeLabels) { Map> controlDependence = HashMapFactory.make(cfg.getNumberOfNodes()); diff --git a/com.ibm.wala.core/src/com/ibm/wala/classLoader/CodeScanner.java b/com.ibm.wala.core/src/com/ibm/wala/classLoader/CodeScanner.java index 7150469da..ddfc8a32a 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/classLoader/CodeScanner.java +++ b/com.ibm.wala.core/src/com/ibm/wala/classLoader/CodeScanner.java @@ -242,7 +242,7 @@ public class CodeScanner { } /** - * @return Set + * @return {@link Set}<{@link TypeReference}> * @throws IllegalArgumentException if statements == null */ public static Set getCaughtExceptions(final Language l, SSAInstruction[] statements) throws IllegalArgumentException { diff --git a/com.ibm.wala.core/src/com/ibm/wala/classLoader/JavaLanguage.java b/com.ibm.wala.core/src/com/ibm/wala/classLoader/JavaLanguage.java index 048ee878a..407b9d3ef 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/classLoader/JavaLanguage.java +++ b/com.ibm.wala.core/src/com/ibm/wala/classLoader/JavaLanguage.java @@ -541,7 +541,7 @@ public class JavaLanguage extends LanguageImpl implements BytecodeLanguage, Cons } /** - * @return Collection, set of exception types a call to a declared target might throw. + * @return {@link Collection}<{@link TypeReference}>, set of exception types a call to a declared target might throw. * @throws InvalidClassFileException * @throws IllegalArgumentException if target is null * @throws IllegalArgumentException if cha is null diff --git a/com.ibm.wala.core/src/com/ibm/wala/classLoader/ShrikeBTMethod.java b/com.ibm.wala.core/src/com/ibm/wala/classLoader/ShrikeBTMethod.java index a63edbb9e..5abc589b7 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/classLoader/ShrikeBTMethod.java +++ b/com.ibm.wala.core/src/com/ibm/wala/classLoader/ShrikeBTMethod.java @@ -192,7 +192,7 @@ public abstract class ShrikeBTMethod implements IMethod, BytecodeConstants { } /** - * @return Set , the exceptions that statements in this method may throw, + * @return {@link Set}<{@link TypeReference}>, the exceptions that statements in this method may throw, * @throws InvalidClassFileException */ public Collection getImplicitExceptionTypes() throws InvalidClassFileException { @@ -804,7 +804,7 @@ public abstract class ShrikeBTMethod implements IMethod, BytecodeConstants { } /** - * @return Set + * @return {@link Set}<{@link TypeReference}> * @throws InvalidClassFileException */ public Set getCaughtExceptionTypes() throws InvalidClassFileException { diff --git a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/CallFlowEdges.java b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/CallFlowEdges.java index accc93ce0..9a3de66b0 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/CallFlowEdges.java +++ b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/CallFlowEdges.java @@ -78,7 +78,7 @@ public class CallFlowEdges { /** * @param c * @param d2 - * @return set of d1 s.t. -> was recorded as call flow, or null if none found. + * @return set of d1 s.t. {@literal -> } was recorded as call flow, or null if none found. */ public IntSet getCallFlowSources(int c, int d2) { if (c < 0) { @@ -119,7 +119,7 @@ public class CallFlowEdges { /** * * @param d2 - * @return set of c s.t. -> was recorded as call flow (for some d1), or null if none found. + * @return set of c s.t. {@literal -> } was recorded as call flow (for some d1), or null if none found. */ public IntSet getCallFlowSourceNodes(int d2) { IntSet s = identityEdges.get(d2); diff --git a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IBinaryReturnFlowFunction.java b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IBinaryReturnFlowFunction.java index b270cc12a..899264da2 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IBinaryReturnFlowFunction.java +++ b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IBinaryReturnFlowFunction.java @@ -25,7 +25,7 @@ public interface IBinaryReturnFlowFunction extends IFlowFunction { /** * @param call_d factoid of the caller at the call site * @param exit_d factoid of the callee at the exit site - * @return set of ret_d such that (, ret_d) is an edge in this distributive function's graph representation, or + * @return set of ret_d such that ({@literal }, ret_d) is an edge in this distributive function's graph representation, or * null if there are none */ public SparseIntSet getTargets(int call_d, int exit_d); diff --git a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IFlowFunctionMap.java b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IFlowFunctionMap.java index 6871f223a..e1daa3d6d 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IFlowFunctionMap.java +++ b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IFlowFunctionMap.java @@ -20,7 +20,7 @@ public interface IFlowFunctionMap { /** * @param src * @param dest - * @return the flow function for a "normal" edge in the supergraph from src->dest + * @return the flow function for a "normal" edge in the supergraph from src -> dest */ public IUnaryFlowFunction getNormalFlowFunction(T src, T dest); @@ -29,7 +29,7 @@ public interface IFlowFunctionMap { * @param dest the entry of the callee * @param ret the block that will be returned to, in the caller. This can be null .. signifying that facts can flow * into the callee but not return - * @return the flow function for a "call" edge in the supergraph from src->dest + * @return the flow function for a "call" edge in the supergraph from src -> dest */ public IUnaryFlowFunction getCallFlowFunction(T src, T dest, T ret); @@ -37,22 +37,22 @@ public interface IFlowFunctionMap { * @param call supergraph node of the call instruction for this return edge. * @param src * @param dest - * @return the flow function for a "return" edge in the supergraph from src->dest + * @return the flow function for a "return" edge in the supergraph from src -> dest */ public IFlowFunction getReturnFlowFunction(T call, T src, T dest); /** * @param src * @param dest - * @return the flow function for a "call-to-return" edge in the supergraph from src->dest + * @return the flow function for a "call-to-return" edge in the supergraph from src -> dest */ public IUnaryFlowFunction getCallToReturnFlowFunction(T src, T dest); /** * @param src * @param dest - * @return the flow function for a "call-to-return" edge in the supergraph from src->dest, when the supergraph does - * not contain any callees of src. This happens via, e.g., slicing. + * @return the flow function for a "call-to-return" edge in the supergraph from src -> dest, + * when the supergraph does not contain any callees of src. This happens via, e.g., slicing. */ public IUnaryFlowFunction getCallNoneToReturnFlowFunction(T src, T dest); } diff --git a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IPartiallyBalancedFlowFunctions.java b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IPartiallyBalancedFlowFunctions.java index ac9c0c37a..2e5b8e9fe 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IPartiallyBalancedFlowFunctions.java +++ b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/IPartiallyBalancedFlowFunctions.java @@ -21,7 +21,7 @@ public interface IPartiallyBalancedFlowFunctions extends IFlowFunctionMap * * @param src * @param dest - * @return the flow function for a "return" edge in the supergraph from src->dest + * @return the flow function for a "return" edge in the supergraph from src -< dest */ public IFlowFunction getUnbalancedReturnFlowFunction(T src, T dest); diff --git a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/LocalPathEdges.java b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/LocalPathEdges.java index 8dd4c39a0..d58e6ccfb 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/LocalPathEdges.java +++ b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/LocalPathEdges.java @@ -199,7 +199,7 @@ public class LocalPathEdges { * * @param n local block number of a basic block n * @param d2 - * @return the sparse int set of d1 s.t. -> are recorded as path edges. null if none found + * @return the sparse int set of d1 s.t. {@literal -> } are recorded as path edges. null if none found */ public IntSet getInverse(int n, int d2) { IBinaryNaturalRelation R = paths.get(d2); @@ -276,7 +276,7 @@ public class LocalPathEdges { * @param i * @param n local block number of a basic block n * @param j - * @return true iff we have a path edge -> + * @return true iff we have a path edge {@literal -> } */ public boolean contains(int i, int n, int j) { @@ -311,7 +311,7 @@ public class LocalPathEdges { /** * * @param n - * @return set of d2 s.t. d1->d2 is a path edge for node n. + * @return set of d2 s.t. d1 -> d2 is a path edge for node n. */ public IntSet getReachable(int n, int d1) { if (PARANOID) { @@ -323,7 +323,7 @@ public class LocalPathEdges { /** * Note that this is really slow!!! * - * @return set of d2 s.t. d1->d2 is a path edge for node n + * @return set of d2 s.t. d1 -> d2 is a path edge for node n */ private IntSet getReachableSlow(int n, int d1) { MutableSparseIntSet result = MutableSparseIntSet.makeEmpty(); @@ -363,7 +363,7 @@ public class LocalPathEdges { } /** - * @return set of d2 s.t. d1->d2 is a path edge for node n + * @return set of d2 s.t. d1 -> d2 is a path edge for node n */ private IntSet getReachableFast(int n, int d1) { @@ -378,7 +378,7 @@ public class LocalPathEdges { * TODO: optimize this based on altPaths * * @param n the local block number of a node - * @return set of d2 s.t \exists d1 s.t. d1->d2 is a path edge for node n + * @return set of d2 s.t \exists d1 s.t. d1 -> d2 is a path edge for node n */ public IntSet getReachable(int n) { MutableSparseIntSet result = MutableSparseIntSet.makeEmpty(); diff --git a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/LocalSummaryEdges.java b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/LocalSummaryEdges.java index d0a560b00..500332bf5 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/LocalSummaryEdges.java +++ b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/LocalSummaryEdges.java @@ -106,7 +106,7 @@ public class LocalSummaryEdges { * @param s_p local block number an entry * @param x local block number of an exit block * @param d1 source dataflow fact - * @return set of d2 s.t. d1->d2 recorded as a summary edge for (s_p,x), or null if none + * @return set of d2 s.t. d1 -> d2 recorded as a summary edge for (s_p,x), or null if none */ public IntSet getSummaryEdges(int s_p, int x, int d1) { int n = getIndexForEntryExitPair(s_p, x); @@ -124,7 +124,7 @@ public class LocalSummaryEdges { * @param s_p local block number an entry * @param x local block number of an exit block * @param d2 target dataflow fact - * @return set of d1 s.t. d1->d2 recorded as a summary edge for (s_p,x), or null if none + * @return set of d1 s.t. d1 -> d2 recorded as a summary edge for (s_p,x), or null if none */ public IntSet getInvertedSummaryEdgesForTarget(int s_p, int x, int d2) { int n = getIndexForEntryExitPair(s_p, x); diff --git a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationResult.java b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationResult.java index 1b2454f57..2c162d214 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationResult.java +++ b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationResult.java @@ -45,7 +45,7 @@ public interface TabulationResult { * @param n1 * @param d1 * @param n2 - * @return set of d2 s.t. (n1,d1) -> (n2,d2) is recorded as a summary edge, or null if none found + * @return set of d2 s.t. (n1,d1) -> (n2,d2) is recorded as a summary edge, or null if none found */ public IntSet getSummaryTargets(T n1, int d1, T n2); diff --git a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationSolver.java b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationSolver.java index 014d5a7bd..058294090 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationSolver.java +++ b/com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationSolver.java @@ -392,12 +392,12 @@ public class TabulationSolver { /** * Propagate information for an "exit" edge to the appropriate return sites * - * [23] for each d5 s.t. -> .. + * [23] for each d5 s.t. {@literal -> } .. * * @param edge the edge being processed * @param succ numbers of the nodes that are successors of edge.n (the return block in the callee) in the call graph. * @param c a call site of edge.s_p - * @param D4 set of d1 s.t. -> was recorded as call flow + * @param D4 set of d1 s.t. {@literal -> } was recorded as call flow */ private void propagateToReturnSites(final PathEdge edge, final T c, final IntSet D4) { P proc = supergraph.getProcOf(c); @@ -447,11 +447,11 @@ public class TabulationSolver { /** * Propagate information for an "exit" edge to a caller return site * - * [23] for each d5 s.t. -> .. + * [23] for each d5 s.t. {@literal -> } .. * * @param edge the edge being processed * @param c a call site of edge.s_p - * @param D4 set of d1 s.t. -> was recorded as call flow + * @param D4 set of d1 s.t. {@literal -> } was recorded as call flow * @param entries the blocks in the supergraph that are entries for the procedure of c * @param retSite the return site being propagated to * @param retf the flow function @@ -474,8 +474,9 @@ public class TabulationSolver { * @param c the corresponding call site * @param entries entry nodes in the caller * @param retSite the return site - * @param d4 a fact s.t. -> was recorded as call flow and is the source of the summary edge - * being applied + * @param d4 a fact s.t. {@literal -> } was + * recorded as call flow and {@literal } is the + * source of the summary edge being applied * @param D5 facts to propagate to return site * @param edge the path edge ending at the exit site of the callee */ @@ -522,7 +523,7 @@ public class TabulationSolver { * @param s_p * @param n * @param d2 note that s_p must be an entry for procof(n) - * @return set of d1 s.t. -> is a path edge, or null if none found + * @return set of d1 s.t. {@literal -> } is a path edge, or null if none found */ protected IntSet getInversePathEdges(T s_p, T n, int d2) { int number = supergraph.getLocalBlockNumber(n); @@ -1000,7 +1001,7 @@ public class TabulationSolver { * @param n1 * @param d1 * @param n2 - * @return set of d2 s.t. (n1,d1) -> (n2,d2) is recorded as a summary edge, or null if none found + * @return set of d2 s.t. (n1,d1) -> (n2,d2) is recorded as a summary edge, or null if none found */ @Override public IntSet getSummaryTargets(T n1, int d1, T n2) { @@ -1040,7 +1041,7 @@ public class TabulationSolver { } /** - * @return set of d1 s.t. (n1,d1) -> (n2,d2) is recorded as a summary edge, or null if none found + * @return set of d1 s.t. (n1,d1) -> (n2,d2) is recorded as a summary edge, or null if none found * @throws UnsupportedOperationException unconditionally */ public IntSet getSummarySources(T n2, int d2, T n1) throws UnsupportedOperationException { diff --git a/com.ibm.wala.core/src/com/ibm/wala/demandpa/flowgraph/AbstractFlowGraph.java b/com.ibm.wala.core/src/com/ibm/wala/demandpa/flowgraph/AbstractFlowGraph.java index 7cb7ebf6c..45ff136cf 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/demandpa/flowgraph/AbstractFlowGraph.java +++ b/com.ibm.wala.core/src/com/ibm/wala/demandpa/flowgraph/AbstractFlowGraph.java @@ -118,8 +118,9 @@ public abstract class AbstractFlowGraph extends SlowSparseNumberedLabeledGraph callDefs = HashMapFactory.make(); /** - * Map: {@link LocalPointerKey} -> Set<{@link SSAInvokeInstruction}>. If we have (x, foo()), that means x was passed as a - * parameter to the call to foo(). The parameter position is not represented and must be recovered. + * Map: {@link LocalPointerKey} -> {@link Set}<{@link SSAInvokeInstruction}>. + * If we have (x, foo()), that means x was passed as a parameter to the call to foo(). + * The parameter position is not represented and must be recovered. */ protected final Map> callParams = HashMapFactory.make(); @@ -130,7 +131,7 @@ public abstract class AbstractFlowGraph extends SlowSparseNumberedLabeledGraph params = HashMapFactory.make(); /** - * Map: {@link LocalPointerKey} -> {@link CGNode}. If we have (x, foo), then x is a return value of method foo. Must re-discover + * Map: {@link LocalPointerKey} -> {@link CGNode}. If we have (x, foo), then x is a return value of method foo. Must re-discover * if x is normal or exceptional return value. */ protected final Map returns = HashMapFactory.make(); diff --git a/com.ibm.wala.core/src/com/ibm/wala/demandpa/util/MemoryAccessMap.java b/com.ibm.wala.core/src/com/ibm/wala/demandpa/util/MemoryAccessMap.java index 0de1f043e..ef7769e90 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/demandpa/util/MemoryAccessMap.java +++ b/com.ibm.wala.core/src/com/ibm/wala/demandpa/util/MemoryAccessMap.java @@ -19,12 +19,12 @@ import com.ibm.wala.ipa.callgraph.propagation.PointerKey; public interface MemoryAccessMap { /** - * @return Collection + * @return {@link Collection}<{@link FieldAccess}> */ public Collection getFieldReads(PointerKey baseRef, IField field); /** - * @return Collection + * @return {@link Collection}<{@link FieldAccess}> */ public Collection getFieldWrites(PointerKey baseRef, IField field); diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/AbstractPointerAnalysis.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/AbstractPointerAnalysis.java index 6fe746620..c9f022e7b 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/AbstractPointerAnalysis.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/AbstractPointerAnalysis.java @@ -34,7 +34,7 @@ public abstract class AbstractPointerAnalysis implements PointerAnalysisInteger + * bijection from InstanceKey <=> Integer */ protected final MutableMapping instanceKeys; diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PointerAnalysis.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PointerAnalysis.java index 3414a4d09..673a703f2 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PointerAnalysis.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PointerAnalysis.java @@ -40,7 +40,7 @@ public interface PointerAnalysis { HeapGraph getHeapGraph(); /** - * @return the bijection between InstanceKey <=> Integer that defines the + * @return the bijection between InstanceKey <=> Integer that defines the * interpretation of points-to-sets. */ OrdinalSetMapping getInstanceKeyMapping(); diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PointsToMap.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PointsToMap.java index 43dacb586..dc1999b5e 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PointsToMap.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PointsToMap.java @@ -198,7 +198,7 @@ public class PointsToMap { } /** - * @return Iterator + * @return {@link Iterator}<{@link PointerKey}> */ public Iterator getTransitiveRoots() { return new FilterIterator(iterateKeys(), new Predicate() { diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PropagationSystem.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PropagationSystem.java index b2c75f57f..84a8779cb 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PropagationSystem.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/PropagationSystem.java @@ -77,7 +77,7 @@ public class PropagationSystem extends DefaultFixedPointSolverInteger + * bijection from InstanceKey <=> Integer */ protected final MutableMapping instanceKeys = MutableMapping.make(); diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/cfa/ZeroXInstanceKeys.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/cfa/ZeroXInstanceKeys.java index 24b41b205..d42a53e08 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/cfa/ZeroXInstanceKeys.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/propagation/cfa/ZeroXInstanceKeys.java @@ -228,7 +228,7 @@ public class ZeroXInstanceKeys implements InstanceKeyFactory { } /** - * @return Map: IClass -> Integer, the number of allocation sites for each type. + * @return Map: IClass -> Integer, the number of allocation sites for each type. */ private Map countAllocsByType(CGNode node) { Map count = HashMapFactory.make(); diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/SyntheticIR.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/SyntheticIR.java index eedd9f105..91cf20401 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/SyntheticIR.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/SyntheticIR.java @@ -70,7 +70,7 @@ public class SyntheticIR extends IR { /** * Set up the symbol table according to statements in the IR * - * @param constants Map: value number (Integer) -> ConstantValue + * @param constants Map: value number (Integer) -> ConstantValue */ private static SymbolTable makeSymbolTable(IMethod method, SSAInstruction[] instructions, Map constants, AbstractCFG cfg) { diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/XMLMethodSummaryReader.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/XMLMethodSummaryReader.java index afac25f8c..496524569 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/XMLMethodSummaryReader.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/XMLMethodSummaryReader.java @@ -212,7 +212,7 @@ public class XMLMethodSummaryReader implements BytecodeConstants { } /** - * @return Method summaries collected for methods. Mapping Object -> MethodSummary where Object is either a + * @return Method summaries collected for methods. Mapping Object -> MethodSummary where Object is either a *
    *
  • MethodReference *
  • TypeReference diff --git a/com.ibm.wala.core/src/com/ibm/wala/util/strings/Atom.java b/com.ibm.wala.core/src/com/ibm/wala/util/strings/Atom.java index 2805fe421..118ff672c 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/util/strings/Atom.java +++ b/com.ibm.wala.core/src/com/ibm/wala/util/strings/Atom.java @@ -85,7 +85,7 @@ public final class Atom implements Serializable { /** * create an Atom from utf8[off] of length len * - * @throws IllegalArgumentException if utf8.length <= off + * @throws IllegalArgumentException if utf8.length <= off */ public static Atom findOrCreate(byte utf8[], int off, int len) throws IllegalArgumentException, IllegalArgumentException, IllegalArgumentException { diff --git a/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/AnnotationsReader.java b/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/AnnotationsReader.java index d941a47fe..b9f17071a 100644 --- a/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/AnnotationsReader.java +++ b/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/AnnotationsReader.java @@ -45,7 +45,7 @@ public class AnnotationsReader extends AttributeReader { } /** - * @return total length of this attribute in bytes, including the + * @return total length of this attribute in bytes, including the * first 6 bytes * @throws InvalidClassFileException */ diff --git a/com.ibm.wala.util/src/com/ibm/wala/dataflow/graph/ITransferFunctionProvider.java b/com.ibm.wala.util/src/com/ibm/wala/dataflow/graph/ITransferFunctionProvider.java index 49afbd04d..6b5391de3 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/dataflow/graph/ITransferFunctionProvider.java +++ b/com.ibm.wala.util/src/com/ibm/wala/dataflow/graph/ITransferFunctionProvider.java @@ -25,7 +25,7 @@ import com.ibm.wala.fixpoint.UnaryOperator; public interface ITransferFunctionProvider { /** - * @return the transfer function from IN_node -> OUT_node + * @return the transfer function from IN_node -> OUT_node */ public UnaryOperator getNodeTransferFunction(T node); @@ -35,7 +35,7 @@ public interface ITransferFunctionProvider { public boolean hasNodeTransferFunctions(); /** - * @return the transfer function from OUT_src -> EDGE_ + * @return the transfer function from OUT_src -> EDGE_<src,dst> */ public UnaryOperator getEdgeTransferFunction(T src, T dst); diff --git a/com.ibm.wala.util/src/com/ibm/wala/fixpoint/IFixedPointStatement.java b/com.ibm.wala.util/src/com/ibm/wala/fixpoint/IFixedPointStatement.java index b874eb448..4efb11877 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/fixpoint/IFixedPointStatement.java +++ b/com.ibm.wala.util/src/com/ibm/wala/fixpoint/IFixedPointStatement.java @@ -44,10 +44,10 @@ public interface IFixedPointStatement extends INodeWithNumb * Evaluate this statement, setting a new value for the left-hand side. The * return value is one of the following: *
      - * {@link FixedPointConstants#CHANGED}, - * {@link FixedPointConstants#CHANGED_AND_FIXED}, - * {@link FixedPointConstants#NOT_CHANGED}or - * {@link FixedPointConstants#NOT_CHANGED_AND_FIXED}. + *
    • {@link FixedPointConstants#CHANGED},
      • + *
    • {@link FixedPointConstants#CHANGED_AND_FIXED},
      • + *
    • {@link FixedPointConstants#NOT_CHANGED}, or
      • + *
    • {@link FixedPointConstants#NOT_CHANGED_AND_FIXED}.
      • *
    */ abstract byte evaluate(); diff --git a/com.ibm.wala.util/src/com/ibm/wala/fixpoint/IFixedPointSystem.java b/com.ibm.wala.util/src/com/ibm/wala/fixpoint/IFixedPointSystem.java index 8d008cb89..a893e4032 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/fixpoint/IFixedPointSystem.java +++ b/com.ibm.wala.util/src/com/ibm/wala/fixpoint/IFixedPointSystem.java @@ -31,14 +31,14 @@ public interface IFixedPointSystem { /** * Return an Iterator of the {@link IFixedPointStatement}s in this system * - * @return Iterator + * @return {@link Iterator}<Constraint> */ public Iterator getStatements(); /** * Return an Iterator of the variables in this graph * - * @return Iterator + * @return {@link Iterator}<{@link IVariable}> */ public Iterator getVariables(); @@ -53,12 +53,12 @@ public interface IFixedPointSystem { boolean containsVariable(T v); /** - * @return Iterator , the statements that use the variable + * @return {@link Iterator}<statement>, the statements that use the variable */ Iterator getStatementsThatUse(T v); /** - * @return Iterator , the statements that def the variable + * @return {@link Iterator}<statement>, the statements that def the variable */ Iterator getStatementsThatDef(T v); diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/collections/Heap.java b/com.ibm.wala.util/src/com/ibm/wala/util/collections/Heap.java index e86c6dfc2..ec3874bb6 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/collections/Heap.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/collections/Heap.java @@ -18,7 +18,7 @@ import java.util.NoSuchElementException; public abstract class Heap { /** - * @return true iff elt1 is considered < elt2 + * @return true iff elt1 is considered < elt2 */ abstract protected boolean compareElements(T elt1, T elt2); diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/collections/ImmutableStack.java b/com.ibm.wala.util/src/com/ibm/wala/util/collections/ImmutableStack.java index f2a89ab22..3a8e37595 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/collections/ImmutableStack.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/collections/ImmutableStack.java @@ -184,7 +184,7 @@ public class ImmutableStack implements Iterable { } /** - * @return true iff other.size() = k, k <= this.size(), and the + * @return true iff {@code other.size() = k}, {@code k <= this.size()}, and the * top k elements of this equal other * @throws IllegalArgumentException * if other == null diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/collections/MapUtil.java b/com.ibm.wala.util/src/com/ibm/wala/util/collections/MapUtil.java index d12ad2103..5b32de001 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/collections/MapUtil.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/collections/MapUtil.java @@ -26,7 +26,7 @@ import com.ibm.wala.util.intset.MutableSparseIntSet; */ public class MapUtil { /** - * @param M a mapping from Object -> Set + * @param M a mapping from Object -> Set * @param key * @return the Set corresponding to key in M; create one if needed * @throws IllegalArgumentException if M is null @@ -97,7 +97,7 @@ public class MapUtil { } /** - * @param M a mapping from Object -> Map + * @param M a mapping from Object -> Map * @param key * @return the Map corresponding to key in M; create one if needed * @throws IllegalArgumentException if M is null @@ -133,7 +133,7 @@ public class MapUtil { } /** - * @param M a mapping from Object -> WeakHashMap + * @param M a mapping from Object -> WeakHashMap * @param key * @return the WeakHashMap corresponding to key in M; create one if needed * @throws IllegalArgumentException if M is null @@ -153,8 +153,8 @@ public class MapUtil { } /** - * @param m a map from key -> Set - * @return inverted map, value -> Set + * @param m a map from key -> {@link Set}<value> + * @return inverted map, value -> {@link Set}<key> * @throws IllegalArgumentException if m is null */ public static Map> inverseMap(Map> m) { diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/collections/ParanoidHashSet.java b/com.ibm.wala.util/src/com/ibm/wala/util/collections/ParanoidHashSet.java index 7f54ea800..dae615b72 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/collections/ParanoidHashSet.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/collections/ParanoidHashSet.java @@ -27,7 +27,7 @@ public class ParanoidHashSet extends LinkedHashSet { public static final long serialVersionUID = 30919839181133333L; /** - * A mapping from Integer (hashcode) -> Set of objects + * A mapping from Integer (hashcode) -> Set of objects */ private final Map> hcFreq; diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/graph/Path.java b/com.ibm.wala.util/src/com/ibm/wala/util/graph/Path.java index f5f60f68d..3b4f6cf57 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/graph/Path.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/graph/Path.java @@ -13,8 +13,8 @@ package com.ibm.wala.util.graph; import com.ibm.wala.util.intset.SimpleIntVector; /** - * We represent a path in a numbered graph as a vector of integers where node i_1 is the src and node i_n is the sink + * We represent a path in a numbered graph as a vector of integers <i_1, ..., + * i_n> where node i_1 is the src and node i_n is the sink */ public class Path extends SimpleIntVector { diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/graph/impl/SlowNumberedNodeManager.java b/com.ibm.wala.util/src/com/ibm/wala/util/graph/impl/SlowNumberedNodeManager.java index fc216bb99..ff28816a5 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/graph/impl/SlowNumberedNodeManager.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/graph/impl/SlowNumberedNodeManager.java @@ -23,7 +23,7 @@ import com.ibm.wala.util.intset.MutableMapping; public class SlowNumberedNodeManager implements NumberedNodeManager, Serializable { /** - * A bijection between integer <-> node + * A bijection between integer <-> node */ final private MutableMapping map = MutableMapping.make(); diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/graph/impl/SparseNumberedEdgeManager.java b/com.ibm.wala.util/src/com/ibm/wala/util/graph/impl/SparseNumberedEdgeManager.java index 300be6432..7d92f6f75 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/graph/impl/SparseNumberedEdgeManager.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/graph/impl/SparseNumberedEdgeManager.java @@ -51,7 +51,7 @@ public final class SparseNumberedEdgeManager implements NumberedEdgeManager nodeManager, int normalCase, byte delegateImpl) throws IllegalArgumentException { if (nodeManager == null) { diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/graph/traverse/SlowDFSDiscoverTimeIterator.java b/com.ibm.wala.util/src/com/ibm/wala/util/graph/traverse/SlowDFSDiscoverTimeIterator.java index b51906856..d816f3e14 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/graph/traverse/SlowDFSDiscoverTimeIterator.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/graph/traverse/SlowDFSDiscoverTimeIterator.java @@ -26,7 +26,7 @@ public class SlowDFSDiscoverTimeIterator extends GraphDFSDiscoverTimeIterator public static final long serialVersionUID = 9439217987188L; /** - * An iterator of child nodes for each node being searched A Map: Node -> Iterator + * An iterator of child nodes for each node being searched A Map: Node -> Iterator */ final private Map> pendingChildren = HashMapFactory.make(25); diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/heapTrace/HeapTracer.java b/com.ibm.wala.util/src/com/ibm/wala/util/heapTrace/HeapTracer.java index ee2c2d24e..df250a48a 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/heapTrace/HeapTracer.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/heapTrace/HeapTracer.java @@ -172,7 +172,7 @@ public class HeapTracer { /** * @param fdir - * @return Collection representing the class names in a particular + * @return {@link Collection}<{@link String}> representing the class names in a particular * file */ /** @@ -180,7 +180,7 @@ public class HeapTracer { * root of the classpath governing file f * @param f * a File or directory - * @return Collection representing the class names in f + * @return {@link Collection}<{@link String}> representing the class names in f */ private static Collection findClassNames(String rootDir, File f) { HashSet result = HashSetFactory.make(); diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/intset/BasicNaturalRelation.java b/com.ibm.wala.util/src/com/ibm/wala/util/intset/BasicNaturalRelation.java index 3759ce64e..f48a4352b 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/intset/BasicNaturalRelation.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/intset/BasicNaturalRelation.java @@ -46,7 +46,7 @@ public final class BasicNaturalRelation implements IBinaryNaturalRelation, Seria /** * smallStore[i][x] holds *
      - *
    • if >=0, the ith integer associated with x + *
    • if >=0, the ith integer associated with x *
    • if -2, then use the delegateStore instead of the small store *
    • if -1, then R(x) is empty *
    diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVectorBase.java b/com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVectorBase.java index d65e832c7..3ab192b56 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVectorBase.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVectorBase.java @@ -176,7 +176,7 @@ abstract public class BitVectorBase implements Cloneabl } /** - * @return min j >= start s.t get(j) + * @return min j >= start s.t get(j) */ public int nextSetBit(int start) { if (start < 0) { diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVectorIntSet.java b/com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVectorIntSet.java index c257cf63c..a0996521e 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVectorIntSet.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVectorIntSet.java @@ -344,7 +344,7 @@ public final class BitVectorIntSet implements MutableIntSet { } /** - * @return min j >= n s.t get(j) + * @return min j >= n s.t get(j) */ public int nextSetBit(int n) { return bitVector.nextSetBit(n); diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/intset/IBinaryNaturalRelation.java b/com.ibm.wala.util/src/com/ibm/wala/util/intset/IBinaryNaturalRelation.java index 40eb667a2..9367306d1 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/intset/IBinaryNaturalRelation.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/intset/IBinaryNaturalRelation.java @@ -13,7 +13,7 @@ package com.ibm.wala.util.intset; import com.ibm.wala.util.debug.VerboseAction; /** - * a relation R(x,y) where x >= 0 + * a relation R(x,y) where x >= 0 */ public interface IBinaryNaturalRelation extends VerboseAction, Iterable { /** diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/intset/OffsetBitVector.java b/com.ibm.wala.util/src/com/ibm/wala/util/intset/OffsetBitVector.java index c7d97442d..f72341c51 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/intset/OffsetBitVector.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/intset/OffsetBitVector.java @@ -172,7 +172,7 @@ public final class OffsetBitVector extends BitVectorBase { /** * @param start - * @return min j >= start s.t get(j) + * @return min j >= start s.t get(j) */ @Override public int nextSetBit(int start) { diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseIntSet.java b/com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseIntSet.java index 420bd1118..d53d44a94 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseIntSet.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseIntSet.java @@ -302,7 +302,7 @@ public class SparseIntSet implements IntSet, Serializable { } /** - * Reverse of toString(): "{2,3}" -> [2,3] + * Reverse of toString(): "{2,3}" -> [2,3] * @throws IllegalArgumentException if str is null */ public static int[] parseIntArray(String str) { diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseLongSet.java b/com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseLongSet.java index 59b78f75a..0b6c7a37c 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseLongSet.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseLongSet.java @@ -298,7 +298,7 @@ public class SparseLongSet implements LongSet { } /** - * Reverse of toString(): "{2,3}" -> [2,3] + * Reverse of toString(): "{2,3}" -> [2,3] * * @throws IllegalArgumentException if str is null */ diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/math/Factorial.java b/com.ibm.wala.util/src/com/ibm/wala/util/math/Factorial.java index 040951b06..9c3246a1d 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/math/Factorial.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/math/Factorial.java @@ -68,7 +68,7 @@ public class Factorial { * Factorial on doubles; avoids overflow problems present when using integers. * * @param n arg on which to compute factorial - * @return (double approximation to) factorial of largest positive integer <= (n_ + epsilon) + * @return (double approximation to) factorial of largest positive integer <= (n_ + epsilon) */ public static double fact(double n) { n += 1e-6; diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/math/Logs.java b/com.ibm.wala.util/src/com/ibm/wala/util/math/Logs.java index d27e12238..51ca7eadf 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/math/Logs.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/math/Logs.java @@ -77,7 +77,7 @@ public class Logs { return -1; } - /** Binary log: finds the smallest power k such that 2^k>=n */ + /** Binary log: finds the smallest power k such that 2^k >= n */ public static int binaryLogUp(int n) { int k = 0; while ((1 << k) < n) { @@ -86,7 +86,7 @@ public class Logs { return k; } - /** Binary log: finds the smallest power k such that 2^k>=n */ + /** Binary log: finds the smallest power k such that 2^k >= n */ public static int binaryLogUp(long n) { int k = 0; while ((1 << k) < n) {