DASCA/WALA
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove some unnecessary warning suppressions

Browse Source 
One such annotation was unnecessary because the thing it was
suppressing no longer happens.  Any future unnecessary warning
suppressions of this kind will now be treated as errors.

The other annotations were unnecessary because the corresponding
warnings have been disabled entirely in the Eclipse projects'
configurations.  There seems to be no way to tell Eclipse to treat
these as anything other than "info" diagnostics in the future, so
that's how they will remain.
This commit is contained in:
Ben Liblit 2017-08-02 18:26:42 -05:00 committed by Manu Sridharan
parent ef94d85d2b
commit 321b28f149
8 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs
View File

@ -103,6 +103,6 @@ org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=di
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=error
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=error
org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=error
org.eclipse.jdt.core.compiler.source=1.7

2
com.ibm.wala.cast.js/.settings/org.eclipse.jdt.core.prefs
View File

@ -117,7 +117,7 @@ org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=di
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=error
org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=error
org.eclipse.jdt.core.compiler.source=1.7
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false

1
com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/loader/JavaScriptLoader.java
View File

@ -1010,7 +1010,6 @@ public class JavaScriptLoader extends CAstAbstractModuleLoader {
bootstrapFileNames.add(prologueFileName);
}
@SuppressWarnings("unchecked")
@Override
protected TranslatorToCAst getTranslatorToCAst(final CAst ast, ModuleEntry module) {
TranslatorToCAst translator = translatorFactory.make(ast, module);

2
com.ibm.wala.cast/.settings/org.eclipse.jdt.core.prefs
View File

@ -118,7 +118,7 @@ org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=di
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=error
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=error
org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=error
org.eclipse.jdt.core.compiler.source=1.7
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false

1
com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/collections/TwoLevelVectorTest.java
View File

@ -37,7 +37,6 @@ public final class TwoLevelVectorTest extends WalaTestCase {
// --- Test cases
@SuppressWarnings("static-method")
@Test public void testCase1() {
final TwoLevelVector<Integer> tlVector = new TwoLevelVector<>();
tlVector.iterator();

1
com.ibm.wala.core/src/com/ibm/wala/cfg/exc/intra/NullPointerState.java
View File

@ -261,7 +261,6 @@ public class NullPointerState extends AbstractVariable<NullPointerState> {
/* (non-Javadoc)
* @see com.ibm.wala.fixedpoint.impl.AbstractOperator#evaluate(com.ibm.wala.fixpoint.IVariable, com.ibm.wala.fixpoint.IVariable[])
*/
@SuppressWarnings("rawtypes")
@Override
public byte evaluate(NullPointerState lhs, NullPointerState[] rhs) {
boolean changed = false;

1
com.ibm.wala.core/src/com/ibm/wala/dataflow/IFDS/TabulationSolver.java
View File

@ -949,7 +949,6 @@ public class TabulationSolver<T, P, F> {
TreeMap<Object, TreeSet<T>> map = new TreeMap<Object, TreeSet<T>>(ToStringComparator.instance());
Comparator<Object> c = new Comparator<Object>() {
@SuppressWarnings("rawtypes")
@Override
public int compare(Object o1, Object o2) {
if (!(o1 instanceof IBasicBlock)) {

3
com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/TypeAnnotationsReader.java
View File

@ -122,7 +122,6 @@ public class TypeAnnotationsReader extends AnnotationsReader {
* </pre>
* @see <a href="https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.20"> JLS (SE8), 4.7.20</a>
*/
@SuppressWarnings("javadoc")
public TypeAnnotationAttribute[] getAllTypeAnnotations() throws InvalidClassFileException {
TypeAnnotationAttribute[] result = new TypeAnnotationAttribute[getAnnotationCount()];
int offset = beginOffset + 8; // skip attribute_name_index,
@ -167,7 +166,6 @@ public class TypeAnnotationsReader extends AnnotationsReader {
* </pre>
*
*/
@SuppressWarnings("javadoc")
private Pair<TypeAnnotationAttribute, Integer> getTypeAttributeAndSize(int begin) throws InvalidClassFileException {
TargetType target_type = TargetType.fromValue(cr.getUnsignedByte(begin));
@ -411,7 +409,6 @@ public class TypeAnnotationsReader extends AnnotationsReader {
* </pre>
* @author Martin Hecker martin.hecker@kit.edu
*/
@SuppressWarnings("javadoc")
public static abstract class TypeAnnotationTarget {
private final TargetInfo targetInfo;
protected TypeAnnotationTarget(TargetInfo targetInfo) {