From 323224504a672396c3f50b1d9deb8d195494efaf Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Wed, 22 Mar 2017 18:26:05 -0500 Subject: [PATCH] Suppress several unfixable warnings about unresolved type references Fixing these Javadoc comments would require adding packages to various other packages' build paths. In some of the cases suppressed, changing build paths in that manner would create circular build dependencies. In other cases, it would simply add a Javadoc-motivated dependency that does not exist for the real code, which seems undesirable. For a few cases, the reference seems to be to types in code we don't even have here, such as code from "android" or "org.mozilla" packages. --- com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java | 3 +++ .../js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java | 1 + .../com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java | 1 + .../src/reflection/GetMethodContext.java | 1 + .../com/ibm/wala/ipa/summaries/VolatileMethodSummary.java | 1 + .../ipa/callgraph/androidModel/stubs/AndroidBoot.java | 6 ++++-- .../src/com/ibm/wala/util/CancelException.java | 1 + 7 files changed, 12 insertions(+), 2 deletions(-) diff --git a/com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java b/com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java index f80645d4b..ddf287fee 100644 --- a/com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java +++ b/com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java @@ -49,6 +49,7 @@ final class IntWrapper extends PrimitiveWrapper { * @see com.ibm.miniatur.tests.sequential.PrimitiveWrapper#intValue() */ + @SuppressWarnings("javadoc") public int intValue() { return val; } @@ -58,6 +59,7 @@ final class IntWrapper extends PrimitiveWrapper { * @see com.ibm.miniatur.tests.sequential.PrimitiveWrapper#setIntValue(int) */ + @SuppressWarnings("javadoc") public void setIntValue(int i) { this.val = i; } @@ -67,6 +69,7 @@ final class IntWrapper extends PrimitiveWrapper { * @see com.ibm.miniatur.tests.sequential.PrimitiveWrapper#equals(java.lang.Object) */ + @SuppressWarnings("javadoc") public boolean equals(Object o) { return o instanceof IntWrapper && ((IntWrapper)o).val==val; } diff --git a/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java b/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java index 9bb4335c2..bad5db036 100755 --- a/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java +++ b/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java @@ -108,6 +108,7 @@ import com.ibm.wala.util.strings.Atom; * reference to a global named {@link #GLOBAL_OBJ_VAR_NAME}, which is handled * specially in {@link JSConstraintVisitor#visitAstGlobalRead(AstGlobalRead)}. */ +@SuppressWarnings("javadoc") public class JSSSAPropagationCallGraphBuilder extends AstSSAPropagationCallGraphBuilder { public static final boolean DEBUG_LEXICAL = false; diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java index 83fc9c1ea..d96b467ef 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java @@ -25,6 +25,7 @@ import com.ibm.wala.util.collections.Pair; * * @see JSSSAPropagationCallGraphBuilder */ +@SuppressWarnings("javadoc") public class GlobalObjectKey implements InstanceKey { private final IClass concreteType; diff --git a/com.ibm.wala.core.testdata/src/reflection/GetMethodContext.java b/com.ibm.wala.core.testdata/src/reflection/GetMethodContext.java index bf6a37d09..a8712494d 100644 --- a/com.ibm.wala.core.testdata/src/reflection/GetMethodContext.java +++ b/com.ibm.wala.core.testdata/src/reflection/GetMethodContext.java @@ -18,6 +18,7 @@ import java.lang.reflect.Method; * A test targeting the {@link com.ibm.wala.analysis.reflection.GetMethodContext}. * @author Michael Heilmann */ +@SuppressWarnings("javadoc") public class GetMethodContext { public static class A { diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/VolatileMethodSummary.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/VolatileMethodSummary.java index c44efb37b..334d1df38 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/VolatileMethodSummary.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/VolatileMethodSummary.java @@ -82,6 +82,7 @@ import com.ibm.wala.util.strings.Atom; * @author Tobias Blaschke * @since 2013-09-08 */ +@SuppressWarnings("javadoc") public class VolatileMethodSummary { private static final boolean DEBUG = false; diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/stubs/AndroidBoot.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/stubs/AndroidBoot.java index 7c5d74c0d..f94e7b5be 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/stubs/AndroidBoot.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/stubs/AndroidBoot.java @@ -179,7 +179,8 @@ public class AndroidBoot { * * @see android.app.ContextImpl.createPackageContextAsUser */ - private SSAValue createSystemContext(SSAValue mainThread) { + @SuppressWarnings("javadoc") + private SSAValue createSystemContext(SSAValue mainThread) { final SSAValue systemContext = this.pm.getUnmanaged(AndroidTypes.ContextImpl, "systemContextImpl"); { // Call ContextImpl.getSystemContext() final int pc = this.body.getNextProgramCounter(); @@ -211,7 +212,8 @@ public class AndroidBoot { * * @see android.app.ContextImpl.createPackageContextAsUser */ - private SSAValue createPackageContext(final SSAValue mainThread, final SSAValue systemContext) { + @SuppressWarnings("javadoc") + private SSAValue createPackageContext(final SSAValue mainThread, final SSAValue systemContext) { final SSAValue packageContext = this.pm.getUnmanaged(AndroidTypes.ContextImpl, "packageContextImpl"); { // New-Site final int pc = this.body.getNextProgramCounter(); diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/CancelException.java b/com.ibm.wala.util/src/com/ibm/wala/util/CancelException.java index 935c9bbc0..b6275eed2 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/CancelException.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/CancelException.java @@ -14,6 +14,7 @@ package com.ibm.wala.util; * An exception for when work is canceled in eclipse. This version forces every API that uses it to declare it. Use * {@link CancelRuntimeException} to avoid the need to declare a cancel exception. */ +@SuppressWarnings("javadoc") public class CancelException extends Exception { protected CancelException(String msg) {