DASCA
/
WALA
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

avoid use of clone() in performance-sensitive method 

git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2797 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
This commit is contained in:
sjfink 2008-05-12 00:27:31 +00:00
parent deb84db770
commit 4931b4b80b
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
com.ibm.wala.core/src/com/ibm/wala/util/intset/MutableSparseIntSet.java
View File

@ -13,13 +13,12 @@ package com.ibm.wala.util.intset;
import com.ibm.wala.util.debug.Assertions;
/**
* A sparse ordered, mutable duplicate-free, fully-encapsulated set of integers.
* Instances are not canonical, except for EMPTY.
* A sparse ordered, mutable duplicate-free, fully-encapsulated set of integers. Instances are not canonical, except for
* EMPTY.
*
* This implementation will be inefficient if these sets get large.
*
* TODO: even for small sets, we probably want to work on this to reduce the
* allocation activity.
* TODO: even for small sets, we probably want to work on this to reduce the allocation activity.
*
* @author Alan Donovan
* @author Stephen Fink
@ -168,7 +167,7 @@ public class MutableSparseIntSet extends SparseIntSet implements MutableIntSet {
}
/**
* @throws IllegalArgumentException if that == null
* @throws IllegalArgumentException if that == null
*/
public void copySet(IntSet that) throws IllegalArgumentException {
if (that == null) {
@ -177,7 +176,12 @@ public class MutableSparseIntSet extends SparseIntSet implements MutableIntSet {
if (that instanceof SparseIntSet) {
SparseIntSet set = (SparseIntSet) that;
if (set.elements != null) {
elements = set.elements.clone();
// SJF: clone is performance problem. don't use it.
// elements = set.elements.clone();
elements = new int[set.elements.length];
for (int i = 0; i < set.size; i++) {
elements[i] = set.elements[i];
}
size = set.size;
} else {
elements = null;
@ -292,7 +296,7 @@ public class MutableSparseIntSet extends SparseIntSet implements MutableIntSet {
* Add all elements from another int set.
*
* @return true iff this set changes
* @throws IllegalArgumentException if set == null
* @throws IllegalArgumentException if set == null
*/
public boolean addAll(IntSet set) throws IllegalArgumentException {
if (set == null) {
@ -438,7 +442,7 @@ public class MutableSparseIntSet extends SparseIntSet implements MutableIntSet {
* TODO optimize
*
* @param set
* @throws IllegalArgumentException if set is null
* @throws IllegalArgumentException if set is null
*/
public void removeAll(MutableSparseIntSet set) {
if (set == null) {
@ -483,9 +487,7 @@ public class MutableSparseIntSet extends SparseIntSet implements MutableIntSet {
}
}
public static MutableSparseIntSet
diff(MutableSparseIntSet A, MutableSparseIntSet B)
{
public static MutableSparseIntSet diff(MutableSparseIntSet A, MutableSparseIntSet B) {
return new MutableSparseIntSet(diffInternal(A, B));
}
@ -497,5 +499,4 @@ public class MutableSparseIntSet extends SparseIntSet implements MutableIntSet {
return new MutableSparseIntSet();
}
}