From 64dfd2d908ab4450237e1f0e96a4ed5102e61358 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Sat, 25 Mar 2017 16:37:09 -0500 Subject: [PATCH] Turn off Eclipse warnings about unnecessary `else` clauses If the true block of an `if` statement is guaranteed to exit early, such as by a `return` or `throw`, then any code appearing in a corresponding `else` clause could just as well have appeared after the `if` statement entirely. Eclipse can warn about this. However, Manu prefers to let such code stay in the `else` clauses. OK, sure: this is more a matter of personal taste than something truly problematic. Per Manu's request, then, we're turning off that Eclipse warning in the subprojects in which it currently arises. --- com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs | 1 + com.ibm.wala.dalvik/.settings/org.eclipse.jdt.core.prefs | 1 + com.ibm.wala.scandroid/.settings/org.eclipse.jdt.core.prefs | 1 + 3 files changed, 3 insertions(+) diff --git a/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs b/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs index c944afd21..f5d09b551 100644 --- a/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs +++ b/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs @@ -5,4 +5,5 @@ org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.7 org.eclipse.jdt.core.compiler.compliance=1.7 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error org.eclipse.jdt.core.compiler.problem.enumIdentifier=error +org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore org.eclipse.jdt.core.compiler.source=1.7 diff --git a/com.ibm.wala.dalvik/.settings/org.eclipse.jdt.core.prefs b/com.ibm.wala.dalvik/.settings/org.eclipse.jdt.core.prefs index 78bba305a..f349dbc71 100644 --- a/com.ibm.wala.dalvik/.settings/org.eclipse.jdt.core.prefs +++ b/com.ibm.wala.dalvik/.settings/org.eclipse.jdt.core.prefs @@ -20,6 +20,7 @@ org.eclipse.jdt.core.compiler.maxProblemPerUnit=100 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error org.eclipse.jdt.core.compiler.problem.enumIdentifier=error org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore +org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore org.eclipse.jdt.core.compiler.source=1.7 org.eclipse.jdt.core.incompatibleJDKLevel=ignore org.eclipse.jdt.core.incompleteClasspath=error diff --git a/com.ibm.wala.scandroid/.settings/org.eclipse.jdt.core.prefs b/com.ibm.wala.scandroid/.settings/org.eclipse.jdt.core.prefs index 19abf0b1d..2adb13a36 100644 --- a/com.ibm.wala.scandroid/.settings/org.eclipse.jdt.core.prefs +++ b/com.ibm.wala.scandroid/.settings/org.eclipse.jdt.core.prefs @@ -6,4 +6,5 @@ org.eclipse.jdt.core.compiler.compliance=1.7 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error org.eclipse.jdt.core.compiler.problem.enumIdentifier=error org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore +org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore org.eclipse.jdt.core.compiler.source=1.7