From 91b9c9e28b805e071d1e29bdfd61bf41f92067a5 Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Tue, 28 Mar 2017 18:57:24 -0500 Subject: [PATCH] Suppress/disable some Eclipse unnecessary-code warnings in test code Often the easiest way to create a desired test scenario is to write code that would make no sense in a complete, realistic application. So we generally want to let test code do oddball things. --- .../.settings/org.eclipse.jdt.core.prefs | 2 +- com.ibm.wala.cast.java.test.data/src/CastFromNull.java | 1 + .../src/foo/bar/hello/world/LoopsAndLabels.java | 1 + .../src/foo/bar/hello/world/Misc.java | 1 + .../src/annotations/TypeAnnotatedClass2.java | 1 + 5 files changed, 5 insertions(+), 1 deletion(-) diff --git a/com.ibm.wala.cast.java.test.data/.settings/org.eclipse.jdt.core.prefs b/com.ibm.wala.cast.java.test.data/.settings/org.eclipse.jdt.core.prefs index 2d837975c..dea7933b9 100644 --- a/com.ibm.wala.cast.java.test.data/.settings/org.eclipse.jdt.core.prefs +++ b/com.ibm.wala.cast.java.test.data/.settings/org.eclipse.jdt.core.prefs @@ -104,7 +104,7 @@ org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled -org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning +org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=ignore org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning org.eclipse.jdt.core.compiler.source=1.7 diff --git a/com.ibm.wala.cast.java.test.data/src/CastFromNull.java b/com.ibm.wala.cast.java.test.data/src/CastFromNull.java index 56ca30685..9d46e2951 100644 --- a/com.ibm.wala.cast.java.test.data/src/CastFromNull.java +++ b/com.ibm.wala.cast.java.test.data/src/CastFromNull.java @@ -9,6 +9,7 @@ * IBM Corporation - initial API and implementation *****************************************************************************/ public class CastFromNull { + @SuppressWarnings({ "cast", "unused" }) public static void main(String args[]) { new CastFromNull(); Object x = (Object) null; diff --git a/com.ibm.wala.cast.java.test.data/src/foo/bar/hello/world/LoopsAndLabels.java b/com.ibm.wala.cast.java.test.data/src/foo/bar/hello/world/LoopsAndLabels.java index 0c1c13038..ad2043317 100644 --- a/com.ibm.wala.cast.java.test.data/src/foo/bar/hello/world/LoopsAndLabels.java +++ b/com.ibm.wala.cast.java.test.data/src/foo/bar/hello/world/LoopsAndLabels.java @@ -38,6 +38,7 @@ package foo.bar.hello.world; public class LoopsAndLabels { + @SuppressWarnings({ "cast", "unused" }) public static void main(String args[]) { aaa: do { diff --git a/com.ibm.wala.cast.java.test.data/src/foo/bar/hello/world/Misc.java b/com.ibm.wala.cast.java.test.data/src/foo/bar/hello/world/Misc.java index 3bce77f3a..6ab8dce79 100644 --- a/com.ibm.wala.cast.java.test.data/src/foo/bar/hello/world/Misc.java +++ b/com.ibm.wala.cast.java.test.data/src/foo/bar/hello/world/Misc.java @@ -39,6 +39,7 @@ package foo.bar.hello.world; public class Misc { + @SuppressWarnings({ "cast", "unused" }) public static void main(String args[]) { if ( "hello" instanceof Object ) { System.out.println("strings are objects in java"); diff --git a/com.ibm.wala.core.testdata/src/annotations/TypeAnnotatedClass2.java b/com.ibm.wala.core.testdata/src/annotations/TypeAnnotatedClass2.java index df869ec70..b67a26cb8 100644 --- a/com.ibm.wala.core.testdata/src/annotations/TypeAnnotatedClass2.java +++ b/com.ibm.wala.core.testdata/src/annotations/TypeAnnotatedClass2.java @@ -86,6 +86,7 @@ class Outer { } class Outer2 { + @SuppressWarnings("unused") class Middle { class Inner { }