From 966bc5b3e38f9c3ac3baa265f2fa1eb76a9de7aa Mon Sep 17 00:00:00 2001
From: Ben Liblit <liblit@cs.wisc.edu>
Date: Fri, 12 May 2017 15:14:14 +0200
Subject: [PATCH] Remove AnalysisCache.getIR() calls whose results are unused

I'm grouping these together in a single commit in case these calls are
actually wanted for side effects.
---
 .../cfg/exc/inter/NullPointerExceptionInterTest.java  | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/cfg/exc/inter/NullPointerExceptionInterTest.java b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/cfg/exc/inter/NullPointerExceptionInterTest.java
index 221282284..317961702 100644
--- a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/cfg/exc/inter/NullPointerExceptionInterTest.java
+++ b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/cfg/exc/inter/NullPointerExceptionInterTest.java
@@ -37,7 +37,6 @@ import com.ibm.wala.ipa.callgraph.impl.Util;
 import com.ibm.wala.ipa.cha.ClassHierarchy;
 import com.ibm.wala.ipa.cha.ClassHierarchyException;
 import com.ibm.wala.ipa.cha.ClassHierarchyFactory;
-import com.ibm.wala.ssa.IR;
 import com.ibm.wala.ssa.SSAInstruction;
 import com.ibm.wala.ssa.analysis.IExplodedBasicBlock;
 import com.ibm.wala.types.MethodReference;
@@ -99,7 +98,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
   public void testIfException() throws UnsoundGraphException, CancelException, WalaException {
     MethodReference mr = StringStuff.makeMethodReference("cfg.exc.inter.CallFieldAccess.callIfException()Lcfg/exc/intra/B");
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -118,7 +116,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
     Assert.assertEquals(1, cg.getNodes(mr).size());
     final CGNode callNode = cg.getNodes(mr).iterator().next();
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -133,7 +130,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
   public void testIfNoException() throws UnsoundGraphException, CancelException, WalaException {
     MethodReference mr = StringStuff.makeMethodReference("cfg.exc.inter.CallFieldAccess.callIfNoException()Lcfg/exc/intra/B");
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -148,7 +144,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
   public void testDynamicIfNoException() throws UnsoundGraphException, CancelException, WalaException {
     MethodReference mr = StringStuff.makeMethodReference("cfg.exc.inter.CallFieldAccess.callDynamicIfNoException()Lcfg/exc/intra/B");
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -163,7 +158,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
   public void testIf2Exception() throws UnsoundGraphException, CancelException, WalaException {
     MethodReference mr = StringStuff.makeMethodReference("cfg.exc.inter.CallFieldAccess.callIf2Exception()Lcfg/exc/intra/B");
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -182,7 +176,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
     Assert.assertEquals(1, cg.getNodes(mr).size());
     final CGNode callNode = cg.getNodes(mr).iterator().next();
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -197,7 +190,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
   public void testIf2NoException() throws UnsoundGraphException, CancelException, WalaException {
     MethodReference mr = StringStuff.makeMethodReference("cfg.exc.inter.CallFieldAccess.callIf2NoException()Lcfg/exc/intra/B");
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -212,7 +204,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
   public void testDynamicIf2NoException() throws UnsoundGraphException, CancelException, WalaException {
     MethodReference mr = StringStuff.makeMethodReference("cfg.exc.inter.CallFieldAccess.callDynamicIf2NoException()Lcfg/exc/intra/B");
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -228,7 +219,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
   public void testGetException() throws UnsoundGraphException, CancelException, WalaException {
     MethodReference mr = StringStuff.makeMethodReference("cfg.exc.inter.CallFieldAccess.callGetException()Lcfg/exc/intra/B");
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());
 
@@ -247,7 +237,6 @@ public class NullPointerExceptionInterTest extends WalaTestCase {
     Assert.assertEquals(1, cg.getNodes(mr).size());
     final CGNode callNode = cg.getNodes(mr).iterator().next();
 
-    IR ir = cache.getIR(m);
     InterprocAnalysisResult<SSAInstruction, IExplodedBasicBlock> interExplodedCFG = 
         NullPointerAnalysis.computeInterprocAnalysis(cg, new NullProgressMonitor());