diff --git a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java index 6028b132c..ae4299e23 100644 --- a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java +++ b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java @@ -1681,9 +1681,6 @@ public abstract class JDTJava2CAstTranslator { * where field 'y' is parameterized to type string. then += is not defined for type 'object'. This function is a hack that expands * the code into an assignment and binary operation. * - * @param leftCast this is the left cast in the original expression. We throw most of it away, although we use the "Cast from" and - * "cast to" - * @param left * @param context * @return */ @@ -1837,7 +1834,6 @@ public abstract class JDTJava2CAstTranslator { * owningTypeRef or the subtype that the field is accessed thru, for expanding "f = 5" into "TheClass.this.f = 5". * * @param typeOfThis - * @param owningTypeRef * @param isPrivate * @return */ @@ -1899,10 +1895,9 @@ public abstract class JDTJava2CAstTranslator { * exception. maybe handle this in here as a special case? i don't know... or check if targetNode is THIS, that should even work * for this.x = 5 and (this).x = 5 * - * @param target Used to evaluate the field access. In the case of static field accesses, this is included in the first part of a + * @param targetNode Used to evaluate the field access. In the case of static field accesses, this is included in the first part of a * block -- thus it is evaluated for any side effects but thrown away. * @param fieldName Name of the field. - * @param fieldBinding This is used to determine the field's class. * @param positioningNode Used only for making a JdtPosition. * @param context * @return @@ -2839,7 +2834,6 @@ public abstract class JDTJava2CAstTranslator { /** * Giant switch statement, part deux * - * @param body * @param context * @return */ diff --git a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTTypeDictionary.java b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTTypeDictionary.java index b6052e671..b5a27c1f8 100644 --- a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTTypeDictionary.java +++ b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTTypeDictionary.java @@ -62,7 +62,6 @@ public class JDTTypeDictionary extends CAstTypeDictionaryImpl { /** * * @param ast Needed to get root type "java.lang.Object" - * @param translator */ public JDTTypeDictionary(AST ast, JDTIdentityMapper identityMapper) { fAst = ast; diff --git a/com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java b/com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java index f80645d4b..ddf287fee 100644 --- a/com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java +++ b/com.ibm.wala.cast.java.test.data/src/MiniaturSliceBug.java @@ -49,6 +49,7 @@ final class IntWrapper extends PrimitiveWrapper { * @see com.ibm.miniatur.tests.sequential.PrimitiveWrapper#intValue() */ + @SuppressWarnings("javadoc") public int intValue() { return val; } @@ -58,6 +59,7 @@ final class IntWrapper extends PrimitiveWrapper { * @see com.ibm.miniatur.tests.sequential.PrimitiveWrapper#setIntValue(int) */ + @SuppressWarnings("javadoc") public void setIntValue(int i) { this.val = i; } @@ -67,6 +69,7 @@ final class IntWrapper extends PrimitiveWrapper { * @see com.ibm.miniatur.tests.sequential.PrimitiveWrapper#equals(java.lang.Object) */ + @SuppressWarnings("javadoc") public boolean equals(Object o) { return o instanceof IntWrapper && ((IntWrapper)o).val==val; } diff --git a/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java b/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java index 9bb4335c2..bad5db036 100755 --- a/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java +++ b/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSSSAPropagationCallGraphBuilder.java @@ -108,6 +108,7 @@ import com.ibm.wala.util.strings.Atom; * reference to a global named {@link #GLOBAL_OBJ_VAR_NAME}, which is handled * specially in {@link JSConstraintVisitor#visitAstGlobalRead(AstGlobalRead)}. */ +@SuppressWarnings("javadoc") public class JSSSAPropagationCallGraphBuilder extends AstSSAPropagationCallGraphBuilder { public static final boolean DEBUG_LEXICAL = false; diff --git a/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ssa/JavaScriptPropertyRead.java b/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ssa/JavaScriptPropertyRead.java index e95a1288f..c518eb3c2 100644 --- a/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ssa/JavaScriptPropertyRead.java +++ b/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ssa/JavaScriptPropertyRead.java @@ -49,7 +49,7 @@ public class JavaScriptPropertyRead extends AbstractReflectiveGet { /** /* (non-Javadoc) - * @see com.ibm.domo.ssa.SSAInstruction#visit(com.ibm.domo.ssa.SSAInstruction.Visitor) + * @see com.ibm.wala.ssa.SSAInstruction#visit(com.ibm.wala.ssa.SSAInstruction.IVisitor) */ @Override public void visit(IVisitor v) { diff --git a/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ssa/JavaScriptPropertyWrite.java b/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ssa/JavaScriptPropertyWrite.java index 8b0e1d4b6..892c7ef47 100644 --- a/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ssa/JavaScriptPropertyWrite.java +++ b/com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ssa/JavaScriptPropertyWrite.java @@ -36,7 +36,7 @@ public class JavaScriptPropertyWrite extends AbstractReflectivePut { } /** - * @see com.ibm.domo.ssa.Instruction#visit(Visitor) + * @see com.ibm.wala.ssa.SSAInstruction#visit(IVisitor) */ @Override public void visit(IVisitor v) { diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/AstSSAPropagationCallGraphBuilder.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/AstSSAPropagationCallGraphBuilder.java index 9b8b96cbc..9d6bc8888 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/AstSSAPropagationCallGraphBuilder.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/AstSSAPropagationCallGraphBuilder.java @@ -615,7 +615,7 @@ public abstract class AstSSAPropagationCallGraphBuilder extends SSAPropagationCa * perform the necessary {@link #action(PointerKey, int)}s for the * accesses. For each access, we determine the possible {@link CGNode}s * corresponding to its definer (see - * {@link AstConstraintVisitor#getLexicalDefiners(CGNode, String)). Handle + * {@link AstConstraintVisitor#getLexicalDefiners(CGNode, String)}). Handle * using * {@link AstConstraintVisitor#handleRootLexicalReference(String, String, CGNode)} * . diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java index 83fc9c1ea..d96b467ef 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/GlobalObjectKey.java @@ -25,6 +25,7 @@ import com.ibm.wala.util.collections.Pair; * * @see JSSSAPropagationCallGraphBuilder */ +@SuppressWarnings("javadoc") public class GlobalObjectKey implements InstanceKey { private final IClass concreteType; diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java index 259acba4a..da48c6b33 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java @@ -89,7 +89,6 @@ abstract public class ScopeMappingInstanceKeys implements InstanceKeyFactory { * get the CGNode representing the lexical parent of {@link #creator} with * name definer * - * @param definer * @return */ public Iterator getFunargNodes(Pair name) { diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/AbstractReflectiveGet.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/AbstractReflectiveGet.java index a658fcb4e..566daa70e 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/AbstractReflectiveGet.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/AbstractReflectiveGet.java @@ -34,7 +34,7 @@ public abstract class AbstractReflectiveGet extends ReflectiveMemberAccess { } /** - * @see com.ibm.wala.ssa.Instruction#getDef() + * @see com.ibm.wala.ssa.SSAInstruction#getDef() */ @Override public boolean hasDef() { @@ -52,7 +52,7 @@ public abstract class AbstractReflectiveGet extends ReflectiveMemberAccess { } /** - * @see com.ibm.wala.ssa.Instruction#getNumberOfUses() + * @see com.ibm.wala.ssa.SSAInstruction#getNumberOfUses() */ @Override public int getNumberOfUses() { diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/AbstractReflectivePut.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/AbstractReflectivePut.java index 25758f9a0..9e5b76bc7 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/AbstractReflectivePut.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/AbstractReflectivePut.java @@ -34,7 +34,7 @@ public abstract class AbstractReflectivePut extends ReflectiveMemberAccess { } /** - * @see com.ibm.wala.ssa.Instruction#getDef() + * @see com.ibm.wala.ssa.SSAInstruction#getDef() */ @Override public int getDef() { @@ -42,7 +42,7 @@ public abstract class AbstractReflectivePut extends ReflectiveMemberAccess { } /** - * @see com.ibm.wala.ssa.Instruction#getNumberOfUses() + * @see com.ibm.wala.ssa.SSAInstruction#getNumberOfUses() */ @Override public int getNumberOfUses() { diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/analysis/LiveAnalysis.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/analysis/LiveAnalysis.java index 9d77b9b09..2aba02a0c 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/analysis/LiveAnalysis.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/ssa/analysis/LiveAnalysis.java @@ -297,11 +297,10 @@ public class LiveAnalysis { } /** - * Calculate set of variables live before instruction - * @param instr + * Calculate set of variables live before instruction {@code instr}. * * @see - * how the 'in' and 'out' variable sets work + * how the "in" and "out" variable sets work */ @Override public BitVector getLiveBefore(int instr) { diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/rewrite/CAstRewriter.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/rewrite/CAstRewriter.java index c493ec21a..3de8e51ff 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/rewrite/CAstRewriter.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/rewrite/CAstRewriter.java @@ -47,7 +47,7 @@ import com.ibm.wala.util.collections.Pair; * a key used to ease cloning of partial ASTs. When rewriting an AST, * sub-classes maintain a mapping from (original node, key) pairs * (where key is of type K) to new nodes; see - * {@link #copyNodes(CAstNode, RewriteContext, Map)} + * {@link #copyNodes} */ public abstract class CAstRewriter, K extends CAstRewriter.CopyKey> { diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java index 43c1870c5..e90a83dfe 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java @@ -123,7 +123,6 @@ public abstract class CAstVisitor { * Visit scoped entities of an entity using a given iterator. * Prerequisite (unchecked): i iterates over entities scoped in n. * @param n the parent entity of the entities to process - * @param i the iterator over some scoped entities of n * @param context a visitor-specific context */ public final void visitScopedEntities(CAstEntity n, Map allScopedEntities, C context, CAstVisitor visitor) { @@ -1723,7 +1722,6 @@ public abstract class CAstVisitor { * Visit an InstanceOf node. * @param n the node to process * @param c a visitor-specific context - * @return true if no further processing is needed */ protected void leaveAssert(CAstNode n, C c, CAstVisitor visitor) { visitor.leaveNode(n, c, visitor); } protected boolean visitAssert(CAstNode n, C c, CAstVisitor visitor) { return visitor.visitNode(n, c, visitor); } diff --git a/com.ibm.wala.core.testdata/src/reflection/GetMethodContext.java b/com.ibm.wala.core.testdata/src/reflection/GetMethodContext.java index bf6a37d09..a8712494d 100644 --- a/com.ibm.wala.core.testdata/src/reflection/GetMethodContext.java +++ b/com.ibm.wala.core.testdata/src/reflection/GetMethodContext.java @@ -18,6 +18,7 @@ import java.lang.reflect.Method; * A test targeting the {@link com.ibm.wala.analysis.reflection.GetMethodContext}. * @author Michael Heilmann */ +@SuppressWarnings("javadoc") public class GetMethodContext { public static class A { diff --git a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/callGraph/ReflectionTest.java b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/callGraph/ReflectionTest.java index 61136b2bf..fc14e95c3 100644 --- a/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/callGraph/ReflectionTest.java +++ b/com.ibm.wala.core.tests/src/com/ibm/wala/core/tests/callGraph/ReflectionTest.java @@ -585,7 +585,7 @@ public class ReflectionTest extends WalaTestCase { /** * Test that when analyzing Reflect21, the call graph includes a node for the - * constructor of {@link Helper} that takes two {@link Object} parameters. + * constructor of {@code Helper} that takes two {@link Object} parameters. * This is to test the support for Class.getDeclaredConstructor. */ @Test @@ -604,7 +604,7 @@ public class ReflectionTest extends WalaTestCase { /** * Test that when analyzing Reflect22, the call graph includes a node for the - * constructor of {@link Helper} that takes one {@link Integer} parameters. + * constructor of {@code Helper} that takes one {@link Integer} parameters. * This is to test the support for Class.getDeclaredConstructors. */ @Test @@ -623,7 +623,7 @@ public class ReflectionTest extends WalaTestCase { /** * Test that when analyzing Reflect22, the call graph includes a node for the - * constructor of {@link Helper} that takes one {@link Integer} parameters. + * constructor of {@code Helper} that takes one {@link Integer} parameters. * This is to test the support for Class.getDeclaredConstructors. */ @Test diff --git a/com.ibm.wala.core/src/com/ibm/wala/demandpa/util/MemoryAccessMap.java b/com.ibm.wala.core/src/com/ibm/wala/demandpa/util/MemoryAccessMap.java index 461526b70..6112e0941 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/demandpa/util/MemoryAccessMap.java +++ b/com.ibm.wala.core/src/com/ibm/wala/demandpa/util/MemoryAccessMap.java @@ -19,12 +19,12 @@ import com.ibm.wala.ipa.callgraph.propagation.PointerKey; public interface MemoryAccessMap { /** - * @return {@link Collection}<{@link FieldAccess}> + * @return {@link Collection}<{@link MemoryAccess}> */ public Collection getFieldReads(PointerKey baseRef, IField field); /** - * @return {@link Collection}<{@link FieldAccess}> + * @return {@link Collection}<{@link MemoryAccess}> */ public Collection getFieldWrites(PointerKey baseRef, IField field); diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/CallGraphBuilder.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/CallGraphBuilder.java index 7ec222867..218e87007 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/CallGraphBuilder.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/callgraph/CallGraphBuilder.java @@ -25,7 +25,6 @@ public interface CallGraphBuilder { * * @param options an object representing controlling options that the call graph building algorithm needs to know. * @return the built call graph - * @throws */ public CallGraph makeCallGraph(AnalysisOptions options, IProgressMonitor monitor) throws IllegalArgumentException, CallGraphBuilderCancelException; diff --git a/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/VolatileMethodSummary.java b/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/VolatileMethodSummary.java index c44efb37b..334d1df38 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/VolatileMethodSummary.java +++ b/com.ibm.wala.core/src/com/ibm/wala/ipa/summaries/VolatileMethodSummary.java @@ -82,6 +82,7 @@ import com.ibm.wala.util.strings.Atom; * @author Tobias Blaschke * @since 2013-09-08 */ +@SuppressWarnings("javadoc") public class VolatileMethodSummary { private static final boolean DEBUG = false; diff --git a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/ParameterAccessor.java b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/ParameterAccessor.java index 3e8671cdf..577a07ab3 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/ParameterAccessor.java +++ b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/ParameterAccessor.java @@ -294,7 +294,7 @@ public class ParameterAccessor { * * Using this Constructor influences the SSA-Values returned later. The cha is needed to * determine whether mRef is static. If this is already known one should prefer the faster - * {@link #ParameterAccessor(ParameterAccessor, boolean)}. + * {@link #ParameterAccessor(MethodReference, boolean)}. * * @param mRef The method to read the parameters from. */ @@ -393,7 +393,7 @@ public class ParameterAccessor { * * Do _not_ use ParameterAceesor(IMethod.getReference()), but ParameterAceesor(IMehod)! * - * This constructor is faster than {@link #ParameterAccessor(MethodReference, IClassHierarchy}. + * This constructor is faster than {@link #ParameterAccessor(MethodReference, IClassHierarchy)}. * * @param mRef The method to read the parameters from. */ @@ -457,7 +457,7 @@ public class ParameterAccessor { * * @param no the number in the Selector * @return new Parameter-Object for no - * @throws IllegalArgumentExceptions if the parameter is zero + * @throws IllegalArgumentException if the parameter is zero * @throws ArrayIndexOutOfBoundsException if no is not within bounds [1 to numberOfParameters] */ public Parameter getParameter(final int no) { diff --git a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java index 19da8b5e1..5def15e17 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java +++ b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java @@ -55,7 +55,7 @@ import com.ibm.wala.types.TypeReference; * Use ParameterAccessor to get the parameters of a function as SSAValues. * * @see com.ibm.wala.util.ssa.TypeSafeInstructionFactory - * @see com.ibm.wala.util.ParameterAccessor + * @see com.ibm.wala.util.ssa.ParameterAccessor * * @author Tobias Blaschke * @since 2013-10-20 @@ -188,7 +188,6 @@ public class SSAValue { * * @param number access the value using this number * @param validIn optionally assign this value to a method - * @param variableName optional name of the variable * @throws IllegalArgumentException on negative parameter number */ public SSAValue(final int number, final TypeReference type, final MethodReference validIn, final VariableKey key) { diff --git a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValueManager.java b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValueManager.java index 4339d2460..257100335 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValueManager.java +++ b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValueManager.java @@ -191,11 +191,10 @@ public class SSAValueManager { /** * Register a Phi-Instruction _after_ added to the model. * - * @param type the type the Phi-Instruction sets - * @param ssaValue the number the SSA-Instruction assigns to + * @param value the number the SSA-Instruction assigns to * @param setBy the Phi-Instruction itself - may be null * @throws IllegalArgumentException if you assign to a number requested using - * {@link #getFree(TypeReference)} but types mismatch. + * {@link #getFree} but types mismatch. * @throws IllegalStateException if you forgot to close some Phis */ public void setPhi(final SSAValue value, SSAInstruction setBy) { diff --git a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java index 8738928ab..986a2bb0e 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java +++ b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java @@ -52,6 +52,7 @@ import com.ibm.wala.classLoader.NewSiteReference; import com.ibm.wala.ipa.cha.IClassHierarchy; import com.ibm.wala.shrikeBT.IConditionalBranchInstruction; import com.ibm.wala.shrikeBT.IInvokeInstruction; +import com.ibm.wala.shrikeCT.BootstrapMethodsReader.BootstrapMethod; import com.ibm.wala.ssa.SSAArrayLoadInstruction; import com.ibm.wala.ssa.SSAArrayStoreInstruction; import com.ibm.wala.ssa.SSAConditionalBranchInstruction; @@ -100,7 +101,7 @@ public class TypeSafeInstructionFactory { * * Calls result.setAssigned() * - * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory.InvokeInstruction(int, int, int[], int, CallSiteReference) + * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#InvokeInstruction(int, int, int[], int, CallSiteReference, BootstrapMethod) * * @param iindex Zero or a positive number unique to any instruction of the same method * @param result Where to place the return-value of the called method. Is SSAValue.setAssigned() automatically. @@ -213,7 +214,7 @@ public class TypeSafeInstructionFactory { * All parameters (but exception) are typechecked first. If the check passes they get unpacked and handed over * to the corresponding JavaInstructionFactory.InvokeInstruction. * - * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory.InvokeInstruction(int, int[], int, CallSiteReference) + * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#InvokeInstruction(int, int[], int, CallSiteReference, BootstrapMethod) * * @param iindex Zero or a positive number unique to any instruction of the same method * @param params Parameters to the call starting with the implicit this-pointer if necessary @@ -311,7 +312,7 @@ public class TypeSafeInstructionFactory { * * If type check passes the corresponding ReturnInstruction of the JavaInstructionFactory is called. * - * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory.ReturnInstruction(int, int, boolean) + * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#ReturnInstruction(int, int, boolean) * * @param iindex Zero or a positive number unique to any instruction of the same method * @param result SSAValue to return _with_ validIn _set_! @@ -337,7 +338,7 @@ public class TypeSafeInstructionFactory { * If type check passes the corresponding GetInstruction of the JavaInstructionFactory is called. * Calls targetValue.setAssigned() * - * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory.GetInstruction(int, int, int, FieldReference) + * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#GetInstruction(int, int, int, FieldReference) * * @param iindex Zero or a positive number unique to any instruction of the same method * @param targetValue the result of the GetInstruction is placed there @@ -386,11 +387,10 @@ public class TypeSafeInstructionFactory { * If type check passes the corresponding GetInstruction of the JavaInstructionFactory is called. * Calls targetValue.setAssigned() * - * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory.GetInstruction(int, int, int, FieldReference) + * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#GetInstruction(int, int, int, FieldReference) * * @param iindex Zero or a positive number unique to any instruction of the same method * @param targetValue the result of the GetInstruction is placed there - * @param containingInstance The Object instance to read the field from * @param field The description of the field */ public SSAGetInstruction GetInstruction(final int iindex, final SSAValue targetValue, FieldReference field) { @@ -420,7 +420,7 @@ public class TypeSafeInstructionFactory { * * If type check passes the corresponding PutInstruction of the JavaInstructionFactory is called. * - * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory.PutInstruction(int, int, int, FieldReference) + * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#PutInstruction(int, int, int, FieldReference) * * @param iindex Zero or a psitive number unique to any instruction of the same method * @param targetInstance the instance of the object to write a field of @@ -467,10 +467,9 @@ public class TypeSafeInstructionFactory { * * If type check passes the corresponding PutInstruction of the JavaInstructionFactory is called. * - * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory.PutInstruction(int, int, int, FieldReference) + * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#PutInstruction(int, int, int, FieldReference) * * @param iindex Zero or a psitive number unique to any instruction of the same method - * @param targetInstance the instance of the object to write a field of * @param newValue The value to write to the field * @param field The description of the target */ @@ -559,7 +558,7 @@ public class TypeSafeInstructionFactory { * If type check passes the corresponding PhiInstruction of the JavaInstructionFactory is called. * Calls result.setAssigned(). * - * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory.PhiInstruction(int, int, int[]) + * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#PhiInstruction(int, int, int[]) * * @param iindex Zero or a positive number unique to any instruction of the same method * @param result Where to write result to diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/classLoader/DexIMethod.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/classLoader/DexIMethod.java index 3b6010d10..2f1133ae3 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/classLoader/DexIMethod.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/classLoader/DexIMethod.java @@ -259,7 +259,7 @@ public class DexIMethod implements IBytecodeMethod { /** * XXX not fully about the + 2. * @return the RegisterCount + 2 to make some room for the return and exception register - * @see com.ibm.wala.classLoader.IMethod#getMaxLocals() + * @see com.ibm.wala.classLoader.ShrikeCTMethod#getMaxLocals() */ public int getMaxLocals() { return eMethod.codeItem.getRegisterCount() + 2; diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java index 7cca39603..fe6fb7ad0 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java @@ -167,7 +167,7 @@ public class AndroidModel /* makes SummarizedMethod */ * Generates the model on a sub-set of Entrypoints. * * Asks {@link #selectEntryPoint(AndroidEntryPoint)} for each EntryPoint known to the AndroidEntryPointManager, - * if the EntryPoint should be included in the model. Then calls {@link #build(Atom, Iterable)} + * if the EntryPoint should be included in the model. Then calls {@link #build(Atom, Collection)} * on these. * * @param name The name the generated method will be known as @@ -334,7 +334,7 @@ public class AndroidModel /* makes SummarizedMethod */ /** * Add Instructions to the model. * - * {@link #build(Iterable)} prepares the MethodSummary, then calls populate() to + * {@link #build(Atom, Collection)} prepares the MethodSummary, then calls populate() to * add the instructions, then finishes the model. Populate is only an extra function to shorten build(), * calling it doesn't make sense in an other context. */ @@ -575,7 +575,6 @@ public class AndroidModel /* makes SummarizedMethod */ * @see com.ibm.wala.dalvik.ipa.callgraph.propagation.cfa.IntentStarters * * @param asMethod The signature to generate - * @param flags Control the behavior of the wrapper, may be null * @param caller The class of the caller; only needed depending on the flags * @param info The IntentSterter used * @param callerNd CGNoodle of the caller - may be null diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModelClass.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModelClass.java index c2d4dfdc0..2b53e8b57 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModelClass.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModelClass.java @@ -84,7 +84,7 @@ import com.ibm.wala.util.strings.Atom; * * In the generated code this class may be found as "Lcom/ibm/wala/AndroidModelClass" * - * @see com.ibm.wala.dalvik.ipa.callgraph.impl.FakeRootClass + * @see com.ibm.wala.ipa.callgraph.impl.FakeRootClass * * @author Tobias Blaschke * @todo Move this class into an other loader? Currently: Primordial diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/AndroidModelParameterManager.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/AndroidModelParameterManager.java index 4d15e9b1f..ae51abcaa 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/AndroidModelParameterManager.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/AndroidModelParameterManager.java @@ -61,7 +61,6 @@ import com.ibm.wala.util.ssa.SSAValue; * However it does no allocations or Phi-Statements on its own. It just juggles with the numbers. * * @see com.ibm.wala.dalvik.ipa.callgraph.androidModel.structure.AbstractAndroidModel - * @see com.ibm.wala.dalvik.ipa.callgraph.impl.DexFakeRootMethod * * @author Tobias Blaschke * @since 2013-09-19 @@ -662,7 +661,7 @@ public class AndroidModelParameterManager { * Handed through to an IInstantiationBehavior if set in the constructor. * * @return true if Type is a REUSE type - * @throws IllegalStateExcpetion if AndroidModelParameterManager was constructed without an IInstanciationBehavior + * @throws IllegalStateException if AndroidModelParameterManager was constructed without an IInstanciationBehavior */ public boolean isReuse(TypeReference type) { if (this.behaviour == null) { @@ -677,7 +676,7 @@ public class AndroidModelParameterManager { * Shorthand for not({@link #isReuse(TypeReference)}. * * @return true if type is a CREATE-Type - * @throws IllegalStateExcpetion if AndroidModelParameterManager was constructed without an IInstanciationBehavior + * @throws IllegalStateException if AndroidModelParameterManager was constructed without an IInstanciationBehavior */ public boolean isCreate(TypeReference type) { return (! isReuse(type)); diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/FlatInstantiator.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/FlatInstantiator.java index d603c387b..332f74887 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/FlatInstantiator.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/FlatInstantiator.java @@ -343,9 +343,6 @@ public class FlatInstantiator implements IInstantiator { return instance; } - /** - * @return an unallocated SSAVariable - */ private void createPrimitive(SSAValue instance) { // XXX; something else? instance.setAssigned(); @@ -385,7 +382,7 @@ public class FlatInstantiator implements IInstantiator { * * @param self the "this" to call the constructor on * @param ctor the constructor to call - * @param params parameters to the ctor _without_ implicit this + * @param ctorParams parameters to the ctor _without_ implicit this */ protected void addCallCtor(SSAValue self, MethodReference ctor, List ctorParams) { final int pc = this.body.getNextProgramCounter(); diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/IInstantiationBehavior.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/IInstantiationBehavior.java index 7bdb3091b..2b1f14319 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/IInstantiationBehavior.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/IInstantiationBehavior.java @@ -67,7 +67,7 @@ public abstract class IInstantiationBehavior implements Serializable { } /** - * Information on how the IInstanciationBehavior made its decision for {@link #InstanceBehavior} + * Information on how the IInstanciationBehavior made its decision for {@link InstanceBehavior} */ public static enum Exactness { /** @@ -92,7 +92,7 @@ public abstract class IInstantiationBehavior implements Serializable { /** * Returns how the model should behave on the type. * - * See the documentation of {@link #InstanceBehavior} for the description of the possible behaviours. + * See the documentation of {@link InstanceBehavior} for the description of the possible behaviours. * * Although this function takes a parameter withName one should not rely on its value. * diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/Instantiator.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/Instantiator.java index 6aac763ca..be6fe5d1e 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/Instantiator.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/Instantiator.java @@ -344,9 +344,6 @@ public class Instantiator implements IInstantiator { return instance; } - /** - * @return an unallocated SSAVariable - */ private void createPrimitive(SSAValue instance) { // XXX; something else? instance.setAssigned(); @@ -386,7 +383,7 @@ public class Instantiator implements IInstantiator { * * @param self the "this" to call the constructor on * @param ctor the constructor to call - * @param params parameters to the ctor _without_ implicit this + * @param ctorParams parameters to the ctor _without_ implicit this */ private void addCallCtor(SSAValue self, MethodReference ctor, List ctorParams) { final int pc = this.body.getNextProgramCounter(); diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/AbstractAndroidModel.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/AbstractAndroidModel.java index 3dce2e314..d9460e0d0 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/AbstractAndroidModel.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/AbstractAndroidModel.java @@ -69,7 +69,6 @@ import com.ibm.wala.util.ssa.TypeSafeInstructionFactory; * which aids in keeping track of SSA-Variables and adding Phi-Functions. * * @see com.ibm.wala.dalvik.ipa.callgraph.impl.AndroidEntryPoint.ExecutionOrder - * @see com.ibm.wala.dalvik.ipa.callgraph.impl.DexFakeRootMethod * @see com.ibm.wala.dalvik.ipa.callgraph.androidModel.parameters.AndroidModelParameterManager * * @author Tobias Blaschke @@ -197,7 +196,7 @@ public abstract class AbstractAndroidModel { * Gets called when Label ExecutionOrder.AT_FIRST got stepped over. * * In most cases you don't want to invoke this function directly but to use - * {@link #enter(ExecutionOrder.AT_FIRST, int)} instead. + * {@code enter(ExecutionOrder.AT_FIRST, int)} instead. * * Sideeffects: currentSection is updated, instructions are inserted into the body * @@ -211,7 +210,7 @@ public abstract class AbstractAndroidModel { * Gets called when Label ExecutionOrder.BEFORE_LOOP got stepped over. * * In most cases you don't want to invoke this function directly but to use - * {@link #enter(ExecutionOrder.BEFORE_LOOP, int)} instead + * {@code enter(ExecutionOrder.BEFORE_LOOP, int)} instead * * Sideeffects: currentSection is updated, instructions are inserted into the body * @@ -225,7 +224,7 @@ public abstract class AbstractAndroidModel { * Gets called when Label ExecutionOrder.START_OF_LOOP got stepped over. * * In most cases you don't want to invoke this function directly but to use - * {@link #enter(ExecutionOrder.START_OF_LOOP, int)} instead + * {@code enter(ExecutionOrder.START_OF_LOOP, int)} instead * * Sideeffects: currentSection is updated, instructions are inserted into the body * @@ -239,7 +238,7 @@ public abstract class AbstractAndroidModel { * Gets called when Label ExecutionOrder.MIDDLE_OF_LOOP got stepped over. * * In most cases you don't want to invoke this function directly but to use - * {@link #enter(ExecutionOrder.MIDDLE_OF_LOOP, int)} instead + * {@code enter(ExecutionOrder.MIDDLE_OF_LOOP, int)} instead * * Sideeffects: currentSection is updated, instructions are inserted into the body * @@ -253,7 +252,7 @@ public abstract class AbstractAndroidModel { * Gets called when Label ExecutionOrder.MULTIPLE_TIMES_IN_LOOP got stepped over. * * In most cases you don't want to invoke this function directly but to use - * {@link #enter(ExecutionOrder.MULTIPLE_TIMES_IN_LOOP, int)} instead + * {@code enter(ExecutionOrder.MULTIPLE_TIMES_IN_LOOP, int)} instead * * Sideeffects: currentSection is updated, instructions are inserted into the body * @@ -267,7 +266,7 @@ public abstract class AbstractAndroidModel { * Gets called when Label ExecutionOrder.END_OF_LOOP got stepped over. * * In most cases you don't want to invoke this function directly but to use - * {@link #enter(ExecutionOrder.END_OF_LOOP, int)} instead + * {@code enter(ExecutionOrder.END_OF_LOOP, int)} instead * * Sideeffects: currentSection is updated, instructions are inserted into the body * @@ -281,7 +280,7 @@ public abstract class AbstractAndroidModel { * Gets called when Label ExecutionOrder.AFTER_LOOP got stepped over. * * In most cases you don't want to invoke this function directly but to use - * {@link #enter(ExecutionOrder.AFTER_LOOP, int)} instead + * {@code enter(ExecutionOrder.AFTER_LOOP, int)} instead * * Sideeffects: currentSection is updated, instructions are inserted into the body * @@ -295,7 +294,7 @@ public abstract class AbstractAndroidModel { * Gets called when Label ExecutionOrder.AT_LAST got stepped over. * * In most cases you don't want to invoke this function directly but to use - * {@link #enter(ExecutionOrder.AT_LAST, int)} instead + * {@code enter(ExecutionOrder.AT_LAST, int)} instead * * Sideeffects: currentSection is updated, instructions are inserted into the body * diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/LoopAndroidModel.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/LoopAndroidModel.java index 5116d9566..38a66321d 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/LoopAndroidModel.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/LoopAndroidModel.java @@ -74,8 +74,6 @@ import com.ibm.wala.util.ssa.TypeSafeInstructionFactory; * restart of the Application (instance-state) or when the potential restart of the App * shall be ignored. * - * {@inheritDoc} - * * @author Tobias Blaschke */ public class LoopAndroidModel extends SingleStartAndroidModel { diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/SequentialAndroidModel.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/SequentialAndroidModel.java index ddec1d616..c96a8d198 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/SequentialAndroidModel.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/SequentialAndroidModel.java @@ -53,8 +53,6 @@ import com.ibm.wala.util.ssa.TypeSafeInstructionFactory; * This model should not be particular useful in practice. However it might come in * handy for debugging purposes or as a skeleton for an other Model. * - * {@inheritDoc} - * * @author Tobias Blaschke * @since 2013-09-18 */ diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/SingleStartAndroidModel.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/SingleStartAndroidModel.java index ffb884c24..009cc2c36 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/SingleStartAndroidModel.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/SingleStartAndroidModel.java @@ -71,8 +71,6 @@ import com.ibm.wala.util.ssa.TypeSafeInstructionFactory; * The incorporated loop is wrapped around user-interaction methods. These are in the section * MULTIPLE_TIMES_IN_LOOP. * - * {@inheritDoc} - * * @see com.ibm.wala.dalvik.ipa.callgraph.androidModel.structure.LoopAndroidModel * @see com.ibm.wala.dalvik.ipa.callgraph.androidModel.structure.LoopKillAndroidModel * @author Tobias Blaschke diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/package-info.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/package-info.java index 1ec39510c..aa3f83618 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/package-info.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/structure/package-info.java @@ -45,7 +45,7 @@ * * All Classes in this package extend AbstractAndroidModel. * - * @see com.com.ibm.wala.dalvik.ipa.callgraph.androidModel.structure.AbstractAndroidModel + * @see com.ibm.wala.dalvik.ipa.callgraph.androidModel.structure.AbstractAndroidModel * * @since 2013-10-25 * @author Tobias Blaschke diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/stubs/AndroidBoot.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/stubs/AndroidBoot.java index 7c5d74c0d..f94e7b5be 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/stubs/AndroidBoot.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/stubs/AndroidBoot.java @@ -179,7 +179,8 @@ public class AndroidBoot { * * @see android.app.ContextImpl.createPackageContextAsUser */ - private SSAValue createSystemContext(SSAValue mainThread) { + @SuppressWarnings("javadoc") + private SSAValue createSystemContext(SSAValue mainThread) { final SSAValue systemContext = this.pm.getUnmanaged(AndroidTypes.ContextImpl, "systemContextImpl"); { // Call ContextImpl.getSystemContext() final int pc = this.body.getNextProgramCounter(); @@ -211,7 +212,8 @@ public class AndroidBoot { * * @see android.app.ContextImpl.createPackageContextAsUser */ - private SSAValue createPackageContext(final SSAValue mainThread, final SSAValue systemContext) { + @SuppressWarnings("javadoc") + private SSAValue createPackageContext(final SSAValue mainThread, final SSAValue systemContext) { final SSAValue packageContext = this.pm.getUnmanaged(AndroidTypes.ContextImpl, "packageContextImpl"); { // New-Site final int pc = this.body.getNextProgramCounter(); diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/impl/AndroidEntryPoint.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/impl/AndroidEntryPoint.java index c80cc766f..b10da1d33 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/impl/AndroidEntryPoint.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/impl/AndroidEntryPoint.java @@ -173,7 +173,6 @@ public class AndroidEntryPoint extends DexEntryPoint { return ExecutionOrder.AT_LAST; } - /** {@inheritDoc} */ public int getOrderValue() { return order.getOrderValue(); } public int compareTo(AndroidEntryPoint.IExecutionOrder o) { return this.order.compareTo(o); @@ -264,7 +263,7 @@ public class AndroidEntryPoint extends DexEntryPoint { * Use this to place a call to an EntryPoint between two other EntryPoint calls or ExecutionOrder "labels". * between() does not care about section-boundaries by itself! * - * Use {@link between(IExecutionOrder[], IExecutionOrder[])} and use labels as additional placement-information + * Use {@link #between(IExecutionOrder[], IExecutionOrder[])} and use labels as additional placement-information * to prevent unexpected misplacement. * * @param after the call or "label" to be executed before this one diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/propagation/cfa/Intent.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/propagation/cfa/Intent.java index 36c8d9c09..b1d0574af 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/propagation/cfa/Intent.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/propagation/cfa/Intent.java @@ -314,8 +314,6 @@ public class Intent implements ContextItem, Comparable { /** * Fallback: tries to determine on the Intent itself if it's a standard action. - * - * Use {@link #isStandardAction(boolean)} instead. */ private static boolean isStandardAction(Intent intent) { //TODO: This may loop forever! /*final Intent override = AndroidEntryPointManager.MANAGER.getIntent(intent); diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/propagation/cfa/IntentStarters.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/propagation/cfa/IntentStarters.java index 9aaa79a25..4d554b46b 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/propagation/cfa/IntentStarters.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/propagation/cfa/IntentStarters.java @@ -146,7 +146,7 @@ public class IntentStarters { /** * These influence how the model is built. * - * @see com.ibm.wala.dalvik.ipa.callgraph.propagation.cfa.IntentStarters.StarerFlags + * @see com.ibm.wala.dalvik.ipa.callgraph.propagation.cfa.IntentStarters.StarterFlags */ public Set getFlags() { return this.flags; diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ssa/AbstractIntRegisterMachine.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ssa/AbstractIntRegisterMachine.java index 96fd2c016..627467a6d 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ssa/AbstractIntRegisterMachine.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ssa/AbstractIntRegisterMachine.java @@ -902,7 +902,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants protected class BasicRegisterMachineVisitor extends Visitor { /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitArrayLength(ArrayLengthInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitArrayLength(ArrayLengthInstruction) */ @Override public void visitArrayLength(ArrayLength instruction) { @@ -914,7 +914,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitArrayLoad(IArrayLoadInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitArrayLoad(IArrayLoadInstruction) */ @Override public void visitArrayGet(ArrayGet instruction) { @@ -927,7 +927,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitArrayStore(IArrayStoreInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitArrayStore(IArrayStoreInstruction) */ @Override public void visitArrayPut(ArrayPut instruction) { @@ -939,7 +939,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitBinaryOp(IBinaryOpInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitBinaryOp(IBinaryOpInstruction) */ @Override public void visitBinaryOperation(BinaryOperation instruction) { @@ -949,7 +949,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitComparison(IComparisonInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitComparison(IComparisonInstruction) */ // @Override // public void visitComparison(IComparisonInstruction instruction) { @@ -959,7 +959,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitConditionalBranch(IConditionalBranchInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitConditionalBranch(IConditionalBranchInstruction) */ @Override public void visitBranch(Branch instruction) { @@ -970,7 +970,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitConstant(ConstantInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitConstant(ConstantInstruction) */ @Override public void visitConstant(Constant instruction) { @@ -980,7 +980,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitConversion(IConversionInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitConversion(IConversionInstruction) */ // @Override // public void visitConversion(IConversionInstruction instruction) { @@ -989,7 +989,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitDup(DupInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitDup(DupInstruction) */ // @Override // public void visitDup(DupInstruction instruction) { @@ -1022,7 +1022,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitGet(IGetInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitGet(IGetInstruction) */ @Override public void visitGetField(GetField instruction) { @@ -1039,7 +1039,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitInstanceof(InstanceofInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitInstanceof */ @Override public void visitInstanceof(InstanceOf instruction) { @@ -1050,7 +1050,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitInvoke(IInvokeInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitInvoke(IInvokeInstruction) */ @Override public void visitInvoke(Invoke instruction) { @@ -1065,7 +1065,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitMonitor(MonitorInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitMonitor(MonitorInstruction) */ @Override public void visitMonitor(Monitor instruction) { @@ -1075,7 +1075,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitLocalLoad(ILoadInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitLocalLoad(ILoadInstruction) */ // @Override // public void visitLocalLoad(ILoadInstruction instruction) { @@ -1084,7 +1084,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitLocalStore(IStoreInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitLocalStore(IStoreInstruction) */ // @Override // public void visitLocalStore(IStoreInstruction instruction) { @@ -1093,7 +1093,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitNew(NewInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitNew(NewInstruction) */ @Override public void visitNew(New instruction) { @@ -1104,7 +1104,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitPop(PopInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitPop(PopInstruction) */ // @Override // public void visitPop(PopInstruction instruction) { @@ -1114,7 +1114,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitPut(IPutInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitPut(IPutInstruction) */ @Override public void visitPutField(PutField instruction) { @@ -1124,7 +1124,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitShift(IShiftInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitShift(IShiftInstruction) */ // @Override // public void visitShift(IShiftInstruction instruction) { @@ -1132,7 +1132,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitSwap(SwapInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitSwap(SwapInstruction) */ // @Override // public void visitSwap(SwapInstruction instruction) { @@ -1140,7 +1140,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitSwitch(SwitchInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitSwitch(SwitchInstruction) */ @Override public void visitSwitch(Switch instruction) { @@ -1150,7 +1150,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitThrow(ThrowInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitThrow(ThrowInstruction) */ @Override public void visitThrow(Throw instruction) { @@ -1162,7 +1162,7 @@ public abstract class AbstractIntRegisterMachine implements FixedPointConstants } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitUnaryOp(IUnaryOpInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitUnaryOp(IUnaryOpInstruction) */ @Override public void visitUnaryOperation(UnaryOperation instruction) { diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ssa/DexSSABuilder.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ssa/DexSSABuilder.java index 12ef0b0ad..d67541c5a 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ssa/DexSSABuilder.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ssa/DexSSABuilder.java @@ -428,7 +428,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { // TODO: make sure all visit functions are overridden /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitArrayLength(ArrayLengthInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitArrayLength(ArrayLengthInstruction) */ @Override public void visitArrayLength(ArrayLength instruction) { @@ -441,7 +441,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitArrayLoad(IArrayLoadInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitArrayLoad(IArrayLoadInstruction) */ @Override public void visitArrayGet(ArrayGet instruction) { @@ -462,7 +462,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitArrayStore(IArrayStoreInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitArrayStore(IArrayStoreInstruction) */ @Override public void visitArrayPut(ArrayPut instruction) { @@ -536,7 +536,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitBinaryOp(IBinaryOpInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitBinaryOp(IBinaryOpInstruction) */ @Override public void visitBinaryOperation(BinaryOperation instruction) { @@ -553,7 +553,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitBinaryOp(IBinaryOpInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitBinaryOp(IBinaryOpInstruction) */ @Override public void visitBinaryLiteral(BinaryLiteralOperation instruction) { @@ -597,7 +597,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitCheckCast(CheckCastInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitCheckCast */ @Override public void visitCheckCast(CheckCast instruction) { @@ -612,7 +612,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitConditionalBranch(IConditionalBranchInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitConditionalBranch(IConditionalBranchInstruction) */ @Override public void visitBranch(Branch instruction) { @@ -642,7 +642,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitConstant(ConstantInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitConstant(ConstantInstruction) */ @Override public void visitConstant(Constant instruction) { @@ -709,7 +709,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitConversion(IConversionInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitConversion(IConversionInstruction) */ // TODO: is this just a unary operation? // @Override @@ -726,7 +726,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitGet(IGetInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitGet(IGetInstruction) */ @Override public void visitGetField(GetField instruction) { @@ -762,7 +762,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitGoto(GotoInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitGoto(GotoInstruction) */ @Override public void visitGoto(Goto instruction) { @@ -770,7 +770,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitInstanceof(InstanceofInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitInstanceof */ @Override public void visitInstanceof(InstanceOf instruction) { @@ -785,7 +785,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitInvoke(IInvokeInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitInvoke(IInvokeInstruction) */ @Override public void visitInvoke(Invoke instruction) { @@ -903,7 +903,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { // } // // /* -// * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitLocalStore(com.ibm.wala.shrikeBT.StoreInstruction) +// * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitLocalStore(com.ibm.wala.shrikeBT.StoreInstruction) // */ // @Override // public void visitLocalStore(IStoreInstruction instruction) { @@ -914,7 +914,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitMonitor(MonitorInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitMonitor(MonitorInstruction) */ @Override public void visitMonitor(Monitor instruction) { @@ -924,7 +924,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitNew(NewInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitNew(NewInstruction) */ @Override public void visitNew(New instruction) { @@ -990,7 +990,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitGet(IGetInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitGet(IGetInstruction) */ @Override public void visitPutField(PutField instruction) { @@ -1011,7 +1011,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitReturn(ReturnInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitReturn(ReturnInstruction) */ @Override public void visitReturn(Return instruction) { @@ -1046,7 +1046,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitShift(IShiftInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitShift(IShiftInstruction) */ // TODO: this is just a binary operation // @Override @@ -1060,7 +1060,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { // } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitSwitch(SwitchInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitSwitch(SwitchInstruction) */ @Override public void visitSwitch(Switch instruction) { @@ -1104,7 +1104,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitThrow(ThrowInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitThrow(ThrowInstruction) */ @Override public void visitThrow(Throw instruction) { @@ -1123,7 +1123,7 @@ public class DexSSABuilder extends AbstractIntRegisterMachine { } /** - * @see com.ibm.wala.shrikeBT.Instruction.Visitor#visitUnaryOp(IUnaryOpInstruction) + * @see com.ibm.wala.shrikeBT.IInstruction.Visitor#visitUnaryOp(IUnaryOpInstruction) */ @Override public void visitUnaryOperation(UnaryOperation instruction) { diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/util/AndroidEntryPointManager.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/util/AndroidEntryPointManager.java index b869ee3c9..008ce5c34 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/util/AndroidEntryPointManager.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/util/AndroidEntryPointManager.java @@ -222,7 +222,7 @@ public final /* singleton */ class AndroidEntryPointManager implements Serializa /** * Whether to generate a global android environment. * - * See the {@link #setDoBootSequence()} documentation. + * See the {@link #setDoBootSequence} documentation. * * @return the setting, defaults to true */ @@ -293,7 +293,7 @@ public final /* singleton */ class AndroidEntryPointManager implements Serializa /** * The behavior set using setModelBehavior(Class). * - * Use {@link makeModelBehavior(VolatileMethodSummary, JavaInstructionFactory, AndroidModelParameterManager, Iterable} + * Use {@link #makeModelBehavior} * to retrieve an instance of this class. * * If no class was set it returns null, makeModelBehavior will generate a LoopAndroidModel by default. @@ -362,7 +362,7 @@ public final /* singleton */ class AndroidEntryPointManager implements Serializa * See: {@link #setPackage(String)} * * @return The package or null if it was indeterminable. - * @see guessPacakge() + * @see #guessPackage() */ public String getPackage() { if (this.pack == null) { @@ -380,7 +380,7 @@ public final /* singleton */ class AndroidEntryPointManager implements Serializa * the package based on the first entrypoint. * * @return The package or null if it was indeterminable. - * @see getPackage() + * @see #getPackage() */ public String guessPackage() { if (this.pack != null) { @@ -418,7 +418,7 @@ public final /* singleton */ class AndroidEntryPointManager implements Serializa * @param intent An Intent with more or the same information as known to the system before. * @throws IllegalArgumentException if you lower the information on an already registered Intent or the * information is incompatible. - * @see registerIntentForce() + * @see #registerIntentForce */ public void registerIntent(Intent intent) { if (overrideIntents.containsKey(intent)) { @@ -476,7 +476,7 @@ public final /* singleton */ class AndroidEntryPointManager implements Serializa * * @param from the Intent to override * @param to the new Intent to resolve once 'from' is seen - * @see setOverrideForce() + * @see #setOverrideForce * @throws IllegalArgumentException if you override an Intent with itself */ public void setOverride(Intent from, Intent to) { diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/util/androidEntryPoints/FragmentEP.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/util/androidEntryPoints/FragmentEP.java index e4bd040c5..7606389c9 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/util/androidEntryPoints/FragmentEP.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/util/androidEntryPoints/FragmentEP.java @@ -297,7 +297,7 @@ public final class FragmentEP { // /** - * @see ActivityEP.onActivityResult + * @see ActivityEP#onActivityResult */ public static final AndroidPossibleEntryPoint onActivityResult = new AndroidPossibleEntryPoint(AndroidComponent.FRAGMENT, "onActivityResult", @@ -401,15 +401,15 @@ public final class FragmentEP { )); /** - * @see ActivityEP.onLowMemory - * @see ApplicationEP.onLowMemory + * @see ActivityEP#onLowMemory + * @see ApplicationEP#onLowMemory */ public static final AndroidPossibleEntryPoint onLowMemory = new AndroidPossibleEntryPoint(AndroidComponent.FRAGMENT, "onLowMemory", ExecutionOrder.directlyBefore(ActivityEP.onLowMemory) ); /** - * @see ActivityEP.onOptionsItemSelected + * @see ActivityEP#onOptionsItemSelected */ public static final AndroidPossibleEntryPoint onOptionsItemSelected = new AndroidPossibleEntryPoint(AndroidComponent.FRAGMENT, "onOptionsItemSelected", @@ -417,7 +417,7 @@ public final class FragmentEP { ); /** - * @see ActivityEP.onOptionsMenuClosed + * @see ActivityEP#onOptionsMenuClosed */ public static final AndroidPossibleEntryPoint onOptionsMenuClosed = new AndroidPossibleEntryPoint(AndroidComponent.FRAGMENT, "onOptionsMenuClosed", @@ -427,7 +427,7 @@ public final class FragmentEP { /** * This is called right before the menu is shown, every time it is shown. * - * @see ActivityEP.onPrepareOptionsMenu + * @see ActivityEP#onPrepareOptionsMenu */ public static final AndroidPossibleEntryPoint onPrepareOptionsMenu = new AndroidPossibleEntryPoint(AndroidComponent.FRAGMENT, "onPrepareOptionsMenu", @@ -467,7 +467,7 @@ public final class FragmentEP { )); /** - * @see ActtivityEP.onTrimMemory + * @see ActivityEP#onTrimMemory */ public static final AndroidPossibleEntryPoint onTrimMemory = new AndroidPossibleEntryPoint(AndroidComponent.FRAGMENT, "onTrimMemory", diff --git a/com.ibm.wala.scandroid/source/org/scandroid/synthmethod/XMLSummaryWriter.java b/com.ibm.wala.scandroid/source/org/scandroid/synthmethod/XMLSummaryWriter.java index 2d5453e7a..13c781b4a 100644 --- a/com.ibm.wala.scandroid/source/org/scandroid/synthmethod/XMLSummaryWriter.java +++ b/com.ibm.wala.scandroid/source/org/scandroid/synthmethod/XMLSummaryWriter.java @@ -175,7 +175,6 @@ public class XMLSummaryWriter { * No guarantees as to the state of the Document if an exception is thrown. * * @param summary - * @return * @throws DOMException * @throws UTFDataFormatException * @throws SSASerializationException diff --git a/com.ibm.wala.scandroid/source/org/scandroid/util/AndroidAnalysisContext.java b/com.ibm.wala.scandroid/source/org/scandroid/util/AndroidAnalysisContext.java index 1d50ab9c9..d747952fd 100644 --- a/com.ibm.wala.scandroid/source/org/scandroid/util/AndroidAnalysisContext.java +++ b/com.ibm.wala.scandroid/source/org/scandroid/util/AndroidAnalysisContext.java @@ -115,8 +115,6 @@ public class AndroidAnalysisContext { /** * @param exclusions - * @param classpath - * @param packagename * @throws IOException * @throws IllegalArgumentException * @throws CancelException diff --git a/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/ConstantPoolParser.java b/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/ConstantPoolParser.java index 7efc0af73..3b89e320a 100644 --- a/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/ConstantPoolParser.java +++ b/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/ConstantPoolParser.java @@ -119,7 +119,6 @@ public final class ConstantPoolParser implements ClassConstants { * @param bytes the raw class file data * @param offset the start of the constant pool data * @param itemCount the number of items in the pool - * @param classReader */ public ConstantPoolParser(byte[] bytes, int offset, int itemCount) throws InvalidClassFileException { this.bytes = bytes; diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/CancelException.java b/com.ibm.wala.util/src/com/ibm/wala/util/CancelException.java index 935c9bbc0..b6275eed2 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/CancelException.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/CancelException.java @@ -14,6 +14,7 @@ package com.ibm.wala.util; * An exception for when work is canceled in eclipse. This version forces every API that uses it to declare it. Use * {@link CancelRuntimeException} to avoid the need to declare a cancel exception. */ +@SuppressWarnings("javadoc") public class CancelException extends Exception { protected CancelException(String msg) { diff --git a/com.ibm.wala.util/src/com/ibm/wala/util/config/SetOfClasses.java b/com.ibm.wala.util/src/com/ibm/wala/util/config/SetOfClasses.java index 08dce7a50..5ff94eefa 100644 --- a/com.ibm.wala.util/src/com/ibm/wala/util/config/SetOfClasses.java +++ b/com.ibm.wala.util/src/com/ibm/wala/util/config/SetOfClasses.java @@ -14,7 +14,7 @@ import java.io.Serializable; import java.util.Set; /** - * Logically, a set of {@link IClass}. + * Logically, a set of {@link Class}. * * TODO: why does this not extend {@link Set}? Is there a good reason anymore? */