DASCA
/
WALA
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix 11 Eclipse warnings about redundant interfaces

This commit is contained in:
Ben Liblit 2017-03-17 22:13:02 -05:00
parent 6766f1e261
commit aa878f0b68
20 changed files with 20 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
com.ibm.wala.cast.js.rhino/source/com/ibm/wala/cast/js/translator/CAstRhinoTranslator.java
View File

@ -11,11 +11,10 @@
package com.ibm.wala.cast.js.translator;
import com.ibm.wala.cast.ir.translator.RewritingTranslatorToCAst;
import com.ibm.wala.cast.ir.translator.TranslatorToCAst;
import com.ibm.wala.cast.tree.impl.CAstImpl;
import com.ibm.wala.classLoader.ModuleEntry;
public class CAstRhinoTranslator extends RewritingTranslatorToCAst implements TranslatorToCAst {
public class CAstRhinoTranslator extends RewritingTranslatorToCAst {
public CAstRhinoTranslator(ModuleEntry m, boolean replicateForDoLoops) {
super(m, new RhinoToAstTranslator(new CAstImpl(), m, m.getName(), replicateForDoLoops));
}

2
com.ibm.wala.cast.js/source/com/ibm/wala/cast/js/ipa/callgraph/JSCallGraphUtil.java
View File

@ -255,7 +255,7 @@ public class JSCallGraphUtil extends com.ibm.wala.cast.ipa.callgraph.CAstCallGra
}
}
public static class Bootstrap implements SourceModule, Module, ModuleEntry {
public static class Bootstrap implements SourceModule {
private String name;
private InputStream stream;
private final URL url;

3
com.ibm.wala.cast/source/java/com/ibm/wala/cast/ir/translator/AstTranslator.java
View File

@ -84,7 +84,6 @@ import com.ibm.wala.util.collections.HashSetFactory;
import com.ibm.wala.util.collections.MapUtil;
import com.ibm.wala.util.collections.Pair;
import com.ibm.wala.util.debug.Assertions;
import com.ibm.wala.util.graph.INodeWithNumber;
import com.ibm.wala.util.graph.impl.SparseNumberedGraph;
import com.ibm.wala.util.graph.traverse.DFS;
import com.ibm.wala.util.intset.IntSet;
@ -545,7 +544,7 @@ public abstract class AstTranslator extends CAstVisitor<AstTranslator.WalkContex
* basic block implementation used in the CFGs constructed during the
* IR-generating AST traversal
*/
protected final static class PreBasicBlock implements INodeWithNumber, IBasicBlock<SSAInstruction> {
protected final static class PreBasicBlock implements IBasicBlock<SSAInstruction> {
private static final int NORMAL = 0;
private static final int HANDLER = 1;

2
com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/impl/RangePosition.java
View File

@ -17,7 +17,7 @@ import java.net.URL;
import com.ibm.wala.cast.tree.CAstSourcePositionMap.Position;
public class RangePosition extends AbstractSourcePosition implements Position {
public class RangePosition extends AbstractSourcePosition {
private final URL url;
private final int startLine;
private final int endLine;

3
com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/analysis/typeInference/DalvikTypeInference.java
View File

@ -6,7 +6,6 @@ import com.ibm.wala.analysis.typeInference.TypeVariable;
import com.ibm.wala.fixpoint.AbstractOperator;
import com.ibm.wala.fixpoint.IVariable;
import com.ibm.wala.ssa.IR;
import com.ibm.wala.ssa.IVisitorWithAddresses;
import com.ibm.wala.ssa.SSAPhiInstruction;
import com.ibm.wala.ssa.SymbolTable;
@ -50,7 +49,7 @@ public class DalvikTypeInference extends TypeInference {
}
}
protected class TypeOperatorFactory extends TypeInference.TypeOperatorFactory implements IVisitorWithAddresses, OperatorFactory<TypeVariable> {
protected class TypeOperatorFactory extends TypeInference.TypeOperatorFactory {
@Override
public void visitPhi(SSAPhiInstruction instruction) {

2
com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/DefaultInstantiationBehavior.java
View File

@ -60,7 +60,7 @@ import com.ibm.wala.util.strings.Atom;
* @author Tobias Blaschke <code@tobiasblaschke.de>
* @since 2013-10-25
*/
public class DefaultInstantiationBehavior extends IInstantiationBehavior implements Serializable {
public class DefaultInstantiationBehavior extends IInstantiationBehavior {
/* package-private */ static final class BehviourValue implements Serializable {
public final InstanceBehavior behaviour;

2
com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/LoadedInstantiationBehavior.java
View File

@ -60,7 +60,7 @@ import com.ibm.wala.util.strings.Atom;
* @author Tobias Blaschke <code@tobiasblaschke.de>
* @since 2013-10-25
*/
public class LoadedInstantiationBehavior extends IInstantiationBehavior implements Serializable {
public class LoadedInstantiationBehavior extends IInstantiationBehavior {
private static final class BehviourValue implements Serializable {
public final InstanceBehavior behaviour;

2
com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/impl/AndroidEntryPoint.java
View File

@ -189,7 +189,7 @@ public class AndroidEntryPoint extends DexEntryPoint {
* Before building the model a list of AdroidEntryPoints is to be sorted by that criterion.
* You can use AndroidEntryPoint.ExecutionOrderComperator for that task.
*/
public static class ExecutionOrder implements Comparable<IExecutionOrder>, IExecutionOrder {
public static class ExecutionOrder implements IExecutionOrder {
// This is an Enum-Style class
/** Visit the EntryPoint once at the beginning of the model use that for initialization stuff */
public final static ExecutionOrder AT_FIRST = new ExecutionOrder(0);

3
com.ibm.wala.util/src/com/ibm/wala/dataflow/graph/BitVectorIntersection.java
View File

@ -12,14 +12,13 @@
package com.ibm.wala.dataflow.graph;
import com.ibm.wala.fixpoint.BitVectorVariable;
import com.ibm.wala.fixpoint.FixedPointConstants;
import com.ibm.wala.util.intset.IntSet;
import com.ibm.wala.util.intset.IntSetAction;
/**
* Operator U(n) = U(n) n U(j)
*/
public final class BitVectorIntersection extends AbstractMeetOperator<BitVectorVariable> implements FixedPointConstants {
public final class BitVectorIntersection extends AbstractMeetOperator<BitVectorVariable> {
private static final BitVectorIntersection INSTANCE = new BitVectorIntersection();

3
com.ibm.wala.util/src/com/ibm/wala/dataflow/graph/BitVectorUnion.java
View File

@ -11,12 +11,11 @@
package com.ibm.wala.dataflow.graph;
import com.ibm.wala.fixpoint.BitVectorVariable;
import com.ibm.wala.fixpoint.FixedPointConstants;
/**
* Operator U(n) = U(n) U U(j)
*/
public class BitVectorUnion extends AbstractMeetOperator<BitVectorVariable> implements FixedPointConstants {
public class BitVectorUnion extends AbstractMeetOperator<BitVectorVariable> {
private final static BitVectorUnion SINGLETON = new BitVectorUnion();

3
com.ibm.wala.util/src/com/ibm/wala/dataflow/graph/BooleanUnion.java
View File

@ -11,12 +11,11 @@
package com.ibm.wala.dataflow.graph;
import com.ibm.wala.fixpoint.BooleanVariable;
import com.ibm.wala.fixpoint.FixedPointConstants;
/**
* Operator U(n) = U(n) U U(j)
*/
public class BooleanUnion extends AbstractMeetOperator<BooleanVariable> implements FixedPointConstants {
public class BooleanUnion extends AbstractMeetOperator<BooleanVariable> {
private final static BooleanUnion SINGLETON = new BooleanUnion();

3
com.ibm.wala.util/src/com/ibm/wala/fixedpoint/impl/NullaryOperator.java
View File

@ -12,14 +12,13 @@
package com.ibm.wala.fixedpoint.impl;
import com.ibm.wala.fixpoint.AbstractOperator;
import com.ibm.wala.fixpoint.FixedPointConstants;
import com.ibm.wala.fixpoint.IVariable;
/**
* An operator of the form lhs = op
*/
@SuppressWarnings("rawtypes")
public abstract class NullaryOperator<T extends IVariable> extends AbstractOperator<T> implements FixedPointConstants {
public abstract class NullaryOperator<T extends IVariable> extends AbstractOperator<T> {
@Override
public byte evaluate(T lhs, T[] rhs) throws UnsupportedOperationException {

2
com.ibm.wala.util/src/com/ibm/wala/fixpoint/UnaryOperator.java
View File

@ -17,7 +17,7 @@ import com.ibm.wala.util.debug.UnimplementedError;
* An operator of the form lhs = op (rhs)
*/
@SuppressWarnings("rawtypes")
public abstract class UnaryOperator<T extends IVariable> extends AbstractOperator<T> implements FixedPointConstants {
public abstract class UnaryOperator<T extends IVariable> extends AbstractOperator<T> {
/**
* Evaluate this equation, setting a new value for the left-hand side.

3
com.ibm.wala.util/src/com/ibm/wala/util/config/FileOfClasses.java
View File

@ -14,14 +14,13 @@ import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.Serializable;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
/**
* An object which represents a set of classes read from a text file.
*/
public class FileOfClasses extends SetOfClasses implements Serializable {
public class FileOfClasses extends SetOfClasses {
/* Serial version */
private static final long serialVersionUID = -3256390509887654322L;

2
com.ibm.wala.util/src/com/ibm/wala/util/graph/traverse/NumberedDFSDiscoverTimeIterator.java
View File

@ -20,7 +20,7 @@ import com.ibm.wala.util.graph.NumberedGraph;
* increasing discover time. This class follows the outNodes of the graph nodes to define the graph, but this behavior can be
* changed by overriding the getConnected method.
*/
public class NumberedDFSDiscoverTimeIterator<T> extends GraphDFSDiscoverTimeIterator<T> implements Iterator<T> {
public class NumberedDFSDiscoverTimeIterator<T> extends GraphDFSDiscoverTimeIterator<T> {
private static final long serialVersionUID = -3919708273323217304L;

2
com.ibm.wala.util/src/com/ibm/wala/util/graph/traverse/NumberedDFSFinishTimeIterator.java
View File

@ -20,7 +20,7 @@ import com.ibm.wala.util.graph.NumberedGraph;
* increasing discover time. This class follows the outNodes of the graph nodes to define the graph, but this behavior can be
* changed by overriding the getConnected method.
*/
public class NumberedDFSFinishTimeIterator<T> extends DFSFinishTimeIterator<T> implements Iterator<T> {
public class NumberedDFSFinishTimeIterator<T> extends DFSFinishTimeIterator<T> {
public static final long serialVersionUID = 8737376661L;
/**

2
com.ibm.wala.util/src/com/ibm/wala/util/graph/traverse/SlowDFSDiscoverTimeIterator.java
View File

@ -22,7 +22,7 @@ import com.ibm.wala.util.graph.Graph;
* discover time. This class follows the outNodes of the graph nodes to define the graph, but this behavior can be changed by
* overriding the getConnected method.
*/
public class SlowDFSDiscoverTimeIterator<T> extends GraphDFSDiscoverTimeIterator<T> implements Iterator<T> {
public class SlowDFSDiscoverTimeIterator<T> extends GraphDFSDiscoverTimeIterator<T> {
public static final long serialVersionUID = 9439217987188L;
/**

4
com.ibm.wala.util/src/com/ibm/wala/util/intset/BitVector.java
View File

@ -10,11 +10,9 @@
*******************************************************************************/
package com.ibm.wala.util.intset;
import java.io.Serializable;
/**
*/
public class BitVector extends BitVectorBase<BitVector> implements Serializable {
public class BitVector extends BitVectorBase<BitVector> {
private static final long serialVersionUID = 9087259335807761617L;

4
com.ibm.wala.util/src/com/ibm/wala/util/intset/MutableSparseIntSet.java
View File

@ -10,8 +10,6 @@
*******************************************************************************/
package com.ibm.wala.util.intset;
import java.io.Serializable;
import com.ibm.wala.util.debug.Assertions;
/**
@ -23,7 +21,7 @@ import com.ibm.wala.util.debug.Assertions;
* TODO: even for small sets, we probably want to work on this to reduce the
* allocation activity.
*/
public class MutableSparseIntSet extends SparseIntSet implements MutableIntSet, Serializable {
public class MutableSparseIntSet extends SparseIntSet implements MutableIntSet {
/**
* If forced to grow the backing array .. then by how much

3
com.ibm.wala.util/src/com/ibm/wala/util/intset/SparseIntSet.java
View File

@ -10,7 +10,6 @@
*******************************************************************************/
package com.ibm.wala.util.intset;
import java.io.Serializable;
import java.util.Iterator;
import java.util.NoSuchElementException;
import java.util.StringTokenizer;
@ -22,7 +21,7 @@ import com.ibm.wala.util.debug.UnimplementedError;
/**
* A sparse ordered, duplicate-free, fully-encapsulated set of integers; not necessary mutable
*/
public class SparseIntSet implements IntSet, Serializable {
public class SparseIntSet implements IntSet {
private final static int SINGLETON_CACHE_SIZE = 5000;