From b012b2114778561865eeb2eeaf49364adaa565ba Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Wed, 22 Mar 2017 20:17:33 -0500 Subject: [PATCH] Remove "@return" for void-returning functions --- .../source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java | 1 - .../callgraph/androidModel/parameters/FlatInstantiator.java | 3 --- .../ipa/callgraph/androidModel/parameters/Instantiator.java | 3 --- .../source/org/scandroid/synthmethod/XMLSummaryWriter.java | 1 - 4 files changed, 8 deletions(-) diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java index 64b44ab41..e90a83dfe 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java @@ -1722,7 +1722,6 @@ public abstract class CAstVisitor { * Visit an InstanceOf node. * @param n the node to process * @param c a visitor-specific context - * @return true if no further processing is needed */ protected void leaveAssert(CAstNode n, C c, CAstVisitor visitor) { visitor.leaveNode(n, c, visitor); } protected boolean visitAssert(CAstNode n, C c, CAstVisitor visitor) { return visitor.visitNode(n, c, visitor); } diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/FlatInstantiator.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/FlatInstantiator.java index b17570184..332f74887 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/FlatInstantiator.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/FlatInstantiator.java @@ -343,9 +343,6 @@ public class FlatInstantiator implements IInstantiator { return instance; } - /** - * @return an unallocated SSAVariable - */ private void createPrimitive(SSAValue instance) { // XXX; something else? instance.setAssigned(); diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/Instantiator.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/Instantiator.java index 2becf31da..be6fe5d1e 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/Instantiator.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/parameters/Instantiator.java @@ -344,9 +344,6 @@ public class Instantiator implements IInstantiator { return instance; } - /** - * @return an unallocated SSAVariable - */ private void createPrimitive(SSAValue instance) { // XXX; something else? instance.setAssigned(); diff --git a/com.ibm.wala.scandroid/source/org/scandroid/synthmethod/XMLSummaryWriter.java b/com.ibm.wala.scandroid/source/org/scandroid/synthmethod/XMLSummaryWriter.java index 2d5453e7a..13c781b4a 100644 --- a/com.ibm.wala.scandroid/source/org/scandroid/synthmethod/XMLSummaryWriter.java +++ b/com.ibm.wala.scandroid/source/org/scandroid/synthmethod/XMLSummaryWriter.java @@ -175,7 +175,6 @@ public class XMLSummaryWriter { * No guarantees as to the state of the Document if an exception is thrown. * * @param summary - * @return * @throws DOMException * @throws UTFDataFormatException * @throws SSASerializationException