From b8264b884da3dd1cd144561d338a1c18eff6a8da Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Wed, 22 Mar 2017 19:57:53 -0500 Subject: [PATCH] Remove "@param" tags for which there is no corresponding parameter --- .../cast/java/translator/jdt/JDTJava2CAstTranslator.java | 6 ------ .../wala/cast/java/translator/jdt/JDTTypeDictionary.java | 1 - .../wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java | 1 - .../java/com/ibm/wala/cast/tree/visit/CAstVisitor.java | 1 - com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java | 1 - .../src/com/ibm/wala/util/ssa/SSAValueManager.java | 1 - .../com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java | 2 -- .../dalvik/ipa/callgraph/androidModel/AndroidModel.java | 1 - .../source/org/scandroid/util/AndroidAnalysisContext.java | 2 -- .../src/com/ibm/wala/shrikeCT/ConstantPoolParser.java | 1 - 10 files changed, 17 deletions(-) diff --git a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java index 33c46739e..ae4299e23 100644 --- a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java +++ b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java @@ -1681,9 +1681,6 @@ public abstract class JDTJava2CAstTranslator { * where field 'y' is parameterized to type string. then += is not defined for type 'object'. This function is a hack that expands * the code into an assignment and binary operation. * - * @param leftCast this is the left cast in the original expression. We throw most of it away, although we use the "Cast from" and - * "cast to" - * @param left * @param context * @return */ @@ -1837,7 +1834,6 @@ public abstract class JDTJava2CAstTranslator { * owningTypeRef or the subtype that the field is accessed thru, for expanding "f = 5" into "TheClass.this.f = 5". * * @param typeOfThis - * @param owningTypeRef * @param isPrivate * @return */ @@ -1902,7 +1898,6 @@ public abstract class JDTJava2CAstTranslator { * @param targetNode Used to evaluate the field access. In the case of static field accesses, this is included in the first part of a * block -- thus it is evaluated for any side effects but thrown away. * @param fieldName Name of the field. - * @param fieldBinding This is used to determine the field's class. * @param positioningNode Used only for making a JdtPosition. * @param context * @return @@ -2839,7 +2834,6 @@ public abstract class JDTJava2CAstTranslator { /** * Giant switch statement, part deux * - * @param body * @param context * @return */ diff --git a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTTypeDictionary.java b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTTypeDictionary.java index b6052e671..b5a27c1f8 100644 --- a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTTypeDictionary.java +++ b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTTypeDictionary.java @@ -62,7 +62,6 @@ public class JDTTypeDictionary extends CAstTypeDictionaryImpl { /** * * @param ast Needed to get root type "java.lang.Object" - * @param translator */ public JDTTypeDictionary(AST ast, JDTIdentityMapper identityMapper) { fAst = ast; diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java index 259acba4a..da48c6b33 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/ipa/callgraph/ScopeMappingInstanceKeys.java @@ -89,7 +89,6 @@ abstract public class ScopeMappingInstanceKeys implements InstanceKeyFactory { * get the CGNode representing the lexical parent of {@link #creator} with * name definer * - * @param definer * @return */ public Iterator getFunargNodes(Pair name) { diff --git a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java index 43c1870c5..64b44ab41 100644 --- a/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java +++ b/com.ibm.wala.cast/source/java/com/ibm/wala/cast/tree/visit/CAstVisitor.java @@ -123,7 +123,6 @@ public abstract class CAstVisitor { * Visit scoped entities of an entity using a given iterator. * Prerequisite (unchecked): i iterates over entities scoped in n. * @param n the parent entity of the entities to process - * @param i the iterator over some scoped entities of n * @param context a visitor-specific context */ public final void visitScopedEntities(CAstEntity n, Map allScopedEntities, C context, CAstVisitor visitor) { diff --git a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java index 372a64bfa..5def15e17 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java +++ b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValue.java @@ -188,7 +188,6 @@ public class SSAValue { * * @param number access the value using this number * @param validIn optionally assign this value to a method - * @param variableName optional name of the variable * @throws IllegalArgumentException on negative parameter number */ public SSAValue(final int number, final TypeReference type, final MethodReference validIn, final VariableKey key) { diff --git a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValueManager.java b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValueManager.java index a8671ee8b..257100335 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValueManager.java +++ b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/SSAValueManager.java @@ -191,7 +191,6 @@ public class SSAValueManager { /** * Register a Phi-Instruction _after_ added to the model. * - * @param type the type the Phi-Instruction sets * @param value the number the SSA-Instruction assigns to * @param setBy the Phi-Instruction itself - may be null * @throws IllegalArgumentException if you assign to a number requested using diff --git a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java index 7e601f268..986a2bb0e 100644 --- a/com.ibm.wala.core/src/com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java +++ b/com.ibm.wala.core/src/com/ibm/wala/util/ssa/TypeSafeInstructionFactory.java @@ -391,7 +391,6 @@ public class TypeSafeInstructionFactory { * * @param iindex Zero or a positive number unique to any instruction of the same method * @param targetValue the result of the GetInstruction is placed there - * @param containingInstance The Object instance to read the field from * @param field The description of the field */ public SSAGetInstruction GetInstruction(final int iindex, final SSAValue targetValue, FieldReference field) { @@ -471,7 +470,6 @@ public class TypeSafeInstructionFactory { * @see com.ibm.wala.classLoader.JavaLanguage.JavaInstructionFactory#PutInstruction(int, int, int, FieldReference) * * @param iindex Zero or a psitive number unique to any instruction of the same method - * @param targetInstance the instance of the object to write a field of * @param newValue The value to write to the field * @param field The description of the target */ diff --git a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java index 2714f37c7..fe6fb7ad0 100644 --- a/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java +++ b/com.ibm.wala.dalvik/src/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java @@ -575,7 +575,6 @@ public class AndroidModel /* makes SummarizedMethod */ * @see com.ibm.wala.dalvik.ipa.callgraph.propagation.cfa.IntentStarters * * @param asMethod The signature to generate - * @param flags Control the behavior of the wrapper, may be null * @param caller The class of the caller; only needed depending on the flags * @param info The IntentSterter used * @param callerNd CGNoodle of the caller - may be null diff --git a/com.ibm.wala.scandroid/source/org/scandroid/util/AndroidAnalysisContext.java b/com.ibm.wala.scandroid/source/org/scandroid/util/AndroidAnalysisContext.java index 1d50ab9c9..d747952fd 100644 --- a/com.ibm.wala.scandroid/source/org/scandroid/util/AndroidAnalysisContext.java +++ b/com.ibm.wala.scandroid/source/org/scandroid/util/AndroidAnalysisContext.java @@ -115,8 +115,6 @@ public class AndroidAnalysisContext { /** * @param exclusions - * @param classpath - * @param packagename * @throws IOException * @throws IllegalArgumentException * @throws CancelException diff --git a/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/ConstantPoolParser.java b/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/ConstantPoolParser.java index 7efc0af73..3b89e320a 100644 --- a/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/ConstantPoolParser.java +++ b/com.ibm.wala.shrike/src/com/ibm/wala/shrikeCT/ConstantPoolParser.java @@ -119,7 +119,6 @@ public final class ConstantPoolParser implements ClassConstants { * @param bytes the raw class file data * @param offset the start of the constant pool data * @param itemCount the number of items in the pool - * @param classReader */ public ConstantPoolParser(byte[] bytes, int offset, int itemCount) throws InvalidClassFileException { this.bytes = bytes;