DASCA
/
WALA
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Avoid unintended control fall-through in case of weird enum value 

This `switch` statement currently covers all possible values of the
`enum` it is testing.  However, if a new value were introduced in the
future, the `switch` would have allowed control-flow to fall through
by default instead of throwing an exception as is done in all of the
other cases.  Better to throw *some* kind of exception in the default
case too.
This commit is contained in:
Ben Liblit 2017-08-06 14:28:58 -05:00 committed by Manu Sridharan
parent 7dc71151d1
commit ce335f495d
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
com.ibm.wala.shrike/src/com/ibm/wala/sourcepos/CRTData.java
View File

@ -17,6 +17,8 @@
package com.ibm.wala.sourcepos;
import com.ibm.wala.sourcepos.InvalidRangeException.Cause;
/**
* This class represents an entry in the CharacterRangeTable.
*
@ -117,13 +119,16 @@ public final class CRTData {
try {
range = new Range(source_start, source_end);
} catch (InvalidRangeException e) {
switch (e.getThisCause()) {
final Cause cause = e.getThisCause();
switch (cause) {
case END_BEFORE_START:
throw new InvalidCRTDataException(WARN_END_BEFORE_START, source_start.toString(), source_end.toString());
case START_UNDEFINED:
throw new InvalidCRTDataException(WARN_START_UNDEFINED);
case END_UNDEFINED:
throw new InvalidCRTDataException(WARN_END_UNDEFINED);
default:
throw new UnsupportedOperationException(String.format("cannot convert %s into an InvalidCRTDataException", cause));
}
} finally {
this.source_positions = range;