From d83a05affc85f94f2748bfd57df21874c097e020 Mon Sep 17 00:00:00 2001
From: Ben Liblit <liblit@cs.wisc.edu>
Date: Mon, 28 Nov 2016 14:41:52 -0600
Subject: [PATCH] Add stub DOCTYPE declarations for Eclipse plug-in manifest
 files

We actually know the full grammar for these files: it is documented at
<http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fplugin_manifest.html>.
We ought to be able to extract that DTD into a file and give each
"plugin.xml" a "<!DOCTYPE plugin SYSTEM ...>" declaration referencing
it.  Unfortunately, that leads to a new warning: "External entity
resolution is not supported by PDE."  So a stub declaration is the
best we can do.  Fortunately, Eclipse's structured editor seems to
preserve these once we add them by hand.
---
 com.ibm.wala.core.tests/plugin.xml | 1 +
 com.ibm.wala.ide.tests/plugin.xml  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/com.ibm.wala.core.tests/plugin.xml b/com.ibm.wala.core.tests/plugin.xml
index 24577d753..1d3dd8bf1 100644
--- a/com.ibm.wala.core.tests/plugin.xml
+++ b/com.ibm.wala.core.tests/plugin.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <?eclipse version="3.2"?>
+<!DOCTYPE plugin>
 <plugin>
    <extension id="HeadlessWALA"
          point="org.eclipse.core.runtime.applications">
diff --git a/com.ibm.wala.ide.tests/plugin.xml b/com.ibm.wala.ide.tests/plugin.xml
index 24577d753..1d3dd8bf1 100644
--- a/com.ibm.wala.ide.tests/plugin.xml
+++ b/com.ibm.wala.ide.tests/plugin.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <?eclipse version="3.2"?>
+<!DOCTYPE plugin>
 <plugin>
    <extension id="HeadlessWALA"
          point="org.eclipse.core.runtime.applications">