From e89c5c6562836930ac0af709031f3019b181c05b Mon Sep 17 00:00:00 2001 From: Ben Liblit Date: Tue, 21 Nov 2017 20:00:43 -0600 Subject: [PATCH] Disable deprecation warnings in modules where they are unavoidable (#263) These two modules refer to "AST.JLS8". If you have Java 9 installed, then "AST.JLS8" is marked as deprecated, and we can a warning unless we suppress or disable the deprecation warning wherever "AST.JLS8" is used. However, if you don't have Java 9 installed, then "AST.JLS8" is not deprecated, and trying to suppress deprecation warnings where "AST.JLS8" is used instead produces warnings about unnecessary warning suppression. Aagh! Turning off the deprecation warnings entirely for these two modules seems like the only sane compromise. --- com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs | 2 +- .../wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java | 1 - .../cast/java/translator/jdt/ecj/ECJSourceModuleTranslator.java | 1 - com.ibm.wala.ide.jdt/.settings/org.eclipse.jdt.core.prefs | 2 +- .../cast/java/translator/jdt/JDTSourceModuleTranslator.java | 1 - com.ibm.wala.ide.jdt/source/com/ibm/wala/ide/util/JdtUtil.java | 1 - 6 files changed, 2 insertions(+), 6 deletions(-) diff --git a/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs b/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs index c69ebb298..201e24b39 100644 --- a/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs +++ b/com.ibm.wala.cast.java.ecj/.settings/org.eclipse.jdt.core.prefs @@ -16,7 +16,7 @@ org.eclipse.jdt.core.compiler.problem.assertIdentifier=error org.eclipse.jdt.core.compiler.problem.autoboxing=error org.eclipse.jdt.core.compiler.problem.comparingIdentical=error org.eclipse.jdt.core.compiler.problem.deadCode=error -org.eclipse.jdt.core.compiler.problem.deprecation=warning +org.eclipse.jdt.core.compiler.problem.deprecation=ignore org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled org.eclipse.jdt.core.compiler.problem.discouragedReference=error diff --git a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java index 344d404a5..c9b7e28d0 100644 --- a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java +++ b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/JDTJava2CAstTranslator.java @@ -1044,7 +1044,6 @@ public abstract class JDTJava2CAstTranslator { private Collection fExceptionTypes = null; @Override - @SuppressWarnings("deprecation") public CAstType getReturnType() { if (fReturnType != null) return fTypeDict.getCAstTypeFor(fReturnType); diff --git a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/ecj/ECJSourceModuleTranslator.java b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/ecj/ECJSourceModuleTranslator.java index 77a1bda1c..692bb3cec 100644 --- a/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/ecj/ECJSourceModuleTranslator.java +++ b/com.ibm.wala.cast.java.ecj/src/com/ibm/wala/cast/java/translator/jdt/ecj/ECJSourceModuleTranslator.java @@ -184,7 +184,6 @@ public class ECJSourceModuleTranslator implements SourceModuleTranslator { } String[] sourceFiles = sources.toArray(new String[ sources.size() ]); - @SuppressWarnings("deprecation") final ASTParser parser = ASTParser.newParser(AST.JLS8); parser.setResolveBindings(true); parser.setEnvironment(libs, this.sources, null, false); diff --git a/com.ibm.wala.ide.jdt/.settings/org.eclipse.jdt.core.prefs b/com.ibm.wala.ide.jdt/.settings/org.eclipse.jdt.core.prefs index aeee0d99b..95607accf 100644 --- a/com.ibm.wala.ide.jdt/.settings/org.eclipse.jdt.core.prefs +++ b/com.ibm.wala.ide.jdt/.settings/org.eclipse.jdt.core.prefs @@ -23,7 +23,7 @@ org.eclipse.jdt.core.compiler.problem.assertIdentifier=error org.eclipse.jdt.core.compiler.problem.autoboxing=ignore org.eclipse.jdt.core.compiler.problem.comparingIdentical=error org.eclipse.jdt.core.compiler.problem.deadCode=error -org.eclipse.jdt.core.compiler.problem.deprecation=warning +org.eclipse.jdt.core.compiler.problem.deprecation=ignore org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled org.eclipse.jdt.core.compiler.problem.discouragedReference=error diff --git a/com.ibm.wala.ide.jdt/source/com/ibm/wala/cast/java/translator/jdt/JDTSourceModuleTranslator.java b/com.ibm.wala.ide.jdt/source/com/ibm/wala/cast/java/translator/jdt/JDTSourceModuleTranslator.java index 832698dfc..c0f6d9bf3 100644 --- a/com.ibm.wala.ide.jdt/source/com/ibm/wala/cast/java/translator/jdt/JDTSourceModuleTranslator.java +++ b/com.ibm.wala.ide.jdt/source/com/ibm/wala/cast/java/translator/jdt/JDTSourceModuleTranslator.java @@ -172,7 +172,6 @@ public class JDTSourceModuleTranslator implements SourceModuleTranslator { projectsFiles.get(proj).put(JavaCore.createCompilationUnitFrom(entry.getIFile()), entry); } - @SuppressWarnings("deprecation") final ASTParser parser = ASTParser.newParser(AST.JLS8); for (final Map.Entry> proj : projectsFiles.entrySet()) { diff --git a/com.ibm.wala.ide.jdt/source/com/ibm/wala/ide/util/JdtUtil.java b/com.ibm.wala.ide.jdt/source/com/ibm/wala/ide/util/JdtUtil.java index 1cd5715ad..73c8cffff 100644 --- a/com.ibm.wala.ide.jdt/source/com/ibm/wala/ide/util/JdtUtil.java +++ b/com.ibm.wala.ide.jdt/source/com/ibm/wala/ide/util/JdtUtil.java @@ -578,7 +578,6 @@ public class JdtUtil { } public static ASTNode getAST(IFile javaSourceFile) { - @SuppressWarnings("deprecation") ASTParser parser = ASTParser.newParser(AST.JLS3); parser.setSource(JavaCore.createCompilationUnitFrom(javaSourceFile)); parser.setProject(JavaCore.create(javaSourceFile.getProject()));