Commit Graph

97 Commits

Author SHA1 Message Date
Ben Liblit 0d6d9f2b2e Remove useless "@return" tags with no descriptive text 2017-12-19 16:53:56 -06:00
Ben Liblit 0286c2b048 Use Iterator2Iterable helper to convert more loops to for-each 2017-12-04 14:04:39 -08:00
Ben Liblit 544a71ae72 Remove type arguments that Java 1.7+ can infer for us 2017-12-04 14:04:39 -08:00
Julian Dolby 0ea98643f3 revert lambdas thait cause trouble with WALA Mobile. It may be that the
issue is Swing, since I think that is not on Android.
2017-12-03 11:31:29 +08:00
Ben Liblit 9c83e87cc1 Merge branch 'master' into modernization-java-8-lambdas-and-method-references 2017-11-29 10:51:33 -06:00
Ben Liblit ebfd885d22 Use modern for-each loops where possible
Java sources used as test data have been excluded from this mass
clean-up.
2017-11-28 14:44:53 -06:00
Ben Liblit 8ef6ad5069 Add proper type parameters to nearly all uses of Iterator
Java sources used as test data have been excluded.
2017-11-28 14:09:30 -06:00
Ben Liblit 74e0640771 Replace simple lambdas with method references wherever possible 2017-11-27 11:31:15 -06:00
Ben Liblit 790d37781b Convert many single-method anonymous classes to lambdas
Eclipse's automated code clean-up tool did most of the heavy lifting
here: it specifically has a clean-up option for converting functional
interfaces to lambdas.  I merely had to revert the automated changes
for a single enumeration class for which it produced invalid results,
and for a few test inputs that apparently aren't set up to be compiled
with Java 8.
2017-11-27 11:31:15 -06:00
Ben Liblit d6ce679a72 Add static private serialVersionUID fields to Serializable classes
We already have plenty of examples of Serializable classes with this
field, and the vast majority of those fields have generated IDs rather
than "1L".  From this I infer that using proper serialVersionUID
fields is considered appropriate WALA coding style.
2017-08-05 13:30:35 -07:00
Ben Liblit 6087b73cee Fix or suppress all 242 Eclipse warnings about unused parameters
In general, my approach was to try to eliminate each unused parameter
using Eclipse's "Change Method Signature" refactoring.  That did not
always succeed: a parameter may be unused in some base class method,
but then be used in subclass's override of that method.  In cases
where refactoring to eliminate a parameter failed, I instead annotated
the parameter with '@SuppressWarnings("unused")' to silence the
warning.

Note: this group of changes creates a significant risk of
incompatibility for third-party WALA code.  Some removed parameters
change externally-visible APIs.  Furthermore, these changes do not
necessarily lead to Java compilation errors.  For example, suppose
third-party code subclasses a WALA class or interface, overrides a
method, but does not annotate that method as @Override.  Removing a
parameter means that the third-party method no longer overrides.  This
can quietly change code behavior without compile-time errors or
warnings.  This is exactly why one should use @Override wherever
possible, but we cannot guarantee that third-party WALA users have
done that.
2017-07-31 15:29:00 -07:00
Ben Liblit 594525a83f Fix Eclipse warnings about methods that can be declared static
The fix is to add "static" where appropriate, of course.  I've also
simplified calls to such methods to reflect the fact that they no
longer need a specific object to call the method on.

In projects that contain test inputs, I've left the non-static
declarations unchanged, and instead downgraded the warning to be
ignored.  In all other projects, this warning has been upgraded to an
error.
2017-07-14 22:38:38 -07:00
Ben Liblit fde65340d2 Fix 132 Eclipse warnings about using raw generic types 2017-03-15 11:08:20 -05:00
Julian Dolby d24519e974 cross-cutting changes to make more of WALA runnable with TeaVM. The biggest change is refactoring to AnalysisCache and friends; since TeaVM does not support SoftReference, I needed to add a layer of interfaces so that I can use a more simpleminded caching implementation for TeaVM. There are other changes to Module and friends to break connections with File and URL, which also cause TeaVM grief. I also organized imports in many places to remove unused types that caused trouble. 2017-02-02 20:33:27 -05:00
Juergen Graf eb9e74f442 add/remove @SuppressWarnings to keep in sync with wala main branch 2014-07-30 16:17:37 +02:00
Juergen Graf 6f8aee80c6 Merge branch 'wala' into master 2014-07-28 17:09:02 +02:00
Juergen Graf 4772f36d47 add standard type parameter to most pointer analysis references. When it breaks we move back to ? extends InstanceKey. 2014-05-20 22:00:06 +02:00
Juergen Graf ef4513d377 revert PointerAnalysis hack that makes containsAny() and contains() methods in OrdinalSet unusable 2014-05-20 19:52:01 +02:00
Michael Heilmann 45fe53a8bf make NodeDecorator generic 2014-05-20 13:12:03 +02:00
Juergen Graf cdaaddf88b Merge branch 'wala' into master 2013-07-02 14:23:24 +02:00
Julian Dolby 080325b5f6 merge 2013-06-25 11:57:37 -04:00
Manu Sridharan 3b1889121b add missing copyright headers 2013-05-22 15:39:19 -07:00
Juergen Graf 61d7a33928 remove warnings in com.ibm.wala.core 2013-03-12 00:50:17 +01:00
Manu Sridharan 256cd06460 Convert all Java source files to use Unix line endings; no semantic change 2012-09-04 15:56:05 -07:00
msridhar1 59e46916ce Generalize certain IR data structures to be less Java-specific. Generalize annotations code to allow for reading annotation parameters. Various other fixes
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@4290 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2011-12-28 17:03:27 +00:00
dolby-oss 7a6af352b9 moved IR-independent visualization of graphs to util project
added DFS path find that finds all paths in sequence rather than just one
moved the WalaException out of warnings subpackage

git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@4257 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2011-08-16 16:51:11 +00:00
msridhar1 857e456806 organize imports
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@4081 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2011-04-03 04:08:05 +00:00
yinnon_haviv a0fb3b089f bugfix: improve pointing to source code.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3958 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2010-09-30 21:32:45 +00:00
yinnon_haviv 9cae049830 Added viewer for CHA/CG/PA for Java/JavaScript.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3954 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2010-09-28 17:11:12 +00:00
sjfink b7fa860ba1 tweak comments
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3722 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-07-13 17:51:58 +00:00
sjfink a0efbee8ff Major refactoring to introduce com.ibm.wala.ide. Many related changes and patches from Marcelo Paternostro.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3693 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-06-22 15:06:12 +00:00
msridhar1 3bc7861a73 add flag to control whether domain is printed
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3640 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-06-05 15:56:55 +00:00
msridhar1 976d16d03f Made ExplodedControlFlowGraph.ExplodedBasicBlock private and changed references to point to IExplodedBasicBlock. Also, small cleanups in AbstractInterproceduralCFG, and deleted CallSiteReference.cloneReference()
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3619 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-05-29 14:51:01 +00:00
dolby-oss 43cf48ae67 support for EPS format
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3546 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-30 02:01:31 +00:00
msridhar1 7f6fe71d4c comments, rename some variables
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3543 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-29 18:04:03 +00:00
msridhar1 e08ed2663f Deprecate Iterator2Collection.toCollection(); use toSet() or toList() instead.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3421 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-09 15:24:42 +00:00
msridhar1 50a19ca3f9 fixes to accomodate default PDF output; no API changes for now
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3413 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-03 19:08:50 +00:00
msridhar1 98c651fee4 rename a bunch of things from GV to PDF. Fix up example launchers to take input from workspace_loc instead of c:\temp.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3412 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-03 18:25:05 +00:00
msridhar1 7be3f3c8f9 change default output to PDF
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3407 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-03 15:56:41 +00:00
sjfink b8f49b5564 precondition checks and documentation
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3310 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-13 21:16:38 +00:00
sjfink e4a6ae61a7 more IllegalArgumentExceptions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3286 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-11 19:33:02 +00:00
sjfink 4472b30826 more IllegalArgumentExceptions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3279 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-11 17:44:29 +00:00
sjfink f63e374a4b more IllegalArgumentExceptions. a few small bug fixes
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3278 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-11 16:57:32 +00:00
sjfink 4d1f7ab35f more IllegalArgumentExceptions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3272 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-10 21:18:07 +00:00
sjfink c567aefe65 bug fix
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3264 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-09 17:55:27 +00:00
sjfink d2267f64f9 patch from Ishizaki-san; minor enhancements
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3262 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-09 17:29:24 +00:00
sjfink dc16b65507 a little refactoring and a new entrypoint
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3121 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-12-05 16:59:29 +00:00
sjfink 34b71378d8 some generalizations to support SVG
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3059 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-10-16 14:36:46 +00:00
msridhar1 104dce02b1 add PlatformUtil for platform-specific functionality
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3037 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-09-12 21:19:51 +00:00
sjfink f87e7228c0 print exception def'fed in call instructions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3029 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-09-04 20:12:27 +00:00