Commit Graph

54 Commits

Author SHA1 Message Date
Julian Dolby c8cdaf8616 further refactoring to enable more reuse
eliminate all non-jva 8 compilation
2018-02-05 15:18:37 -08:00
Ben Liblit 0d6d9f2b2e Remove useless "@return" tags with no descriptive text 2017-12-19 16:53:56 -06:00
Ben Liblit 0286c2b048 Use Iterator2Iterable helper to convert more loops to for-each 2017-12-04 14:04:39 -08:00
Ben Liblit ebfd885d22 Use modern for-each loops where possible
Java sources used as test data have been excluded from this mass
clean-up.
2017-11-28 14:44:53 -06:00
Julian Dolby 004a81deba Merge branch 'master' of https://github.com/wala/WALA 2017-07-13 13:02:29 -04:00
Ben Liblit e316471d88 Fix nearly all Eclipse warnings about using raw types
Along the way, I also converted many "for (;;)" loops into modern
"for (:)" loops.  I didn't systematically look for all opportunities
to do this, though.  I merely made this change where I was already
converting raw Iterator uses into modern Iterator<...> uses.

Better use of generics also allowed many casts to become statically
redundant.  I have removed all such redundant casts.

Only three raw-types warnings remain after this batch of fixes.  All
three involve raw uses of CallGraphBuilder.  I've tried to fix these
too, but it quickly snowballs into a cascade of changes that may or
may not eventually reach a statically-type-save fixed point.  I may
give these last few problem areas another go in the future.  For now,
though, the hundreds of other fixes seem worth keeping even if there
are a few stragglers.

This commit may change some public APIs, but only by making weaker
type signatures stronger by replacing raw types with generic types.
For example, we may change something like "Set" into "Set<String>",
but we're not adding new arguments, changing any
underlying (post-generics-erasure) types, etc.
2017-07-12 10:39:06 -07:00
Julian Dolby 163e10f5e4 Merge branch 'warning-fixes-plug-in-development-misc' of https://github.com/liblit/WALA 2017-06-22 09:27:47 +02:00
Ben Liblit 72c754e874 Declare private methods static wherever possible
If a method is private, there's no risk that a subclass elsewhere
might be overriding it and depending on dynamic dispatch to choose the
right implementation.  So all of these private methods can safely be
declared static without risk of regression in either WALA code or
unseen third-party code.
2017-06-07 08:29:23 -07:00
Julian Dolby 6cdeedd5e9 changes for analysis cache view 2017-03-15 22:06:19 -04:00
Ben Liblit 994a70500f Remove redundant generic type parameters where possible
Instead, rely on Java's ability to infer type parameters in many
contexts.  This removes 665 Eclipse warnings.

Note: a few of these changes are to files under "test" subdirectories.
Presumably those are files that serve as test inputs rather than being
part of WALA code proper.  As far as I can tell, these changes do not
break any WALA tests.  But if any of those tests were specifically
intended to exercise WALA on code with non-inferred generic type
parameters, then I really should be leaving those alone.
2017-03-11 21:20:51 -06:00
Julian Dolby d24519e974 cross-cutting changes to make more of WALA runnable with TeaVM. The biggest change is refactoring to AnalysisCache and friends; since TeaVM does not support SoftReference, I needed to add a layer of interfaces so that I can use a more simpleminded caching implementation for TeaVM. There are other changes to Module and friends to break connections with File and URL, which also cause TeaVM grief. I also organized imports in many places to remove unused types that caused trouble. 2017-02-02 20:33:27 -05:00
Julian Dolby c9b1006305 changes for allowing seq. and conc. CHAs 2017-01-12 16:34:54 -05:00
Juergen Graf 4772f36d47 add standard type parameter to most pointer analysis references. When it breaks we move back to ? extends InstanceKey. 2014-05-20 22:00:06 +02:00
Julian Dolby b057e35e2c for now, ignore tests impacted by library change 2013-11-26 19:26:52 -05:00
Manu Sridharan 878cfa615d changes to get tests passing on Java 7 2013-05-26 10:07:46 -07:00
Manu Sridharan 256cd06460 Convert all Java source files to use Unix line endings; no semantic change 2012-09-04 15:56:05 -07:00
msridhar1 253444a6ad make demand pointer analysis tests less dependent on standard library implementation
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@4234 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2011-07-25 18:10:31 +00:00
msridhar1 fb10bd4611 uncomment test and indicate why we don't currently run it
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@4063 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2011-03-01 18:15:17 +00:00
msridhar1 f76602dbfb clean up interface for creating a DemandRefinementPointsTo class, and make the internal ThisFilteringHeapModel package visible
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3827 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2010-04-30 17:13:14 +00:00
msridhar1 9fc5e5f016 one more flows-to test
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3767 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-11-19 17:12:21 +00:00
msridhar1 4b34785700 bug fixes for flows-to
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3766 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-11-19 17:09:20 +00:00
msridhar1 24caeb7088 more flows-to tests
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3765 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-11-18 22:15:23 +00:00
msridhar1 f6afa934f8 bug fix for flows-to
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3764 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-11-18 21:53:07 +00:00
msridhar1 65bb454180 added ability to compute "flows-to sets" on demand; initial check-in, needs more testing
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3763 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-11-18 21:22:33 +00:00
msridhar1 105a263cc5 cached class hierarchy to speed things up
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3740 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-07-27 21:03:33 +00:00
msridhar1 02e7bf2894 switch to jUnit 4
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3739 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-07-27 20:38:48 +00:00
sjfink a0efbee8ff Major refactoring to introduce com.ibm.wala.ide. Many related changes and patches from Marcelo Paternostro.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3693 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-06-22 15:06:12 +00:00
sjfink de6adbc4d7 more migration to Java assertions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3559 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-05-01 17:42:28 +00:00
sjfink 9939142eae switch from Assertions._assert to Java assertions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3555 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-30 13:16:52 +00:00
sjfink 957cb2b8ca deprecate Trace
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3432 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-09 20:31:14 +00:00
sjfink 95a36cedd9 more UTF-8
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2864 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-05-29 12:04:31 +00:00
sjfink 6a6ab3346c use UTF-8 in comments
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2859 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-05-28 18:03:34 +00:00
msridhar1 aa07659a5d new method pointsToPassesPred() for demand points-to analysis; various refactorings; some new tests
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2820 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-05-16 19:19:53 +00:00
msridhar1 5569d461af switch demandpa tests to use PABasedMemoryAccessMap
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2818 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-05-15 18:32:23 +00:00
msridhar1 3ee24d710e added PABasedMemoryAccessMap; added getHeapModel() to MemoryAccessMap
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2817 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-05-15 18:04:43 +00:00
msridhar1 3f293dcc60 various refactorings for demand points-to analysis
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2758 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-04-12 21:58:39 +00:00
sjfink 3085b16ae6 more reflection support
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2672 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-03-04 19:48:37 +00:00
msridhar1 f591d8a309 updated some values for 0-CFA call graph
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2669 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-03-04 17:32:47 +00:00
msridhar1 bb2d20cba4 switched to 0-CFA call graphs
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2668 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-03-04 17:32:26 +00:00
sjfink 511afd1dec tweak expected points-to set sizes
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2658 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-03-04 03:36:22 +00:00
msridhar1 3045547331 use static field instead of String constant
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2631 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-02-27 22:30:01 +00:00
sjfink d6c5b3bb55 thread IProgressMonitor and CancelException through many APIs
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2578 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-02-13 22:34:50 +00:00
msridhar1 e6713ae685 generalization of memory access maps
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2472 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-01-25 02:22:42 +00:00
sjfink fa2968ca06 move WalaUtil to example driver package
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2468 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-01-24 23:21:47 +00:00
sjfink 4f0c72599f just refactoring ... introduce 2 new packages in wala.util.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2450 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-01-24 22:06:31 +00:00
msridhar1 a95c9fd0d1 refactoring to allow for alternative flow graph implementations
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2432 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-01-23 03:17:39 +00:00
sjfink bfbe4fdd2f clean up and refactor some APIs surrounding file I/O and exclusions files. Needed in order to allow clients to use some APIs with application-specific exclusions.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2248 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-01-02 22:27:45 +00:00
msridhar1 5ac9b19f62 changes to make tests pass when analyzing 1.5 libraries
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2222 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-12-19 00:20:14 +00:00
dolby-oss 1d62ddf160 remove EMF
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2162 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-12-12 20:47:35 +00:00
sjfink 0e041c99f2 add CancelException to interact with Eclipse progress monitors and thread it through some APIs
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2004 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-11-13 16:19:01 +00:00