Commit Graph

28 Commits

Author SHA1 Message Date
Ben Liblit 6087b73cee Fix or suppress all 242 Eclipse warnings about unused parameters
In general, my approach was to try to eliminate each unused parameter
using Eclipse's "Change Method Signature" refactoring.  That did not
always succeed: a parameter may be unused in some base class method,
but then be used in subclass's override of that method.  In cases
where refactoring to eliminate a parameter failed, I instead annotated
the parameter with '@SuppressWarnings("unused")' to silence the
warning.

Note: this group of changes creates a significant risk of
incompatibility for third-party WALA code.  Some removed parameters
change externally-visible APIs.  Furthermore, these changes do not
necessarily lead to Java compilation errors.  For example, suppose
third-party code subclasses a WALA class or interface, overrides a
method, but does not annotate that method as @Override.  Removing a
parameter means that the third-party method no longer overrides.  This
can quietly change code behavior without compile-time errors or
warnings.  This is exactly why one should use @Override wherever
possible, but we cannot guarantee that third-party WALA users have
done that.
2017-07-31 15:29:00 -07:00
Cosmin Radoi e2dce7be00 SSAInstruction equals based on iindex 2014-11-10 19:40:45 -06:00
Juergen Graf cdaaddf88b Merge branch 'wala' into master 2013-07-02 14:23:24 +02:00
Julian Dolby 080325b5f6 merge 2013-06-25 11:57:37 -04:00
Cosmin Radoi d137143ecf warning on SSAInstruction equals() 2013-04-08 17:08:32 -05:00
Juergen Graf b82d5dba90 Merge branch 'wala' into master 2012-11-06 04:23:10 +01:00
Manu Sridharan 256cd06460 Convert all Java source files to use Unix line endings; no semantic change 2012-09-04 15:56:05 -07:00
Juergen Graf 7c518d1867 added instruction index field to SSAInstruction (javascript not working atm) 2011-04-12 19:49:06 +02:00
omertripp 95d9ef4887 MAINT: - moved SSAAddressOfInstruction into its own interface to avoid client breakages.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3610 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-05-24 14:04:05 +00:00
sjfink 499738f3a3 roll back breaking API change
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3609 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-05-24 12:57:44 +00:00
omertripp 1d99b357cf MAINT: - default support for visiting SSAAddressOfInstruction in the IVisitor interface. SSAAddressOfInstruction.visit() now dispatches to the IVisitor method.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3608 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-05-24 05:22:10 +00:00
sjfink 0b9c9e111c comments
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3517 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-22 18:09:39 +00:00
dolby-oss e80dc6ef8c refactor handling of constants in Shrike to abstract away from Java bytecode
introduce factories to create SSAInstruction objects


git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3433 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-10 18:33:07 +00:00
dolby-oss b61135c8be adapt to Shrike changes: divorce SSAInstruction from the Shrike Instruction, which requires adding a type parameter to ControlFlowGraph and propagating that change. Also, stop using the JVML opcode in a few places where it was (unnecessarily) being used.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3227 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-02-19 15:58:31 +00:00
sjfink 1f3fe79f3b tweak comments
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3030 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-09-04 20:13:06 +00:00
sjfink f78205f84f delete obsolete ValueDecorator interface
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2387 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-01-15 14:39:58 +00:00
sjfink b541916b65 add a comment
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2385 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-01-15 14:05:56 +00:00
sjfink 5d999de356 getExceptionTypes() should not return null.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1816 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-10-04 12:39:57 +00:00
sjfink 8864b70d50 miscellaneous housekeeping
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1364 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-07-06 03:07:14 +00:00
sjfink ea3caa1e8a mostly clean up old comments.
also rename InferGraphRootsImpl to InferGraphRoots

git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1200 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-05-30 19:05:23 +00:00
sjfink fdb7a17af3 add @Overrides annotations and nuke unnecessary casts
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1197 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-05-30 15:16:05 +00:00
sjfink a03a4accd8 make SSAInstruction.equals() consistently use ==
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1047 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-05-03 17:26:31 +00:00
dolby-oss 57742fc75a add comments
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1021 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-04-27 14:35:49 +00:00
sjfink ec2e0f5967 misc minor cleanups, annotations, and bug fixes
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1009 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-04-26 14:47:41 +00:00
sjfink 4a29f033c8 annotations and minor cleanups
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1008 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-04-26 13:53:16 +00:00
sjfink be1415de88 more generics
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@684 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-02-08 20:17:02 +00:00
sjfink 29523612f1 misc bug fixes and dead code elimination
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@572 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-01-15 15:06:11 +00:00
sjfink df97f42b7e attempt to introduce tags and trunk
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@490 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2006-11-22 17:38:46 +00:00