Commit Graph

23 Commits

Author SHA1 Message Date
Ben Liblit ab791f8c41 Throw a loud exception if switch encounters unexpected enum value
Previously each of these `switch` statements would implicitly do
nothing if an unanticipated `enum` value came along.  My impression is
that each of these `switch` statements is supposed to be exhaustive,
such that an unexpected (unhandled) value should never appear.  If one
does, we should recognize it and complain loudly.

Of course, sometimes the right behavior for previously-unhandled
values is to do nothing.  It may not always be clear whether an
exception or doing nothing is the right choice.  For this commit,
WALA's regression tests still pass even with the possibility of
throwing an exception for unexpected values.  If we assume that the
test suite is thorough, that tells me that throwing an exception is
the right policy for each `switch` statement that I'm changing here.
2017-08-15 14:55:34 -07:00
Ben Liblit d6ce679a72 Add static private serialVersionUID fields to Serializable classes
We already have plenty of examples of Serializable classes with this
field, and the vast majority of those fields have generated IDs rather
than "1L".  From this I infer that using proper serialVersionUID
fields is considered appropriate WALA coding style.
2017-08-05 13:30:35 -07:00
Andreas Sewe d0b5e8ddd2 Made TypeName.findOrCreate thread-safe 2013-05-07 14:54:14 -07:00
Manu Sridharan 256cd06460 Convert all Java source files to use Unix line endings; no semantic change 2012-09-04 15:56:05 -07:00
dolby 4cc3a08b63 comment attempting to explain how 'dimensionality' works 2012-08-31 15:45:56 -04:00
Manu Sridharan bab4777e4c some (very) basic support for pointer / reference types 2012-08-21 16:56:18 -07:00
msridhar1 59e46916ce Generalize certain IR data structures to be less Java-specific. Generalize annotations code to allow for reading annotation parameters. Various other fixes
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@4290 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2011-12-28 17:03:27 +00:00
sjfink a5edb7eeda minor formatting and comment
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3533 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-24 14:47:08 +00:00
sjfink 96e5952a05 formatting
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3468 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-16 19:14:51 +00:00
sjfink 26ed4e00ed tweak comments
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3467 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-04-16 19:03:55 +00:00
sjfink b001a5d2f5 more IllegalArgumentExceptions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3292 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-12 16:02:13 +00:00
yinnon_haviv 235a85fe36 Added the possibility to serialize analysis scope.
ShallowAnalysisScope can be created from an analysis scope.
It includes all information but the array class loader (for which serialization is problematic).



git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3276 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-11 15:26:28 +00:00
sjfink 4d1f7ab35f more IllegalArgumentExceptions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@3272 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2009-03-10 21:18:07 +00:00
sjfink 54e1f8ff05 just whitespace
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2634 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-02-28 19:39:24 +00:00
sjfink e6a904b715 just refactoring ... introduce 2 new packages in wala.util.
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@2446 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2008-01-24 22:05:28 +00:00
sjfink ea3caa1e8a mostly clean up old comments.
also rename InferGraphRootsImpl to InferGraphRoots

git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1200 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-05-30 19:05:23 +00:00
sjfink fdb7a17af3 add @Overrides annotations and nuke unnecessary casts
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1197 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-05-30 15:16:05 +00:00
sjfink b0598a95f4 more argument checking
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1133 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-05-15 19:35:57 +00:00
sjfink 4acf542744 validate some arguments; throw IllegalArgumentExceptions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1119 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-05-15 03:15:05 +00:00
sjfink 5f3bb0aa86 add some more functions to look up instructions
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@1051 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-05-03 20:09:42 +00:00
sjfink e2c552a1cb misc. bug fixes and annotations
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@579 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-01-15 18:31:55 +00:00
sjfink ebd6e0e151 add getClassName()
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@535 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2007-01-08 17:20:43 +00:00
sjfink df97f42b7e attempt to introduce tags and trunk
git-svn-id: https://wala.svn.sourceforge.net/svnroot/wala/trunk@490 f5eafffb-2e1d-0410-98e4-8ec43c5233c4
2006-11-22 17:38:46 +00:00