b1678882b3
This fixes 33 out of 37 Eclipse "Potential resource leak: '...' may not be closed" warnings. It also fixes 3 out of 37 Eclipse "Resource '...' should be managed by try-with-resource" warnings, although that was not the main focus of this effort. The remaining 4 warnings about potential resource leaks all involve a leaked JarFile instance that is passed to a JarFileModule constructor call. JarFileModile never attempts to close its underlying JarFile; this code is written as though JarFile cleanup were the caller's responsibility. However, the JarFile often cannot be closed by the code that creates the JarFileModule either, since the JarFile needs to remain open while the JarFileModule is in use, and some of these JarFileModules stay around beyond the lifetime of the code that created them. Truly fixing this would essentially require making JarFileModule implement Closeable, which in turn would probably require that Module implement Closeable, which in turn would require changes to lots of code that deals with Module instances to arrange for them to be properly closed. That's more invasive than I'm prepared to take on right now. |
||
|---|---|---|
| .. | ||
| ibm/wala | ||